* [PATCH] usb: typec: ucsi: huawei-gaokin: add DRM dependency
@ 2025-12-04 10:11 Arnd Bergmann
2025-12-04 13:21 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2025-12-04 10:11 UTC (permalink / raw)
To: Heikki Krogerus, Greg Kroah-Hartman, Pengyu Luo
Cc: Arnd Bergmann, Abhishek Pandit-Subedi, Pavan Holla, Yue Haibing,
Dmitry Baryshkov, linux-usb, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Selecting DRM_AUX_HPD_BRIDGE is not possible from a built-in driver when
CONFIG_DRM=m:
WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
Depends on [m]: HAS_IOMEM [=y] && DRM [=m] && DRM_BRIDGE [=y] && OF [=y]
Selected by [y]:
- UCSI_HUAWEI_GAOKUN [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_UCSI [=y] && EC_HUAWEI_GAOKUN [=y] && DRM_BRIDGE [=y] && OF [=y]
Add the same dependency we have in similar drivers to work around this.
Fixes: 00327d7f2c8c ("usb: typec: ucsi: add Huawei Matebook E Go ucsi driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/typec/ucsi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig
index 7fcb1e1de5d6..b812be4d0e67 100644
--- a/drivers/usb/typec/ucsi/Kconfig
+++ b/drivers/usb/typec/ucsi/Kconfig
@@ -96,6 +96,7 @@ config UCSI_LENOVO_YOGA_C630
config UCSI_HUAWEI_GAOKUN
tristate "UCSI Interface Driver for Huawei Matebook E Go"
depends on EC_HUAWEI_GAOKUN
+ depends on DRM || !DRM
select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
help
This driver enables UCSI support on the Huawei Matebook E Go tablet,
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: typec: ucsi: huawei-gaokin: add DRM dependency
2025-12-04 10:11 [PATCH] usb: typec: ucsi: huawei-gaokin: add DRM dependency Arnd Bergmann
@ 2025-12-04 13:21 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2025-12-04 13:21 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Greg Kroah-Hartman, Pengyu Luo, Arnd Bergmann,
Abhishek Pandit-Subedi, Pavan Holla, Yue Haibing,
Dmitry Baryshkov, linux-usb, linux-kernel
Thu, Dec 04, 2025 at 11:11:07AM +0100, Arnd Bergmann kirjoitti:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Selecting DRM_AUX_HPD_BRIDGE is not possible from a built-in driver when
> CONFIG_DRM=m:
>
> WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
> Depends on [m]: HAS_IOMEM [=y] && DRM [=m] && DRM_BRIDGE [=y] && OF [=y]
> Selected by [y]:
> - UCSI_HUAWEI_GAOKUN [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_UCSI [=y] && EC_HUAWEI_GAOKUN [=y] && DRM_BRIDGE [=y] && OF [=y]
>
> Add the same dependency we have in similar drivers to work around this.
>
> Fixes: 00327d7f2c8c ("usb: typec: ucsi: add Huawei Matebook E Go ucsi driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/ucsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig
> index 7fcb1e1de5d6..b812be4d0e67 100644
> --- a/drivers/usb/typec/ucsi/Kconfig
> +++ b/drivers/usb/typec/ucsi/Kconfig
> @@ -96,6 +96,7 @@ config UCSI_LENOVO_YOGA_C630
> config UCSI_HUAWEI_GAOKUN
> tristate "UCSI Interface Driver for Huawei Matebook E Go"
> depends on EC_HUAWEI_GAOKUN
> + depends on DRM || !DRM
> select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
> help
> This driver enables UCSI support on the Huawei Matebook E Go tablet,
> --
> 2.39.5
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-04 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-04 10:11 [PATCH] usb: typec: ucsi: huawei-gaokin: add DRM dependency Arnd Bergmann
2025-12-04 13:21 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox