Re: [PATCH 1/9] dt-bindings: usb: Add Tegra238 XUSB host controller support

[Jon Hunter <jonathanh@nvidia.com>]

On 28/09/2026 14:57, Jon Hunter wrote:
> 
> On 25/09/2026 14:27, Krzysztof Kozlowski wrote:
>> On Mon, Sep 21, 2026 at 01:19:01PM +0100, Jon Hunter wrote:
>>> Add a compatible string for the Tegra238 XUSB host controller. The
>>> Tegra238 XUSB host controller is similar to that found on the Tegra234
>>> device but only supports 3 PHYs compared to the 4 PHYs on the Tegra234.
>>> Hence, the binding is also updated to limit the number of PHYs that can
>>> be specified for the Tegra238 device.
>>>
>>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>>> ---
>>>   .../bindings/usb/nvidia,tegra234-xusb.yaml           | 20 ++++++++++++++++++++
>>>   1 file changed, 20 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
>>> index 3f56110be915..9d605db7e77f 100644
>>> --- a/Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
>>> +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
>>> @@ -19,6 +19,7 @@ properties:
>>>     compatible:
>>>       enum:
>>>         - nvidia,tegra234-xusb
>>> +      - nvidia,tegra238-xusb
>>>         - nvidia,tegra264-xusb
>>>     reg:
>>> @@ -154,6 +155,25 @@ properties:
>>>   allOf:
>>>     - $ref: usb-xhci.yaml
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            const: nvidia,tegra238-xusb
>>> +    then:
>>> +      properties:
>>> +        phys:
>>
>> minItems: to be explicit. I would expect minItems: 6, but your phy-names
>> is flexible, so probably wording in your commit msg should be "*up to* 3
>> PHYs compared to the...."
> ACK. I will update the commit message to make this clear that this is
> 'up to 3 PHYs'.

I have noticed that this binding does not have a 'required' section and it
should because for Tegra238 there are no power domains for USB and we only
need to control the resets. I will update the binding to add the required
section and then ensure the correct required properties are specified for
all devices. And of course I will add this detail to the commit message.

Jon

-- 
nvpublic