Linux USB
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thierry Reding <thierry.reding@kernel.org>,
	Nagarjuna Kristam <nkristam@nvidia.com>,
	JC Kuo <jckuo@nvidia.com>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-tegra@vger.kernel.org, Thierry Reding <treding@nvidia.com>,
	Wayne Chang <waynec@nvidia.com>
Subject: Re: [PATCH 2/9] dt-bindings: usb: tegra-xudc: Add Tegra238 XUDC support
Date: Fri, 2 Oct 2026 16:23:32 +0100	[thread overview]
Message-ID: <af1e3a7f-61ee-4484-8cc2-9ebd9903392e@nvidia.com> (raw)
In-Reply-To: <20260925-obedient-proficient-nyala-31f81b@quoll>


On 25/09/2026 14:28, Krzysztof Kozlowski wrote:
> On Mon, Sep 21, 2026 at 01:19:02PM +0100, Jon Hunter wrote:
>> Add a compatible string for the Tegra238 XUDC device. The Tegra238 XUDC
>> is similar to that found on the Tegra234 device but only support 3 PHYs
>> compared to the 4 PHYs on the Tegra234. The XUDC binding only defines
>> which of the available PHYs is used by the XUDC controller and the Tegra
>> XUSB pad controller binding [0] defines the PHYs that are available.
>>
>> [0] Documentation/devicetree/bindings/phy/nvidia,tegra194-xusb-padctl.yaml
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>>   Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml | 3 +++
>>   1 file changed, 3 insertions(+)
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Similarly to my recent comment for the XHCI binding, Tegra238 does not have
power-domains for USB. Unlike the UDC binding this binding has a required
section and so I should have caught this before, but I missed it and that
is my fault. I will correct this.

Jon

-- 
nvpublic


  reply	other threads:[~2026-10-02 15:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 12:19 [PATCH 0/9] usb: Add support for Tegra238 and device support for Tegra264 Jon Hunter
2026-09-21 12:19 ` [PATCH 1/9] dt-bindings: usb: Add Tegra238 XUSB host controller support Jon Hunter
2026-09-25 13:27   ` Krzysztof Kozlowski
2026-09-28 13:57     ` Jon Hunter
2026-10-02 15:21       ` Jon Hunter
2026-09-21 12:19 ` [PATCH 2/9] dt-bindings: usb: tegra-xudc: Add Tegra238 XUDC support Jon Hunter
2026-09-25 13:28   ` Krzysztof Kozlowski
2026-10-02 15:23     ` Jon Hunter [this message]
2026-09-21 12:19 ` [PATCH 3/9] dt-bindings: usb: tegra-xudc: Add Tegra264 " Jon Hunter
2026-09-25 13:28   ` Krzysztof Kozlowski
2026-09-21 12:19 ` [PATCH 4/9] usb: xhci: tegra: Add support for Tegra238 Jon Hunter
2026-09-21 12:19 ` [PATCH 5/9] usb: gadget: tegra-xudc: Fix CNT65 configuration Jon Hunter
2026-09-21 12:19 ` [PATCH 6/9] usb: gadget: tegra-xudc: Add support for Tegra238 Jon Hunter
2026-09-21 12:19 ` [PATCH 7/9] usb: gadget: tegra-xudc: Add SSPX register offset to SoC data Jon Hunter
2026-09-21 12:19 ` [PATCH 8/9] usb: gadget: tegra-xudc: Add default settings " Jon Hunter
2026-09-21 12:19 ` [PATCH 9/9] usb: gadget: tegra-xudc: Add support for Tegra264 Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af1e3a7f-61ee-4484-8cc2-9ebd9903392e@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jckuo@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=nkristam@nvidia.com \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=thierry.reding@kernel.org \
    --cc=treding@nvidia.com \
    --cc=waynec@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox