From: Johan Hovold <johan@kernel.org>
To: zwq2226404116@163.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Wanquan Zhong <wanquan.zhong@fibocom.com>
Subject: Re: [PATCH v4] USB: serial: option: Add missing RSVD(5) flag for Rolling RW135R-GL
Date: Fri, 15 May 2026 09:27:27 +0200 [thread overview]
Message-ID: <agbK37fGBbiSCn3I@hovoldconsulting.com> (raw)
In-Reply-To: <20260515033105.7746-1-zwq2226404116@163.com>
On Fri, May 15, 2026 at 11:31:05AM +0800, zwq2226404116@163.com wrote:
> From: Wanquan Zhong <wanquan.zhong@fibocom.com>
>
> The RW135R-GL MBIM interface entry was missing the .driver_info = RSVD(5) flag.
>
> Without this flag, the option driver binds to the MBIM interface
> and conflicts with the cdc_mbim driver, causing AT/MBIM communication
> failures. This matches the handling of other Rolling Wireless MBIM devices.
Please reply to this mail and explain why you think reserving interface
number 5 (i.e. the ADB interface) prevents the driver to binding to the
non-vendor MBIM interfaces number 0 and 1.
Don't send any new versions until you've explained this.
> This patch adds the missing RSVD(5) quirk for Rolling RW135R-GL (33f8:1003)
> to prevent the option driver from probing the MBIM control interface,
> which avoids conflicts with cdc_mbim and fixes communication failures.
>
> This aligns with the configuration used by all other Rolling Wireless MBIM modems.
>
> v4:
> - Fixes tag corrected
No, it's still using the wrong summary (i.e. the text inside
parenthesis). I already sent you the right one in an earlier reply, but
you can also look it up using git log.
> - Device table entry formatting aligned with existing pattern
Move the changelog after the --- line.
You also removed the usb-devices output from the commit message. Please
add it back.
> Tested successfully on multiple interface configurations:
> - mbim + diag + AT + pipe
> - mbim + diag + AT + ADB + pipe
> - mbim + pipe
>
> Fixes: 01e8d0f74222 ("usb: serial: add support for Rolling Wireless RW135R-GL (33f8:1003)")
> Signed-off-by: Wanquan Zhong <wanquan.zhong@fibocom.com>
> ---
> drivers/usb/serial/option.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Johan
prev parent reply other threads:[~2026-05-15 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 3:31 [PATCH v4] USB: serial: option: Add missing RSVD(5) flag for Rolling RW135R-GL zwq2226404116
2026-05-15 7:27 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agbK37fGBbiSCn3I@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wanquan.zhong@fibocom.com \
--cc=zwq2226404116@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox