[PATCH v4] USB: serial: option: Add missing RSVD(5) flag for Rolling RW135R-GL

[PATCH v4] USB: serial: option: Add missing RSVD(5) flag for Rolling RW135R-GL

[zwq2226404116]

From: Wanquan Zhong <wanquan.zhong@fibocom.com>

The RW135R-GL MBIM interface entry was missing the .driver_info = RSVD(5) flag.

Without this flag, the option driver binds to the MBIM interface
and conflicts with the cdc_mbim driver, causing AT/MBIM communication
failures. This matches the handling of other Rolling Wireless MBIM devices.

This patch adds the missing RSVD(5) quirk for Rolling RW135R-GL (33f8:1003)
to prevent the option driver from probing the MBIM control interface,
which avoids conflicts with cdc_mbim and fixes communication failures.

This aligns with the configuration used by all other Rolling Wireless MBIM modems.

v4:
- Fixes tag corrected
- Device table entry formatting aligned with existing pattern

Tested successfully on multiple interface configurations:
- mbim + diag + AT + pipe
- mbim + diag + AT + ADB + pipe
- mbim + pipe

Fixes: 01e8d0f74222 ("usb: serial: add support for Rolling Wireless RW135R-GL (33f8:1003)")
Signed-off-by: Wanquan Zhong <wanquan.zhong@fibocom.com>
---
 drivers/usb/serial/option.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index c71461893d20..dfec7467b36c 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -2466,7 +2466,8 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x0302, 0xff) },			/* Rolling RW101R-GL (laptop MBIM) */
 	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x0802, 0xff),			/* Rolling RW350-GL (laptop MBIM) */
 	  .driver_info = RSVD(5) },
-	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x1003, 0xff) },			/* Rolling RW135R-GL (laptop MBIM) */
+	{ USB_DEVICE_INTERFACE_CLASS(0x33f8, 0x1003, 0xff),			/* Rolling RW135R-GL (laptop MBIM) */
+	  .driver_info = RSVD(5) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x3731, 0x0100, 0xff, 0xff, 0x30) },	/* NetPrisma LCUK54-WWD for Global */
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x3731, 0x0100, 0xff, 0x00, 0x40) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x3731, 0x0100, 0xff, 0xff, 0x40) },
-- 
2.43.0

Re: [PATCH v4] USB: serial: option: Add missing RSVD(5) flag for Rolling RW135R-GL

[Johan Hovold]

On Fri, May 15, 2026 at 11:31:05AM +0800, zwq2226404116@163.com wrote:
> From: Wanquan Zhong <wanquan.zhong@fibocom.com>
> 
> The RW135R-GL MBIM interface entry was missing the .driver_info = RSVD(5) flag.
> 
> Without this flag, the option driver binds to the MBIM interface
> and conflicts with the cdc_mbim driver, causing AT/MBIM communication
> failures. This matches the handling of other Rolling Wireless MBIM devices.

Please reply to this mail and explain why you think reserving interface
number 5 (i.e. the ADB interface) prevents the driver to binding to the
non-vendor MBIM interfaces number 0 and 1.

Don't send any new versions until you've explained this.
 
> This patch adds the missing RSVD(5) quirk for Rolling RW135R-GL (33f8:1003)
> to prevent the option driver from probing the MBIM control interface,
> which avoids conflicts with cdc_mbim and fixes communication failures.
> 
> This aligns with the configuration used by all other Rolling Wireless MBIM modems.
> 
> v4:
> - Fixes tag corrected

No, it's still using the wrong summary (i.e. the text inside
parenthesis). I already sent you the right one in an earlier reply, but
you can also look it up using git log.

> - Device table entry formatting aligned with existing pattern

Move the changelog after the --- line.

You also removed the usb-devices output from the commit message. Please
add it back.
 
> Tested successfully on multiple interface configurations:
> - mbim + diag + AT + pipe
> - mbim + diag + AT + ADB + pipe
> - mbim + pipe
> 
> Fixes: 01e8d0f74222 ("usb: serial: add support for Rolling Wireless RW135R-GL (33f8:1003)")
> Signed-off-by: Wanquan Zhong <wanquan.zhong@fibocom.com>
> ---
>  drivers/usb/serial/option.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Johan