[PATCH 2/2] USB: serial: pl2303: add new PID to support PL256X (TYPE_MP)

[PATCH 2/2] USB: serial: pl2303: add new PID to support PL256X (TYPE_MP)

[Charles Yeh]

Add support for the PL256X (TYPE_MP) device by adding its PID.
Also fix an unused variable warning in pl2303_update_reg() reported
by the kernel test robot.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202603250523.9ktgw2Ju-lkp@intel.com/
Signed-off-by: Charles Yeh <charlesyeh522@gmail.com>
---
v2:
 - Remove unused 'struct device *dev' variable in pl2303_update_reg()
   to fix build warning.
---
 drivers/usb/serial/pl2303.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index e5bbda1d63b3..67b78d2fcc92 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -347,7 +347,6 @@ static int pl2303_vendor_write(struct usb_serial *serial, u16 value, u16 index)
 static int pl2303_update_reg(struct usb_serial *serial, u8 reg, u8 mask, u8 val)
 {
 	struct pl2303_serial_private *spriv = usb_get_serial_data(serial);
-	struct device *dev = &serial->interface->dev;
 	int ret = 0;
 	u8 *buf;
 
-- 
2.51.0

Re: [PATCH 2/2] USB: serial: pl2303: add new PID to support PL256X (TYPE_MP)

[Greg KH]

On Wed, Mar 25, 2026 at 08:01:23PM +0800, Charles Yeh wrote:
> Add support for the PL256X (TYPE_MP) device by adding its PID.
> Also fix an unused variable warning in pl2303_update_reg() reported
> by the kernel test robot.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202603250523.9ktgw2Ju-lkp@intel.com/
> Signed-off-by: Charles Yeh <charlesyeh522@gmail.com>
> ---
> v2:
>  - Remove unused 'struct device *dev' variable in pl2303_update_reg()
>    to fix build warning.
> ---
>  drivers/usb/serial/pl2303.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
> index e5bbda1d63b3..67b78d2fcc92 100644
> --- a/drivers/usb/serial/pl2303.c
> +++ b/drivers/usb/serial/pl2303.c
> @@ -347,7 +347,6 @@ static int pl2303_vendor_write(struct usb_serial *serial, u16 value, u16 index)
>  static int pl2303_update_reg(struct usb_serial *serial, u8 reg, u8 mask, u8 val)
>  {
>  	struct pl2303_serial_private *spriv = usb_get_serial_data(serial);
> -	struct device *dev = &serial->interface->dev;
>  	int ret = 0;
>  	u8 *buf;
>  
> -- 
> 2.51.0
> 

Please don't add a bug and then fix it up in a later patch, just redo
the original patch and send it as a v2 as the documentation describes
how to do.

thanks,

greg k-h

Re: [PATCH 2/2] USB: serial: pl2303: add new PID to support PL256X (TYPE_MP)

[Charles Yeh]

> just redo the original patch and send it as a v2 as the documentation describes
> how to do.

Thanks for the guidance.
I have updated the original patch and submitted it as v2 as requested.

Thanks,
Charles.

Re: [PATCH 2/2] USB: serial: pl2303: add new PID to support PL256X (TYPE_MP)

[Charles Yeh]

Hi Sir,

I am just following up on this v2 patch.
Please let me know if you have any comments or if there is anything
else I need to update.

Thank you for your time.

Charles




Charles Yeh <charlesyeh522@gmail.com> 於 2026年3月27日週五 上午10:29寫道：
>
> > just redo the original patch and send it as a v2 as the documentation describes
> > how to do.
>
> Thanks for the guidance.
> I have updated the original patch and submitted it as v2 as requested.
>
> Thanks,
> Charles.

Re: [PATCH 2/2] USB: serial: pl2303: add new PID to support PL256X (TYPE_MP)

[Johan Hovold]

On Fri, May 22, 2026 at 03:49:20PM +0800, Charles Yeh wrote:

> I am just following up on this v2 patch.
> Please let me know if you have any comments or if there is anything
> else I need to update.

I started reviewing it last week but got side-tracked. It's still in my
queue.

Johan