[Bug 219951] Missing null check in ast_vhub_init_dev

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=219951

--- Comment #3 from henry (bsdhenrymartin@gmail.com) ---
This is patch file.

henry martin <bsdhenrymartin@gmail.com> 于2025年3月28日周五 20:41写道：

> We should first check devm_kasprintf() before setting d->vhub and
> d->index, so that if allocation fails, the d struct remains in a clean
> state.
>
> Patch code:
> int ast_vhub_init_dev(struct ast_vhub *vhub, unsigned int idx)
> {
> struct ast_vhub_dev *d = &vhub->ports[idx].dev;
> struct device *parent = &vhub->pdev->dev;
> int rc;
>
> /* First allocate the name (before modifying d->vhub/index) */
> d->name = devm_kasprintf(parent, GFP_KERNEL, "port%d", idx + 1);
> if (!d->name)
> return -ENOMEM;
>
> /* Now safe to set vhub and index */
> d->vhub = vhub;
> d->index = idx;
> d->regs = vhub->regs + 0x100 + 0x10 * idx;
>
> ast_vhub_init_ep0(vhub, &d->ep0, d);
>
> <bugzilla-daemon@kernel.org> 于2025年3月28日周五 19:27写道：
>
>> https://bugzilla.kernel.org/show_bug.cgi?id=219951
>>
>> --- Comment #1 from Greg Kroah-Hartman (greg@kroah.com) ---
>> On Fri, Mar 28, 2025 at 11:15:22AM +0000, bugzilla-daemon@kernel.org
>> wrote:
>> > When devm_kasprintf() fails, it returns a NULL pointer. However, this
>> return
>> > value is not properly checked in the function ast_vhub_init_dev.
>> >
>> > A NULL check should be added after the devm_kasprintf call to prevent
>> > potential
>> > NULL pointer dereference error.
>>
>> Please submit a patch for this if you feel it needs to be fixed up.
>>
>> thanks,
>>
>> greg k-h
>>
>> --
>> You may reply to this email to add a comment.
>>
>> You are receiving this mail because:
>> You reported the bug.
>
>

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.