[Bug 219951] New: Missing null check in ast_vhub_init_dev

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=219951

            Bug ID: 219951
           Summary: Missing null check in ast_vhub_init_dev
           Product: Drivers
           Version: 2.5
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: USB
          Assignee: drivers_usb@kernel-bugs.kernel.org
          Reporter: bsdhenrymartin@gmail.com
        Regression: No

usb: gadget: udc: aspeed-vhub: dev.c
Add NULL check in the ast_vhub_init_dev

When devm_kasprintf() fails, it returns a NULL pointer. However, this return
value is not properly checked in the function ast_vhub_init_dev. 

A NULL check should be added after the devm_kasprintf call to prevent potential
NULL pointer dereference error.

CODE:
        struct ast_vhub_dev *d = &vhub->ports[idx].dev;
        struct device *parent = &vhub->pdev->dev;
        int rc;

        d->vhub = vhub;
        d->index = idx;
        d->name = devm_kasprintf(parent, GFP_KERNEL, "port%d", idx+1);
        d->regs = vhub->regs + 0x100 + 0x10 * idx;

        ast_vhub_init_ep0(vhub, &d->ep0, d);

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.