[Bug 220748] usb: xhci_queue_isoc_tx_prepare ignore start_frame and always assumes URB_ISO_ASAP is set

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=220748

Mathias Nyman (mathias.nyman@linux.intel.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathias.nyman@linux.intel.c
                   |                            |om

--- Comment #28 from Mathias Nyman (mathias.nyman@linux.intel.com) ---
Created attachment 310090
  --> https://bugzilla.kernel.org/attachment.cgi?id=310090&action=edit
testpatch set and check xhci frame id correcly

-Aligns frame id to full frame or esit on first urb,
-Always sets urb->frame_id
-Calculates valid frame window as in spec
-checks if next frame id mid stream is within frame window, print message if
not. Does not alter frame id even if outside frame window.
- allows next URB to be queued mid transfer continueing mid frame (endpoint
interval must be shorter than a full frame as well)

Commit message and some comments needs cleaning up, but code should be
testable.

xhci tracing shows the frame_id of each queued urb, enable with:

echo 1 > /sys/kernel/tracing/events/xhci-hcd/xhci_urb_enqueue/enable
echo 1 > /sys/kernel/tracing/events/xhci-hcd/xhci_queue_trb/enable
<transfer some non SIA isoc transfers >
cat /sys/kernel/tracing/trace

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.