From: Oliver Neukum <oneukum@suse.com>
To: "Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-msm@vger.kernel.org, Nikita Travkin <nikita@trvn.ru>
Subject: Re: [PATCH v3 4/6] power: supply: lenovo_yoga_c630_battery: add Lenovo C630 driver
Date: Mon, 27 May 2024 14:26:36 +0200 [thread overview]
Message-ID: <ceb1f7b3-2787-4166-846f-2427b44b3e62@suse.com> (raw)
In-Reply-To: <20240527-yoga-ec-driver-v3-4-327a9851dad5@linaro.org>
On 27.05.24 12:03, Dmitry Baryshkov wrote:
Hi,
> +struct yoga_c630_psy {
> + struct yoga_c630_ec *ec;
> + struct device *dev;
> + struct device_node *of_node;
> + struct notifier_block nb;
> + struct mutex lock;
> +
> + struct power_supply *adp_psy;
> + struct power_supply *bat_psy;
> +
> + unsigned long last_status_update;
> +
> + bool adapter_online;
> +
> + bool unit_mA;
> +
> + unsigned int scale;
why do you store unit_mA and scale? This looks redundant and like a source
of confusion to me.
Regards
Oliver
next prev parent reply other threads:[~2024-05-27 12:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 10:03 [PATCH v3 0/6] power: supply: Lenovo Yoga C630 EC Dmitry Baryshkov
2024-05-27 10:03 ` [PATCH v3 1/6] dt-bindings: power: supply: Add " Dmitry Baryshkov
2024-05-27 10:21 ` Nikita Travkin
2024-05-27 11:04 ` Dmitry Baryshkov
2024-05-27 10:03 ` [PATCH v3 2/6] platform: arm64: add Lenovo Yoga C630 WOS EC driver Dmitry Baryshkov
2024-05-27 10:03 ` [PATCH v3 3/6] usb: typec: ucsi: add Lenovo Yoga C630 glue driver Dmitry Baryshkov
2024-05-27 10:03 ` [PATCH v3 4/6] power: supply: lenovo_yoga_c630_battery: add Lenovo C630 driver Dmitry Baryshkov
2024-05-27 12:26 ` Oliver Neukum [this message]
2024-05-27 23:15 ` Dmitry Baryshkov
2024-05-28 8:42 ` Oliver Neukum
2024-05-28 9:04 ` Dmitry Baryshkov
2024-05-27 10:03 ` [PATCH v3 5/6] arm64: dts: qcom: sdm845: describe connections of USB/DP port Dmitry Baryshkov
2024-05-27 10:03 ` [PATCH v3 6/6] arm64: dts: qcom: c630: Add Embedded Controller node Dmitry Baryshkov
2024-05-28 15:06 ` Bjorn Andersson
2024-05-28 15:12 ` Dmitry Baryshkov
2024-05-28 17:13 ` Bjorn Andersson
2024-05-28 17:41 ` [PATCH v3 0/6] power: supply: Lenovo Yoga C630 EC Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceb1f7b3-2787-4166-846f-2427b44b3e62@suse.com \
--to=oneukum@suse.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox