Linux USB
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>, valentina.manea.m@gmail.com
Cc: shuah@kernel.org, i@zenithal.me, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] usbip: tools: Release udev references when refreshing devices
Date: Fri, 20 Nov 2026 13:31:14 -0700	[thread overview]
Message-ID: <de58a250-ef73-417a-bad9-ef31e9ca6e27@linuxfoundation.org> (raw)
In-Reply-To: <20261120062114.98435-1-zhujun2@cmss.chinamobile.com>

On 11/19/26 23:21, Zhu Jun wrote:
> Device discovery creates a udev enumeration and a device reference for
> each entry, but releases neither. Successfully exported devices also
> retain a separate udev reference that is lost when their list entries
> are destroyed. Repeated refreshes therefore accumulate references.
> 
> Release temporary device references on both the normal path and the
> exported-device creation failure path, release the enumeration after
> scanning, and drop retained device references when destroying the list.

Do you have a reproducer for this? How did you test this patch?
> 
> Fixes: 021aed845303 ("staging: usbip: userspace: migrate usbip_host_driver to libudev")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
>   tools/usb/usbip/libsrc/usbip_host_common.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tools/usb/usbip/libsrc/usbip_host_common.c b/tools/usb/usbip/libsrc/usbip_host_common.c
> index bec6c42e29c8..a0df0a57b38c 100644
> --- a/tools/usb/usbip/libsrc/usbip_host_common.c
> +++ b/tools/usb/usbip/libsrc/usbip_host_common.c
> @@ -143,13 +143,16 @@ static int refresh_exported_devices(struct usbip_host_driver *hdriver)
>   			edev = usbip_exported_device_new(hdriver, path);
>   			if (!edev) {
>   				dbg("usbip_exported_device_new failed");
> +				udev_device_unref(dev);
>   				continue;
>   			}
>   
>   			list_add(&edev->node, &hdriver->edev_list);
>   			hdriver->ndevs++;
>   		}
> +		udev_device_unref(dev);
>   	}
> +	udev_enumerate_unref(enumerate);
>   
>   	if (hdriver->ndevs == 0)
>   		info("Please load appropriate modules or export devices.");
> @@ -165,6 +168,7 @@ static void usbip_exported_device_destroy(struct list_head *devs)
>   	list_for_each_safe(i, tmp, devs) {
>   		edev = list_entry(i, struct usbip_exported_device, node);
>   		list_del(i);
> +		udev_device_unref(edev->sudev);
>   		free(edev);
>   	}
>   }
> 
> 

thanks,
-- Shuah


      parent reply	other threads:[~2026-11-20 20:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  6:21 [PATCH] usbip: tools: Release udev references when refreshing devices Zhu Jun
2026-11-20  6:27 ` sashiko-bot
2026-11-20 20:31 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de58a250-ef73-417a-bad9-ef31e9ca6e27@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=i@zenithal.me \
    --cc=linux-usb@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=valentina.manea.m@gmail.com \
    --cc=zhujun2@cmss.chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox