Linux USB
 help / color / mirror / Atom feed
* [PATCH] usbip: tools: Release udev references when refreshing devices
@ 2026-11-20  6:21 Zhu Jun
  2026-11-20  6:27 ` sashiko-bot
  2026-11-20 20:31 ` Shuah Khan
  0 siblings, 2 replies; 3+ messages in thread
From: Zhu Jun @ 2026-11-20  6:21 UTC (permalink / raw)
  To: valentina.manea.m; +Cc: shuah, i, gregkh, linux-usb, Zhu Jun

Device discovery creates a udev enumeration and a device reference for
each entry, but releases neither. Successfully exported devices also
retain a separate udev reference that is lost when their list entries
are destroyed. Repeated refreshes therefore accumulate references.

Release temporary device references on both the normal path and the
exported-device creation failure path, release the enumeration after
scanning, and drop retained device references when destroying the list.

Fixes: 021aed845303 ("staging: usbip: userspace: migrate usbip_host_driver to libudev")
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
 tools/usb/usbip/libsrc/usbip_host_common.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/usb/usbip/libsrc/usbip_host_common.c b/tools/usb/usbip/libsrc/usbip_host_common.c
index bec6c42e29c8..a0df0a57b38c 100644
--- a/tools/usb/usbip/libsrc/usbip_host_common.c
+++ b/tools/usb/usbip/libsrc/usbip_host_common.c
@@ -143,13 +143,16 @@ static int refresh_exported_devices(struct usbip_host_driver *hdriver)
 			edev = usbip_exported_device_new(hdriver, path);
 			if (!edev) {
 				dbg("usbip_exported_device_new failed");
+				udev_device_unref(dev);
 				continue;
 			}
 
 			list_add(&edev->node, &hdriver->edev_list);
 			hdriver->ndevs++;
 		}
+		udev_device_unref(dev);
 	}
+	udev_enumerate_unref(enumerate);
 
 	if (hdriver->ndevs == 0)
 		info("Please load appropriate modules or export devices.");
@@ -165,6 +168,7 @@ static void usbip_exported_device_destroy(struct list_head *devs)
 	list_for_each_safe(i, tmp, devs) {
 		edev = list_entry(i, struct usbip_exported_device, node);
 		list_del(i);
+		udev_device_unref(edev->sudev);
 		free(edev);
 	}
 }



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] usbip: tools: Release udev references when refreshing devices
  2026-11-20  6:21 [PATCH] usbip: tools: Release udev references when refreshing devices Zhu Jun
@ 2026-11-20  6:27 ` sashiko-bot
  2026-11-20 20:31 ` Shuah Khan
  1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-11-20  6:27 UTC (permalink / raw)
  To: Zhu Jun; +Cc: linux-usb

> Device discovery creates a udev enumeration and a device reference for
> each entry, but releases neither. Successfully exported devices also
> retain a separate udev reference that is lost when their list entries
> are destroyed. Repeated refreshes therefore accumulate references.
> 
> Release temporary device references on both the normal path and the
> exported-device creation failure path, release the enumeration after
> scanning, and drop retained device references when destroying the list.
> 
> Fixes: 021aed845303 ("staging: usbip: userspace: migrate usbip_host_driver to libudev")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120062114.98435-1-zhujun2@cmss.chinamobile.com?part=1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] usbip: tools: Release udev references when refreshing devices
  2026-11-20  6:21 [PATCH] usbip: tools: Release udev references when refreshing devices Zhu Jun
  2026-11-20  6:27 ` sashiko-bot
@ 2026-11-20 20:31 ` Shuah Khan
  1 sibling, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2026-11-20 20:31 UTC (permalink / raw)
  To: Zhu Jun, valentina.manea.m; +Cc: shuah, i, gregkh, linux-usb, Shuah Khan

On 11/19/26 23:21, Zhu Jun wrote:
> Device discovery creates a udev enumeration and a device reference for
> each entry, but releases neither. Successfully exported devices also
> retain a separate udev reference that is lost when their list entries
> are destroyed. Repeated refreshes therefore accumulate references.
> 
> Release temporary device references on both the normal path and the
> exported-device creation failure path, release the enumeration after
> scanning, and drop retained device references when destroying the list.

Do you have a reproducer for this? How did you test this patch?
> 
> Fixes: 021aed845303 ("staging: usbip: userspace: migrate usbip_host_driver to libudev")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
>   tools/usb/usbip/libsrc/usbip_host_common.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tools/usb/usbip/libsrc/usbip_host_common.c b/tools/usb/usbip/libsrc/usbip_host_common.c
> index bec6c42e29c8..a0df0a57b38c 100644
> --- a/tools/usb/usbip/libsrc/usbip_host_common.c
> +++ b/tools/usb/usbip/libsrc/usbip_host_common.c
> @@ -143,13 +143,16 @@ static int refresh_exported_devices(struct usbip_host_driver *hdriver)
>   			edev = usbip_exported_device_new(hdriver, path);
>   			if (!edev) {
>   				dbg("usbip_exported_device_new failed");
> +				udev_device_unref(dev);
>   				continue;
>   			}
>   
>   			list_add(&edev->node, &hdriver->edev_list);
>   			hdriver->ndevs++;
>   		}
> +		udev_device_unref(dev);
>   	}
> +	udev_enumerate_unref(enumerate);
>   
>   	if (hdriver->ndevs == 0)
>   		info("Please load appropriate modules or export devices.");
> @@ -165,6 +168,7 @@ static void usbip_exported_device_destroy(struct list_head *devs)
>   	list_for_each_safe(i, tmp, devs) {
>   		edev = list_entry(i, struct usbip_exported_device, node);
>   		list_del(i);
> +		udev_device_unref(edev->sudev);
>   		free(edev);
>   	}
>   }
> 
> 

thanks,
-- Shuah


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-20 20:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20  6:21 [PATCH] usbip: tools: Release udev references when refreshing devices Zhu Jun
2026-11-20  6:27 ` sashiko-bot
2026-11-20 20:31 ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox