* [PATCH 2/3] arm64: dts: imx8mp-evk: add typec node
2024-07-29 8:10 [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043 Xu Yang
@ 2024-07-29 8:10 ` Xu Yang
2024-07-29 8:17 ` Krzysztof Kozlowski
2024-07-29 8:10 ` [PATCH 3/3] arm64: dts: imx8mq-evk: " Xu Yang
` (3 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Xu Yang @ 2024-07-29 8:10 UTC (permalink / raw)
To: gregkh, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam
Cc: andersson, linux-usb, devicetree, imx, linux-arm-kernel, jun.li
The first port of USB with type-C connector, which has dual data
role and dual power role.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 104 +++++++++++++++++++
1 file changed, 104 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index 938347704136..e38b59af5f33 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -6,6 +6,7 @@
/dts-v1/;
#include <dt-bindings/phy/phy-imx8-pcie.h>
+#include <dt-bindings/usb/pd.h>
#include "imx8mp.dtsi"
/ {
@@ -26,6 +27,20 @@ backlight_lvds: backlight-lvds {
status = "disabled";
};
+ cbdtu02043: typec-mux {
+ compatible = "nxp,cbdtu02043", "gpio-sbu-mux";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_typec_mux>;
+ select-gpios =<&gpio4 20 GPIO_ACTIVE_HIGH>;
+ orientation-switch;
+
+ port {
+ usb3_data_ss: endpoint {
+ remote-endpoint = <&typec_con_ss>;
+ };
+ };
+ };
+
hdmi-connector {
compatible = "hdmi-connector";
label = "hdmi";
@@ -535,6 +550,49 @@ adv7535_out: endpoint {
};
};
+
+ ptn5110: tcpc@50 {
+ compatible = "nxp,ptn5110", "tcpci";
+ reg = <0x50>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_typec>;
+ interrupt-parent = <&gpio4>;
+ interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
+
+ usb_con: connector {
+ compatible = "usb-c-connector";
+ label = "USB-C";
+ power-role = "dual";
+ data-role = "dual";
+ try-power-role = "sink";
+ source-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
+ sink-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)
+ PDO_VAR(5000, 20000, 3000)>;
+ op-sink-microwatt = <15000000>;
+ self-powered;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ typec_dr_sw: endpoint {
+ remote-endpoint = <&usb3_drd_sw>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ typec_con_ss: endpoint {
+ remote-endpoint = <&usb3_data_ss>;
+ };
+ };
+ };
+ };
+ };
};
&i2c3 {
@@ -704,7 +762,41 @@ &uart2 {
status = "okay";
};
+&usb3_phy0 {
+ fsl,phy-tx-vref-tune = <0xe>;
+ fsl,phy-tx-preemp-amp-tune = <3>;
+ fsl,phy-tx-vboost-level = <5>;
+ fsl,phy-comp-dis-tune = <7>;
+ fsl,pcs-tx-deemph-3p5db = <0x21>;
+ fsl,phy-pcs-tx-swing-full = <0x7f>;
+ status = "okay";
+};
+
+&usb3_0 {
+ status = "okay";
+};
+
+&usb_dwc3_0 {
+ dr_mode = "otg";
+ hnp-disable;
+ srp-disable;
+ adp-disable;
+ usb-role-switch;
+ role-switch-default-mode = "none";
+ snps,dis-u1-entry-quirk;
+ snps,dis-u2-entry-quirk;
+ status = "okay";
+
+ port {
+ usb3_drd_sw: endpoint {
+ remote-endpoint = <&typec_dr_sw>;
+ };
+ };
+};
+
&usb3_phy1 {
+ fsl,phy-tx-preemp-amp-tune = <3>;
+ fsl,phy-tx-vref-tune = <0xb>;
status = "okay";
};
@@ -986,6 +1078,18 @@ MX8MP_IOMUXC_UART2_TXD__UART2_DCE_TX 0x140
>;
};
+ pinctrl_typec: typecgrp {
+ fsl,pins = <
+ MX8MP_IOMUXC_SAI1_TXD7__GPIO4_IO19 0x1c4
+ >;
+ };
+
+ pinctrl_typec_mux: typecmuxgrp {
+ fsl,pins = <
+ MX8MP_IOMUXC_SAI1_MCLK__GPIO4_IO20 0x16
+ >;
+ };
+
pinctrl_usb1_vbus: usb1grp {
fsl,pins = <
MX8MP_IOMUXC_GPIO1_IO14__USB2_OTG_PWR 0x10
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 2/3] arm64: dts: imx8mp-evk: add typec node
2024-07-29 8:10 ` [PATCH 2/3] arm64: dts: imx8mp-evk: add typec node Xu Yang
@ 2024-07-29 8:17 ` Krzysztof Kozlowski
2024-07-29 9:03 ` Xu Yang
0 siblings, 1 reply; 14+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-29 8:17 UTC (permalink / raw)
To: Xu Yang, gregkh, robh, krzk+dt, conor+dt, shawnguo, s.hauer,
kernel, festevam
Cc: andersson, linux-usb, devicetree, imx, linux-arm-kernel, jun.li
On 29/07/2024 10:10, Xu Yang wrote:
> The first port of USB with type-C connector, which has dual data
> role and dual power role.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 104 +++++++++++++++++++
> 1 file changed, 104 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> index 938347704136..e38b59af5f33 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> @@ -6,6 +6,7 @@
> /dts-v1/;
>
> #include <dt-bindings/phy/phy-imx8-pcie.h>
> +#include <dt-bindings/usb/pd.h>
> #include "imx8mp.dtsi"
>
> / {
> @@ -26,6 +27,20 @@ backlight_lvds: backlight-lvds {
> status = "disabled";
> };
>
> + cbdtu02043: typec-mux {
> + compatible = "nxp,cbdtu02043", "gpio-sbu-mux";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_typec_mux>;
> + select-gpios =<&gpio4 20 GPIO_ACTIVE_HIGH>;
Missing space after =
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 2/3] arm64: dts: imx8mp-evk: add typec node
2024-07-29 8:17 ` Krzysztof Kozlowski
@ 2024-07-29 9:03 ` Xu Yang
0 siblings, 0 replies; 14+ messages in thread
From: Xu Yang @ 2024-07-29 9:03 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: gregkh, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, andersson, linux-usb, devicetree, imx, linux-arm-kernel,
jun.li
On Mon, Jul 29, 2024 at 10:17:37AM +0200, Krzysztof Kozlowski wrote:
> On 29/07/2024 10:10, Xu Yang wrote:
> > The first port of USB with type-C connector, which has dual data
> > role and dual power role.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 104 +++++++++++++++++++
> > 1 file changed, 104 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > index 938347704136..e38b59af5f33 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> > @@ -6,6 +6,7 @@
> > /dts-v1/;
> >
> > #include <dt-bindings/phy/phy-imx8-pcie.h>
> > +#include <dt-bindings/usb/pd.h>
> > #include "imx8mp.dtsi"
> >
> > / {
> > @@ -26,6 +27,20 @@ backlight_lvds: backlight-lvds {
> > status = "disabled";
> > };
> >
> > + cbdtu02043: typec-mux {
> > + compatible = "nxp,cbdtu02043", "gpio-sbu-mux";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_typec_mux>;
> > + select-gpios =<&gpio4 20 GPIO_ACTIVE_HIGH>;
>
> Missing space after =
Okay, will fix it.
Thanks,
Xu Yang
>
>
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/3] arm64: dts: imx8mq-evk: add typec node
2024-07-29 8:10 [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043 Xu Yang
2024-07-29 8:10 ` [PATCH 2/3] arm64: dts: imx8mp-evk: add typec node Xu Yang
@ 2024-07-29 8:10 ` Xu Yang
2024-07-29 19:56 ` Dmitry Baryshkov
2024-07-29 8:17 ` [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043 Krzysztof Kozlowski
` (2 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Xu Yang @ 2024-07-29 8:10 UTC (permalink / raw)
To: gregkh, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam
Cc: andersson, linux-usb, devicetree, imx, linux-arm-kernel, jun.li
The first port of USB with type-C connector, which has dual data
role and dual power role.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 93 ++++++++++++++++++++
1 file changed, 93 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
index 7507548cdb16..008e8c37c76b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
@@ -6,6 +6,7 @@
/dts-v1/;
+#include <dt-bindings/usb/pd.h>
#include "imx8mq.dtsi"
/ {
@@ -27,6 +28,20 @@ pcie0_refclk: pcie0-refclk {
clock-frequency = <100000000>;
};
+ ptn36043: typec-mux {
+ compatible = "nxp,ptn36043", "gpio-sbu-mux";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_typec_mux>;
+ select-gpios =<&gpio3 15 GPIO_ACTIVE_LOW>;
+ orientation-switch;
+
+ port {
+ usb3_data_ss: endpoint {
+ remote-endpoint = <&typec_con_ss>;
+ };
+ };
+ };
+
reg_pcie1: regulator-pcie {
compatible = "regulator-fixed";
pinctrl-names = "default";
@@ -315,6 +330,50 @@ vgen6_reg: vgen6 {
};
};
};
+
+ ptn5110: tcpc@50 {
+ compatible = "nxp,ptn5110", "tcpci";
+ reg = <0x50>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_typec>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
+
+ usb_con: connector {
+ compatible = "usb-c-connector";
+ label = "USB-C";
+ power-role = "dual";
+ data-role = "dual";
+ try-power-role = "sink";
+ source-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
+ sink-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)
+ PDO_VAR(5000, 20000, 3000)>;
+ op-sink-microwatt = <15000000>;
+ self-powered;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ typec_dr_sw: endpoint {
+ remote-endpoint = <&usb3_drd_sw>;
+ };
+ };
+
+
+ port@1 {
+ reg = <1>;
+
+ typec_con_ss: endpoint {
+ remote-endpoint = <&usb3_data_ss>;
+ };
+ };
+ };
+ };
+ };
};
&lcdif {
@@ -445,6 +504,28 @@ &uart1 {
status = "okay";
};
+&usb3_phy0 {
+ status = "okay";
+};
+
+&usb_dwc3_0 {
+ dr_mode = "otg";
+ hnp-disable;
+ srp-disable;
+ adp-disable;
+ usb-role-switch;
+ role-switch-default-mode = "none";
+ snps,dis-u1-entry-quirk;
+ snps,dis-u2-entry-quirk;
+ status = "okay";
+
+ port {
+ usb3_drd_sw: endpoint {
+ remote-endpoint = <&typec_dr_sw>;
+ };
+ };
+};
+
&usb3_phy1 {
status = "okay";
};
@@ -597,6 +678,18 @@ MX8MQ_IOMUXC_SPDIF_RX_SPDIF1_IN 0xd6
>;
};
+ pinctrl_typec: typecgrp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_NAND_CE2_B_GPIO3_IO3 0x17059
+ >;
+ };
+
+ pinctrl_typec_mux: typecmuxgrp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_NAND_RE_B_GPIO3_IO15 0x16
+ >;
+ };
+
pinctrl_uart1: uart1grp {
fsl,pins = <
MX8MQ_IOMUXC_UART1_RXD_UART1_DCE_RX 0x49
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 3/3] arm64: dts: imx8mq-evk: add typec node
2024-07-29 8:10 ` [PATCH 3/3] arm64: dts: imx8mq-evk: " Xu Yang
@ 2024-07-29 19:56 ` Dmitry Baryshkov
2024-07-30 3:08 ` Xu Yang
0 siblings, 1 reply; 14+ messages in thread
From: Dmitry Baryshkov @ 2024-07-29 19:56 UTC (permalink / raw)
To: Xu Yang
Cc: gregkh, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, andersson, linux-usb, devicetree, imx, linux-arm-kernel,
jun.li
On Mon, Jul 29, 2024 at 04:10:39PM GMT, Xu Yang wrote:
> The first port of USB with type-C connector, which has dual data
> role and dual power role.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 93 ++++++++++++++++++++
> 1 file changed, 93 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> index 7507548cdb16..008e8c37c76b 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> @@ -6,6 +6,7 @@
>
> /dts-v1/;
>
> +#include <dt-bindings/usb/pd.h>
> #include "imx8mq.dtsi"
>
> / {
> @@ -27,6 +28,20 @@ pcie0_refclk: pcie0-refclk {
> clock-frequency = <100000000>;
> };
>
> + ptn36043: typec-mux {
> + compatible = "nxp,ptn36043", "gpio-sbu-mux";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_typec_mux>;
> + select-gpios =<&gpio3 15 GPIO_ACTIVE_LOW>;
> + orientation-switch;
> +
> + port {
> + usb3_data_ss: endpoint {
> + remote-endpoint = <&typec_con_ss>;
> + };
> + };
If this the "SBU" mux, then why is it connected to the SS lines?
Where are the SS lines further going?
> + };
> +
> reg_pcie1: regulator-pcie {
> compatible = "regulator-fixed";
> pinctrl-names = "default";
> @@ -315,6 +330,50 @@ vgen6_reg: vgen6 {
> };
> };
> };
> +
> + ptn5110: tcpc@50 {
> + compatible = "nxp,ptn5110", "tcpci";
> + reg = <0x50>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_typec>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> +
> + usb_con: connector {
> + compatible = "usb-c-connector";
> + label = "USB-C";
> + power-role = "dual";
> + data-role = "dual";
> + try-power-role = "sink";
> + source-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
> + sink-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)
> + PDO_VAR(5000, 20000, 3000)>;
> + op-sink-microwatt = <15000000>;
> + self-powered;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + typec_dr_sw: endpoint {
the DR (dual role) isn't a physical signal. These ports descrbie HS
(high speed) lanes, please consider naming them correspondingly.
> + remote-endpoint = <&usb3_drd_sw>;
> + };
> + };
> +
> +
> + port@1 {
> + reg = <1>;
> +
> + typec_con_ss: endpoint {
> + remote-endpoint = <&usb3_data_ss>;
> + };
> + };
No SBU port?
> + };
> + };
> + };
> };
>
> &lcdif {
> @@ -445,6 +504,28 @@ &uart1 {
> status = "okay";
> };
>
> +&usb3_phy0 {
> + status = "okay";
> +};
> +
> +&usb_dwc3_0 {
> + dr_mode = "otg";
> + hnp-disable;
> + srp-disable;
> + adp-disable;
> + usb-role-switch;
> + role-switch-default-mode = "none";
> + snps,dis-u1-entry-quirk;
> + snps,dis-u2-entry-quirk;
> + status = "okay";
> +
> + port {
> + usb3_drd_sw: endpoint {
> + remote-endpoint = <&typec_dr_sw>;
> + };
> + };
> +};
> +
> &usb3_phy1 {
> status = "okay";
> };
> @@ -597,6 +678,18 @@ MX8MQ_IOMUXC_SPDIF_RX_SPDIF1_IN 0xd6
> >;
> };
>
> + pinctrl_typec: typecgrp {
> + fsl,pins = <
> + MX8MQ_IOMUXC_NAND_CE2_B_GPIO3_IO3 0x17059
> + >;
> + };
> +
> + pinctrl_typec_mux: typecmuxgrp {
> + fsl,pins = <
> + MX8MQ_IOMUXC_NAND_RE_B_GPIO3_IO15 0x16
> + >;
> + };
> +
> pinctrl_uart1: uart1grp {
> fsl,pins = <
> MX8MQ_IOMUXC_UART1_RXD_UART1_DCE_RX 0x49
> --
> 2.34.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 3/3] arm64: dts: imx8mq-evk: add typec node
2024-07-29 19:56 ` Dmitry Baryshkov
@ 2024-07-30 3:08 ` Xu Yang
0 siblings, 0 replies; 14+ messages in thread
From: Xu Yang @ 2024-07-30 3:08 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: gregkh, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, andersson, linux-usb, devicetree, imx, linux-arm-kernel,
jun.li
On Mon, Jul 29, 2024 at 10:56:31PM +0300, Dmitry Baryshkov wrote:
> On Mon, Jul 29, 2024 at 04:10:39PM GMT, Xu Yang wrote:
> > The first port of USB with type-C connector, which has dual data
> > role and dual power role.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 93 ++++++++++++++++++++
> > 1 file changed, 93 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > index 7507548cdb16..008e8c37c76b 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > @@ -6,6 +6,7 @@
> >
> > /dts-v1/;
> >
> > +#include <dt-bindings/usb/pd.h>
> > #include "imx8mq.dtsi"
> >
> > / {
> > @@ -27,6 +28,20 @@ pcie0_refclk: pcie0-refclk {
> > clock-frequency = <100000000>;
> > };
> >
> > + ptn36043: typec-mux {
> > + compatible = "nxp,ptn36043", "gpio-sbu-mux";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_typec_mux>;
> > + select-gpios =<&gpio3 15 GPIO_ACTIVE_LOW>;
> > + orientation-switch;
> > +
> > + port {
> > + usb3_data_ss: endpoint {
> > + remote-endpoint = <&typec_con_ss>;
> > + };
> > + };
>
> If this the "SBU" mux, then why is it connected to the SS lines?
> Where are the SS lines further going?
The gpio-mux is able to switch SS line. ptn36043 is SS orientation
swich here.
>
> > + };
> > +
> > reg_pcie1: regulator-pcie {
> > compatible = "regulator-fixed";
> > pinctrl-names = "default";
> > @@ -315,6 +330,50 @@ vgen6_reg: vgen6 {
> > };
> > };
> > };
> > +
> > + ptn5110: tcpc@50 {
> > + compatible = "nxp,ptn5110", "tcpci";
> > + reg = <0x50>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_typec>;
> > + interrupt-parent = <&gpio3>;
> > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> > +
> > + usb_con: connector {
> > + compatible = "usb-c-connector";
> > + label = "USB-C";
> > + power-role = "dual";
> > + data-role = "dual";
> > + try-power-role = "sink";
> > + source-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
> > + sink-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)
> > + PDO_VAR(5000, 20000, 3000)>;
> > + op-sink-microwatt = <15000000>;
> > + self-powered;
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 {
> > + reg = <0>;
> > +
> > + typec_dr_sw: endpoint {
>
> the DR (dual role) isn't a physical signal. These ports descrbie HS
> (high speed) lanes, please consider naming them correspondingly.
Okay.
>
> > + remote-endpoint = <&usb3_drd_sw>;
> > + };
> > + };
> > +
> > +
> > + port@1 {
> > + reg = <1>;
> > +
> > + typec_con_ss: endpoint {
> > + remote-endpoint = <&usb3_data_ss>;
> > + };
> > + };
>
> No SBU port?
Yes, this board doesn't use SBU signal.
Thanks,
Xu Yang
>
> > + };
> > + };
> > + };
> > };
> >
> > &lcdif {
> > @@ -445,6 +504,28 @@ &uart1 {
> > status = "okay";
> > };
> >
> > +&usb3_phy0 {
> > + status = "okay";
> > +};
> > +
> > +&usb_dwc3_0 {
> > + dr_mode = "otg";
> > + hnp-disable;
> > + srp-disable;
> > + adp-disable;
> > + usb-role-switch;
> > + role-switch-default-mode = "none";
> > + snps,dis-u1-entry-quirk;
> > + snps,dis-u2-entry-quirk;
> > + status = "okay";
> > +
> > + port {
> > + usb3_drd_sw: endpoint {
> > + remote-endpoint = <&typec_dr_sw>;
> > + };
> > + };
> > +};
> > +
> > &usb3_phy1 {
> > status = "okay";
> > };
> > @@ -597,6 +678,18 @@ MX8MQ_IOMUXC_SPDIF_RX_SPDIF1_IN 0xd6
> > >;
> > };
> >
> > + pinctrl_typec: typecgrp {
> > + fsl,pins = <
> > + MX8MQ_IOMUXC_NAND_CE2_B_GPIO3_IO3 0x17059
> > + >;
> > + };
> > +
> > + pinctrl_typec_mux: typecmuxgrp {
> > + fsl,pins = <
> > + MX8MQ_IOMUXC_NAND_RE_B_GPIO3_IO15 0x16
> > + >;
> > + };
> > +
> > pinctrl_uart1: uart1grp {
> > fsl,pins = <
> > MX8MQ_IOMUXC_UART1_RXD_UART1_DCE_RX 0x49
> > --
> > 2.34.1
> >
>
> --
> With best wishes
> Dmitry
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043
2024-07-29 8:10 [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043 Xu Yang
2024-07-29 8:10 ` [PATCH 2/3] arm64: dts: imx8mp-evk: add typec node Xu Yang
2024-07-29 8:10 ` [PATCH 3/3] arm64: dts: imx8mq-evk: " Xu Yang
@ 2024-07-29 8:17 ` Krzysztof Kozlowski
2024-07-29 18:52 ` Rob Herring (Arm)
2024-07-29 19:57 ` Dmitry Baryshkov
4 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-29 8:17 UTC (permalink / raw)
To: Xu Yang, gregkh, robh, krzk+dt, conor+dt, shawnguo, s.hauer,
kernel, festevam
Cc: andersson, linux-usb, devicetree, imx, linux-arm-kernel, jun.li
On 29/07/2024 10:10, Xu Yang wrote:
> Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware
> used for connecting, disconnecting and switching orientation of
> the SBU lines in USB Type-C applications.
>
> PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043
2024-07-29 8:10 [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043 Xu Yang
` (2 preceding siblings ...)
2024-07-29 8:17 ` [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043 Krzysztof Kozlowski
@ 2024-07-29 18:52 ` Rob Herring (Arm)
2024-07-30 2:48 ` Xu Yang
2024-07-29 19:57 ` Dmitry Baryshkov
4 siblings, 1 reply; 14+ messages in thread
From: Rob Herring (Arm) @ 2024-07-29 18:52 UTC (permalink / raw)
To: Xu Yang
Cc: devicetree, andersson, s.hauer, krzk+dt, conor+dt, gregkh,
festevam, linux-arm-kernel, shawnguo, linux-usb, imx, kernel,
jun.li
On Mon, 29 Jul 2024 16:10:37 +0800, Xu Yang wrote:
> Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware
> used for connecting, disconnecting and switching orientation of
> the SBU lines in USB Type-C applications.
>
> PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
> Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y freescale/imx8mp-evk.dtb freescale/imx8mq-evk.dtb' for 20240729081039.3904797-1-xu.yang_2@nxp.com:
arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral']
from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#
arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected)
from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#
arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral']
from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mq-dwc3.yaml#
arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected)
from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mq-dwc3.yaml#
arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks', 'dr_mode', 'hnp-disable', 'interrupts', 'phy-names', 'phys', 'port', 'power-domains', 'reg', 'role-switch-default-mode', 'snps,dis-u1-entry-quirk', 'snps,dis-u2-entry-quirk', 'snps,parkmode-disable-ss-quirk', 'srp-disable', 'usb-role-switch' were unexpected)
from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mq-dwc3.yaml#
arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb-phy@381f0040: 'fsl,pcs-tx-deemph-3p5db', 'fsl,phy-comp-dis-tune', 'fsl,phy-pcs-tx-swing-full', 'fsl,phy-tx-preemp-amp-tune', 'fsl,phy-tx-vboost-level', 'fsl,phy-tx-vref-tune' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-usb-phy.yaml#
arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@32f10100: usb@38100000:role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral']
from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mp-dwc3.yaml#
arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@32f10100: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected)
from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mp-dwc3.yaml#
arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@38100000: role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral']
from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#
arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected)
from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#
arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb-phy@382f0040: 'fsl,phy-tx-preemp-amp-tune', 'fsl,phy-tx-vref-tune' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-usb-phy.yaml#
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043
2024-07-29 18:52 ` Rob Herring (Arm)
@ 2024-07-30 2:48 ` Xu Yang
0 siblings, 0 replies; 14+ messages in thread
From: Xu Yang @ 2024-07-30 2:48 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: devicetree, andersson, s.hauer, krzk+dt, conor+dt, gregkh,
festevam, linux-arm-kernel, shawnguo, linux-usb, imx, kernel,
jun.li
On Mon, Jul 29, 2024 at 12:52:56PM -0600, Rob Herring (Arm) wrote:
>
> On Mon, 29 Jul 2024 16:10:37 +0800, Xu Yang wrote:
> > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware
> > used for connecting, disconnecting and switching orientation of
> > the SBU lines in USB Type-C applications.
> >
> > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > ---
> > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> New warnings running 'make CHECK_DTBS=y freescale/imx8mp-evk.dtb freescale/imx8mq-evk.dtb' for 20240729081039.3904797-1-xu.yang_2@nxp.com:
>
> arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral']
> from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#
> arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected)
> from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#
> arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral']
> from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mq-dwc3.yaml#
> arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected)
> from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mq-dwc3.yaml#
> arch/arm64/boot/dts/freescale/imx8mq-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks', 'dr_mode', 'hnp-disable', 'interrupts', 'phy-names', 'phys', 'port', 'power-domains', 'reg', 'role-switch-default-mode', 'snps,dis-u1-entry-quirk', 'snps,dis-u2-entry-quirk', 'snps,parkmode-disable-ss-quirk', 'srp-disable', 'usb-role-switch' were unexpected)
> from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mq-dwc3.yaml#
> arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb-phy@381f0040: 'fsl,pcs-tx-deemph-3p5db', 'fsl,phy-comp-dis-tune', 'fsl,phy-pcs-tx-swing-full', 'fsl,phy-tx-preemp-amp-tune', 'fsl,phy-tx-vboost-level', 'fsl,phy-tx-vref-tune' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-usb-phy.yaml#
> arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@32f10100: usb@38100000:role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral']
> from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mp-dwc3.yaml#
> arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@32f10100: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected)
> from schema $id: http://devicetree.org/schemas/usb/fsl,imx8mp-dwc3.yaml#
> arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@38100000: role-switch-default-mode:0: 'none' is not one of ['host', 'peripheral']
> from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#
> arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb@38100000: Unevaluated properties are not allowed ('adp-disable', 'dr_mode', 'hnp-disable', 'role-switch-default-mode', 'srp-disable', 'usb-role-switch' were unexpected)
> from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml#
> arch/arm64/boot/dts/freescale/imx8mp-evk.dtb: usb-phy@382f0040: 'fsl,phy-tx-preemp-amp-tune', 'fsl,phy-tx-vref-tune' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-usb-phy.yaml#
Sorry for this. I've checked gpio-sbu-mux and ptn5110 binding but missed usb part.
Will fix it.
Thanks,
Xu Yang
>
>
>
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043
2024-07-29 8:10 [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043 Xu Yang
` (3 preceding siblings ...)
2024-07-29 18:52 ` Rob Herring (Arm)
@ 2024-07-29 19:57 ` Dmitry Baryshkov
2024-07-30 2:58 ` Xu Yang
4 siblings, 1 reply; 14+ messages in thread
From: Dmitry Baryshkov @ 2024-07-29 19:57 UTC (permalink / raw)
To: Xu Yang
Cc: gregkh, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, andersson, linux-usb, devicetree, imx, linux-arm-kernel,
jun.li
On Mon, Jul 29, 2024 at 04:10:37PM GMT, Xu Yang wrote:
> Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware
> used for connecting, disconnecting and switching orientation of
> the SBU lines in USB Type-C applications.
NAK, this is not correct. PTN36043 switchies SuperSpeed lines and not
SBU.
>
> PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
> Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> index 8a5f837eff94..152849f744c1 100644
> --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> @@ -20,6 +20,7 @@ properties:
> items:
> - enum:
> - nxp,cbdtu02043
> + - nxp,ptn36043
> - onnn,fsusb43l10x
> - pericom,pi3usb102
> - ti,tmuxhs4212
> --
> 2.34.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043
2024-07-29 19:57 ` Dmitry Baryshkov
@ 2024-07-30 2:58 ` Xu Yang
2024-07-30 11:12 ` Dmitry Baryshkov
0 siblings, 1 reply; 14+ messages in thread
From: Xu Yang @ 2024-07-30 2:58 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: gregkh, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, andersson, linux-usb, devicetree, imx, linux-arm-kernel,
jun.li
On Mon, Jul 29, 2024 at 10:57:33PM +0300, Dmitry Baryshkov wrote:
> On Mon, Jul 29, 2024 at 04:10:37PM GMT, Xu Yang wrote:
> > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware
> > used for connecting, disconnecting and switching orientation of
> > the SBU lines in USB Type-C applications.
>
> NAK, this is not correct. PTN36043 switchies SuperSpeed lines and not
> SBU.
Yes. Since this gpio mux is able to switch both sbu line and ss line,
I will change SBU to SuperSpeed in next version in commit message to avoid
confusion.
Thanks,
Xu Yang
>
> >
> > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > ---
> > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> > index 8a5f837eff94..152849f744c1 100644
> > --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> > +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> > @@ -20,6 +20,7 @@ properties:
> > items:
> > - enum:
> > - nxp,cbdtu02043
> > + - nxp,ptn36043
> > - onnn,fsusb43l10x
> > - pericom,pi3usb102
> > - ti,tmuxhs4212
> > --
> > 2.34.1
> >
>
> --
> With best wishes
> Dmitry
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043
2024-07-30 2:58 ` Xu Yang
@ 2024-07-30 11:12 ` Dmitry Baryshkov
2024-07-30 11:23 ` Xu Yang
0 siblings, 1 reply; 14+ messages in thread
From: Dmitry Baryshkov @ 2024-07-30 11:12 UTC (permalink / raw)
To: Xu Yang
Cc: gregkh, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, andersson, linux-usb, devicetree, imx, linux-arm-kernel,
jun.li
On Tue, Jul 30, 2024 at 10:58:44AM GMT, Xu Yang wrote:
> On Mon, Jul 29, 2024 at 10:57:33PM +0300, Dmitry Baryshkov wrote:
> > On Mon, Jul 29, 2024 at 04:10:37PM GMT, Xu Yang wrote:
> > > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware
> > > used for connecting, disconnecting and switching orientation of
> > > the SBU lines in USB Type-C applications.
> >
> > NAK, this is not correct. PTN36043 switchies SuperSpeed lines and not
> > SBU.
>
> Yes. Since this gpio mux is able to switch both sbu line and ss line,
> I will change SBU to SuperSpeed in next version in commit message to avoid
> confusion.
Ack. This needs new compatible and probably more schema (and driver)
changes. I think you can't just terminate SS lanes in the mux, they
should go to the actual SoC part (like the SS controller or PHY).
>
> Thanks,
> Xu Yang
>
> >
> > >
> > > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf
> > >
> > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > > ---
> > > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> > > index 8a5f837eff94..152849f744c1 100644
> > > --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> > > @@ -20,6 +20,7 @@ properties:
> > > items:
> > > - enum:
> > > - nxp,cbdtu02043
> > > + - nxp,ptn36043
> > > - onnn,fsusb43l10x
> > > - pericom,pi3usb102
> > > - ti,tmuxhs4212
> > > --
> > > 2.34.1
> > >
> >
> > --
> > With best wishes
> > Dmitry
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for PTN36043
2024-07-30 11:12 ` Dmitry Baryshkov
@ 2024-07-30 11:23 ` Xu Yang
0 siblings, 0 replies; 14+ messages in thread
From: Xu Yang @ 2024-07-30 11:23 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: gregkh, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, andersson, linux-usb, devicetree, imx, linux-arm-kernel,
jun.li
On Tue, Jul 30, 2024 at 02:12:32PM +0300, Dmitry Baryshkov wrote:
> On Tue, Jul 30, 2024 at 10:58:44AM GMT, Xu Yang wrote:
> > On Mon, Jul 29, 2024 at 10:57:33PM +0300, Dmitry Baryshkov wrote:
> > > On Mon, Jul 29, 2024 at 04:10:37PM GMT, Xu Yang wrote:
> > > > Add a compatible entry for the NXP PTN36043 GPIO-based mux hardware
> > > > used for connecting, disconnecting and switching orientation of
> > > > the SBU lines in USB Type-C applications.
> > >
> > > NAK, this is not correct. PTN36043 switchies SuperSpeed lines and not
> > > SBU.
> >
> > Yes. Since this gpio mux is able to switch both sbu line and ss line,
> > I will change SBU to SuperSpeed in next version in commit message to avoid
> > confusion.
>
> Ack. This needs new compatible and probably more schema (and driver)
> changes. I think you can't just terminate SS lanes in the mux, they
> should go to the actual SoC part (like the SS controller or PHY).
Thanks for your remainder. The SS signals already go to i.MX8MP soc (USB PHY)
on my board.
Thanks,
Xu Yang
>
> >
> > Thanks,
> > Xu Yang
> >
> > >
> > > >
> > > > PTN36043 datasheet: https://www.nxp.com/docs/en/data-sheet/PTN36043A.pdf
> > > >
> > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > > > ---
> > > > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> > > > index 8a5f837eff94..152849f744c1 100644
> > > > --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> > > > +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> > > > @@ -20,6 +20,7 @@ properties:
> > > > items:
> > > > - enum:
> > > > - nxp,cbdtu02043
> > > > + - nxp,ptn36043
> > > > - onnn,fsusb43l10x
> > > > - pericom,pi3usb102
> > > > - ti,tmuxhs4212
> > > > --
> > > > 2.34.1
> > > >
> > >
> > > --
> > > With best wishes
> > > Dmitry
>
> --
> With best wishes
> Dmitry
^ permalink raw reply [flat|nested] 14+ messages in thread