[PATCH 1/1] USB: cdc-acm: add control line state quirk for Telit QCX216 modems

[PATCH 1/1] USB: cdc-acm: add control line state quirk for Telit QCX216 modems

[Daniele Palmas]

Add control line state quirk for the diagnostic port of the compositions
exposed by Telit QCX216-based modems, since the control line state
requests prevent the modem from sending the diagnostic data.

Signed-off-by: Daniele Palmas <dnlplm@gmail.com>
---
 drivers/usb/class/cdc-acm.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 0d3f815b2f1e..c07b21872d19 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -2039,6 +2039,18 @@ static const struct usb_device_id acm_ids[] = {
 	{ USB_DEVICE(0x1bc7, 0x0023), /* Telit 3G ACM + ECM composition */
 	.driver_info = SEND_ZERO_PACKET,
 	},
+	{ USB_DEVICE_INTERFACE_NUMBER(0x1bc7, 0x7020, 4), /* Telit LE910Q1 (RNDIS) diag port */
+	.driver_info = QUIRK_CONTROL_LINE_STATE,
+	},
+	{ USB_DEVICE_INTERFACE_NUMBER(0x1bc7, 0x7021, 4), /* Telit LE910Q1 (ECM) diag port */
+	.driver_info = QUIRK_CONTROL_LINE_STATE,
+	},
+	{ USB_DEVICE_INTERFACE_NUMBER(0x1bc7, 0x7028, 4), /* Telit LE310Q1 (RNDIS) diag port */
+	.driver_info = QUIRK_CONTROL_LINE_STATE,
+	},
+	{ USB_DEVICE_INTERFACE_NUMBER(0x1bc7, 0x7029, 4), /* Telit LE310Q1 (ECM) diag port */
+	.driver_info = QUIRK_CONTROL_LINE_STATE,
+	},
 
 	/* Exclude Goodix Fingerprint Reader */
 	{ USB_DEVICE(0x27c6, 0x5395),

base-commit: a90ee4305c4a5df72c11b31dacfdc76e00fcf78a
-- 
2.37.1

Re: [PATCH 1/1] USB: cdc-acm: add control line state quirk for Telit QCX216 modems

[sashiko-bot]

> Add control line state quirk for the diagnostic port of the compositions
> exposed by Telit QCX216-based modems, since the control line state
> requests prevent the modem from sending the diagnostic data.
> 
> Signed-off-by: Daniele Palmas <dnlplm@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012092730.332531-1-dnlplm@gmail.com?part=1