[PATCH] usb: dwc3: trace: Restore request name assignment

[PATCH] usb: dwc3: trace: Restore request name assignment

[Thinh Nguyen]

The commit 0a06917432a7 ("usb: dwc3: Log dwc3 address in traces")
removed the __assign_str(name) call from dwc3_log_request. The name
field still exists in the trace event, but nothing fills it in, so the
endpoint name printed for these events is leftover garbage from the ring
buffer.

Put the __assign_str() call back so the endpoint name is logged again.

Fixes: 0a06917432a7 ("usb: dwc3: Log dwc3 address in traces")
Cc: stable@vger.kernel.org
Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
---
 drivers/usb/dwc3/trace.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h
index 5253da23d8b0..0caaa0b396d1 100644
--- a/drivers/usb/dwc3/trace.h
+++ b/drivers/usb/dwc3/trace.h
@@ -141,6 +141,7 @@ DECLARE_EVENT_CLASS(dwc3_log_request,
 	),
 	TP_fast_assign(
 		__entry->base_address = req->dep->dwc->xhci_resources[0].start;
+		__assign_str(name);
 		__entry->req = req;
 		__entry->actual = req->request.actual;
 		__entry->length = req->request.length;

base-commit: bdf12cde30830d46a8ef1ba93986356f1164b4f1
-- 
2.53.0

Re: [PATCH] usb: dwc3: trace: Restore request name assignment

[sashiko-bot]

> The commit 0a06917432a7 ("usb: dwc3: Log dwc3 address in traces")
> removed the __assign_str(name) call from dwc3_log_request. The name
> field still exists in the trace event, but nothing fills it in, so the
> endpoint name printed for these events is leftover garbage from the ring
> buffer.
> 
> Put the __assign_str() call back so the endpoint name is logged again.
> 
> Fixes: 0a06917432a7 ("usb: dwc3: Log dwc3 address in traces")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/8bd045b136bfef8ce5de79f1fa2f09db639f0707.1792543567.git.Thinh.Nguyen@synopsys.com?part=1