Re: [PATCH 5/6] usbip: vhci_hcd: allocate vhci_priv outside lock and handle ENOMEM

[sashiko-bot@kernel.org]

> In vhci_urb_enqueue(), usb_hcd_link_urb_to_ep() links the URB onto the
> endpoint before calling vhci_tx_urb(), which allocates struct vhci_priv
> with GFP_ATOMIC while holding vhci->lock. If that allocation fails,
> vhci_tx_urb() triggers VDEV_EVENT_ERROR_MALLOC and returns while
> vhci_urb_enqueue() still returns 0, leaving urb->hcpriv NULL and the URB
> linked on ep->urb_list where vhci_urb_dequeue() rejects it with -EIDRM.
> Moreover, failing a single URB submission should return -ENOMEM to the
> caller rather than tearing down the entire USB/IP connection.
> 
> Allocate struct vhci_priv in vhci_urb_enqueue() using the caller's
> mem_flags before acquiring vhci->lock, pass it to vhci_tx_urb(), and
> free it on early-exit and non-transmit paths.
> 
> In vhci_urb_dequeue(), if allocating struct vhci_unlink fails after
> usb_hcd_check_unlink_urb() has already marked urb->unlinked, return 0
> after triggering VDEV_EVENT_ERROR_MALLOC so callers know the unlink was
> accepted and connection teardown will drain priv_rx and give back the
> URB.
> 
> Fixes: 04679b3489e0 ("Staging: USB/IP: add client driver")
> Cc: stable@vger.kernel.org
> Assisted-by: Gemini
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261021150704.3129446-1-rrangel@chromium.org?part=5