[PATCH] usb: gadget: uvc: drop streaming header reference on the EBUSY path

[PATCH] usb: gadget: uvc: drop streaming header reference on the EBUSY path

[Wentao Liang]

config_group_find_item() returns the "h" item with a reference held.  On
success the reference is transferred to uvc->header and released by
uvc_free().  When the streaming header is not linked, uvc_alloc() frees
the function without releasing that reference.

Drop it before freeing the function.

Fixes: f1fd91a0924b ("usb: gadget: webcam: Make g_webcam loadable again")
Cc: stable@vger.kernel.org
Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/usb/gadget/function/f_uvc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/function/f_uvc.c b/drivers/usb/gadget/function/f_uvc.c
index d1bf3ea75197..1633a3535e03 100644
--- a/drivers/usb/gadget/function/f_uvc.c
+++ b/drivers/usb/gadget/function/f_uvc.c
@@ -1146,6 +1146,7 @@ static struct usb_function *uvc_alloc(struct usb_function_instance *fi)
 		uvc->header = to_uvcg_streaming_header(h);
 		if (!uvc->header->linked) {
 			mutex_unlock(&opts->lock);
+			config_item_put(&uvc->header->item);
 			kfree(uvc);
 			return ERR_PTR(-EBUSY);
 		}
-- 
2.34.1

Re: [PATCH] usb: gadget: uvc: drop streaming header reference on the EBUSY path

[sashiko-bot]

> config_group_find_item() returns the "h" item with a reference held.  On
> success the reference is transferred to uvc->header and released by
> uvc_free().  When the streaming header is not linked, uvc_alloc() frees
> the function without releasing that reference.
> 
> Drop it before freeing the function.
> 
> Fixes: f1fd91a0924b ("usb: gadget: webcam: Make g_webcam loadable again")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104021506.1468539-1-vulab@iscas.ac.cn?part=1

Re: [PATCH] usb: gadget: uvc: drop streaming header reference on the EBUSY path

[Krzysztof Kozlowski]

On Wed, 04 Nov 2026 02:15:06 +0000, Wentao Liang wrote:
> config_group_find_item() returns the "h" item with a reference held.  On
> success the reference is transferred to uvc->header and released by
> uvc_free().  When the streaming header is not linked, uvc_alloc() frees
> the function without releasing that reference.
> 
> Drop it before freeing the function.
> 
> Fixes: f1fd91a0924b ("usb: gadget: webcam: Make g_webcam loadable again")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
>  drivers/usb/gadget/function/f_uvc.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Multiple things here:
1. Your team ignored completely previous feedback. Multiple times.

2. You use multiple identities with this email address, thus I doubt that we
   speak with an actual person.

3. Your bot does not even bother running checkpatch, right?

4. Nothing of this was reproduced nor tested.

5. Finally, the same feedback:
You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.

More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.

This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down.  Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.

Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem (so a patchset grouping multiple patches with a short cover
letter), how to document the issue discovery method and what was
or was not tested.

Best regards,
Krzysztof