Re: [PATCH net-next v8 01/11] r8152: fix RTL8156/RTL8156B/RTL8157/RTL8159 up and down settings

[sashiko-bot@kernel.org]

> Several settings the datasheet requires for these chips were either
> missing or gated on the wrong version range in the shared
> rtl8156_up()/rtl8156_down():
> 
> - PLA_RCR1 BIT(3) must be cleared on up for all of them. It was
>   cleared only for RTL_VER_16 and later, so RTL8156/RTL8156B never
>   reached it.
> - USB_SPEED_OPTION's RG_PWRDN_EN and ALL_SPEED_OFF must be cleared on
>   up for RTL8157/RTL8159 as well. The "version < RTL_VER_16" check
>   excluded precisely the chips that need it.
> - Clear_SDR must be enabled on up: USB 0xd3ca BIT(15) on RTL8156B
>   (VER_13/15), and USB 0xd378 BIT(7) set plus USB 0xcd06 BIT(15)
>   cleared on RTL8157/RTL8159.
> - Entering OOB needs PLA_BDC_CR's ALDPS_PROXY_MODE and PLA_OOB_CTRL's
>   DIS_MCU_CLROOB. Only r8152b_enter_oob() and r8153_enter_oob() set
>   them; the RTL8156 family down path set NOW_IS_OOB alone.
> - RTL8157/RTL8159 OOB RX settings are PLA_RMS 1526 and PLA_MTPS 10K,
>   not the 1522 and 6K they inherited.
> - PLA_MCU_SPDWN_EN is not used by RTL8157/RTL8159, so stop managing
>   it on up/down for them.
> 
> Fixes: 195aae321c82 ("r8152: support new chips")
> Fixes: fd3c7d080df5 ("r8152: Add support for the RTL8157 hardware")
> Fixes: ad2a55b63b41 ("r8152: Add support for the RTL8159 chip")
> Signed-off-by: Chih Kai Hsu <hsu.chih.kai@realtek.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110032416.16968-1-nic_swsd@realtek.com?part=1