Re: [PATCH net-next v8 04/11] r8152: fix flow control for RTL8156/RTL8156B/RTL8157/RTL8159

[sashiko-bot@kernel.org]

> The flow-control setup that limits pause frames was incomplete or
> missing on several chips:
> 
> - RTL8156A (VER_10/11): r8156_init() skipped them, so the FC timer and
>   FLOW_CTRL_PATCH_OPT setup that the FC_PATCH_TASK toggle in
>   rtl8156_enable() depends on was never done.
> - RTL8157/RTL8159 (VER_16/17): no limit on the number of pause packets
>   was programmed, so they could keep sending pause frames
>   indefinitely.
> 
> Collect the per-family sequence into rtl_fc_pause_pkt_en() and call it
> for all of them.
> 
> - VER_10/11: the FC timer + FLOW_CTRL_PATCH_OPT sequence that
>   RTL8153B (VER_09) already runs from its pre_fw/post_fw hooks,
> [ ... ]
> 
> Fixes: 195aae321c82 ("r8152: support new chips")
> Fixes: fd3c7d080df5 ("r8152: Add support for the RTL8157 hardware")
> Fixes: ad2a55b63b41 ("r8152: Add support for the RTL8159 chip")
> Signed-off-by: Chih Kai Hsu <hsu.chih.kai@realtek.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110032416.16968-1-nic_swsd@realtek.com?part=4