* [PATCH 0/2] usb: misc: onboard_usb_dev: Add Genesys Logic GL3525 hub support @ 2026-11-11 10:36 Fei Shao 2026-11-11 10:36 ` [PATCH 1/2] dt-bindings: usb: Add Genesys Logic GL3525 hub controller Fei Shao 2026-11-11 10:36 ` [PATCH 2/2] usb: misc: onboard_usb_dev: Add Genesys Logic GL3525 hub support Fei Shao 0 siblings, 2 replies; 6+ messages in thread From: Fei Shao @ 2026-11-11 10:36 UTC (permalink / raw) To: Greg Kroah-Hartman, Matthias Kaehlcke Cc: Fei Shao, Conor Dooley, Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel, linux-usb This series adds DT binding and onboard_usb_dev driver support for the Genesys Logic GL3525 hub controller. Fei Shao (2): dt-bindings: usb: Add Genesys Logic GL3525 hub controller usb: misc: onboard_usb_dev: Add Genesys Logic GL3525 hub support Documentation/devicetree/bindings/usb/genesys,gl850g.yaml | 4 ++++ drivers/usb/misc/onboard_usb_dev.c | 2 ++ drivers/usb/misc/onboard_usb_dev.h | 2 ++ 3 files changed, 8 insertions(+) -- 2.56.0.542.g3ef89b7020-goog ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] dt-bindings: usb: Add Genesys Logic GL3525 hub controller 2026-11-11 10:36 [PATCH 0/2] usb: misc: onboard_usb_dev: Add Genesys Logic GL3525 hub support Fei Shao @ 2026-11-11 10:36 ` Fei Shao 2026-11-11 10:44 ` sashiko-bot 2026-11-11 18:00 ` Conor Dooley 2026-11-11 10:36 ` [PATCH 2/2] usb: misc: onboard_usb_dev: Add Genesys Logic GL3525 hub support Fei Shao 1 sibling, 2 replies; 6+ messages in thread From: Fei Shao @ 2026-11-11 10:36 UTC (permalink / raw) To: Greg Kroah-Hartman, Matthias Kaehlcke Cc: Fei Shao, Conor Dooley, Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel, linux-usb Add USB 3.2 (usb5e3,629) and USB 2.0 (usb5e3,630) compatibles for the Genesys Logic GL3525 hub controller, which is powered by a 5V VDD supply like GL3523. Signed-off-by: Fei Shao <fshao@chromium.org> --- Documentation/devicetree/bindings/usb/genesys,gl850g.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml index e8b8c03f87a0..5153a988a835 100644 --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml @@ -17,6 +17,8 @@ properties: - usb5e3,620 - usb5e3,625 - usb5e3,626 + - usb5e3,629 + - usb5e3,630 reg: true @@ -70,6 +72,8 @@ allOf: enum: - usb5e3,610 - usb5e3,620 + - usb5e3,629 + - usb5e3,630 then: properties: peer-hub: true -- 2.56.0.542.g3ef89b7020-goog ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: usb: Add Genesys Logic GL3525 hub controller 2026-11-11 10:36 ` [PATCH 1/2] dt-bindings: usb: Add Genesys Logic GL3525 hub controller Fei Shao @ 2026-11-11 10:44 ` sashiko-bot 2026-11-11 18:00 ` Conor Dooley 1 sibling, 0 replies; 6+ messages in thread From: sashiko-bot @ 2026-11-11 10:44 UTC (permalink / raw) To: Fei Shao; +Cc: devicetree, linux-usb, robh, conor+dt Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] dt-bindings: usb: unwieldy per-compatible conditionals in genesys,gl850g.yaml -- commit 74488a0f4f0a5f370e0fe57ea84abc8dcd904262 Author: Fei Shao <fshao@chromium.org> dt-bindings: usb: Add Genesys Logic GL3525 hub controller This commit adds the USB 3.2 (usb5e3,629) and USB 2.0 (usb5e3,630) compatible strings for the Genesys Logic GL3525 hub controller to genesys,gl850g.yaml. > diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > index e8b8c03f87a0e..5153a988a835e 100644 > --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml > +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml [ ... ] > @@ -70,6 +72,8 @@ allOf: > enum: > - usb5e3,610 > - usb5e3,620 > + - usb5e3,629 > + - usb5e3,630 > then: > properties: > peer-hub: true [Severity: Low] This isn't a bug, but the per-compatible if-then conditionals in allOf are becoming unwieldy and inconsistent as more hub variants with different supply and peer-hub rules are added to genesys,gl850g.yaml. In particular, setting peer-hub: true and vdd-supply: true in the then blocks is redundant because those properties are already defined at the top level, usb5e3,626 is omitted from the conditionals entirely (leaving vdd12-supply allowed on usb5e3,626 while disallowing it here), and usb5e3,610 is restricted to vdd12-supply: false even when paired as the USB 2.0 companion hub for GL3590 (usb5e3,625). Could these variants be split into separate schema documents, or the conditionals simplified to only restrict the properties that do not apply to specific compatibles? -- Sashiko AI review · https://sashiko.dev/#/patchset/20261111103710.1393311-1-fshao@chromium.org?part=1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: usb: Add Genesys Logic GL3525 hub controller 2026-11-11 10:36 ` [PATCH 1/2] dt-bindings: usb: Add Genesys Logic GL3525 hub controller Fei Shao 2026-11-11 10:44 ` sashiko-bot @ 2026-11-11 18:00 ` Conor Dooley 1 sibling, 0 replies; 6+ messages in thread From: Conor Dooley @ 2026-11-11 18:00 UTC (permalink / raw) To: Fei Shao Cc: Greg Kroah-Hartman, Matthias Kaehlcke, Conor Dooley, Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel, linux-usb [-- Attachment #1: Type: text/plain, Size: 75 bytes --] Acked-by: Conor Dooley <conor.dooley@microchip.com> pw-bot: not-applicable [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] usb: misc: onboard_usb_dev: Add Genesys Logic GL3525 hub support 2026-11-11 10:36 [PATCH 0/2] usb: misc: onboard_usb_dev: Add Genesys Logic GL3525 hub support Fei Shao 2026-11-11 10:36 ` [PATCH 1/2] dt-bindings: usb: Add Genesys Logic GL3525 hub controller Fei Shao @ 2026-11-11 10:36 ` Fei Shao 2026-11-11 10:42 ` sashiko-bot 1 sibling, 1 reply; 6+ messages in thread From: Fei Shao @ 2026-11-11 10:36 UTC (permalink / raw) To: Greg Kroah-Hartman, Matthias Kaehlcke; +Cc: Fei Shao, linux-kernel, linux-usb Add support for the Genesys Logic GL3525 USB 3.2 (05e3:0629) and USB 2.0 (05e3:0630) hub controller, which shares the same reset duration and one VDD supply as GL3523. Signed-off-by: Fei Shao <fshao@chromium.org> --- drivers/usb/misc/onboard_usb_dev.c | 2 ++ drivers/usb/misc/onboard_usb_dev.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c index 0606d405c16f..3bf03e1d1287 100644 --- a/drivers/usb/misc/onboard_usb_dev.c +++ b/drivers/usb/misc/onboard_usb_dev.c @@ -666,6 +666,8 @@ static const struct usb_device_id onboard_dev_id_table[] = { { USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G USB 2.0 HUB */ { USB_DEVICE(VENDOR_ID_GENESYS, 0x0620) }, /* Genesys Logic GL3523 USB 3.1 HUB */ { USB_DEVICE(VENDOR_ID_GENESYS, 0x0625) }, /* Genesys Logic GL3590 USB 3.2 HUB */ + { USB_DEVICE(VENDOR_ID_GENESYS, 0x0629) }, /* Genesys Logic GL3525 USB 3.2 HUB */ + { USB_DEVICE(VENDOR_ID_GENESYS, 0x0630) }, /* Genesys Logic GL3525 USB 2.0 HUB */ { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2412) }, /* USB2412 USB 2.0 HUB */ { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2514) }, /* USB2514B USB 2.0 HUB */ { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2517) }, /* USB2517 USB 2.0 HUB */ diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h index 3523f8f8a149..b1844a068ddd 100644 --- a/drivers/usb/misc/onboard_usb_dev.h +++ b/drivers/usb/misc/onboard_usb_dev.h @@ -155,6 +155,8 @@ static const struct of_device_id onboard_dev_match[] = { { .compatible = "usb5e3,620", .data = &genesys_gl852g_data, }, { .compatible = "usb5e3,625", .data = &genesys_gl3590_data, }, { .compatible = "usb5e3,626", .data = &genesys_gl852g_data, }, + { .compatible = "usb5e3,629", .data = &genesys_gl852g_data, }, + { .compatible = "usb5e3,630", .data = &genesys_gl852g_data, }, { .compatible = "usbbda,179", .data = &realtek_rtl8188etv_data, }, { .compatible = "usbbda,411", .data = &realtek_rts5411_data, }, { .compatible = "usbbda,5411", .data = &realtek_rts5411_data, }, -- 2.56.0.542.g3ef89b7020-goog ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] usb: misc: onboard_usb_dev: Add Genesys Logic GL3525 hub support 2026-11-11 10:36 ` [PATCH 2/2] usb: misc: onboard_usb_dev: Add Genesys Logic GL3525 hub support Fei Shao @ 2026-11-11 10:42 ` sashiko-bot 0 siblings, 0 replies; 6+ messages in thread From: sashiko-bot @ 2026-11-11 10:42 UTC (permalink / raw) To: Fei Shao; +Cc: linux-usb > Add support for the Genesys Logic GL3525 USB 3.2 (05e3:0629) and USB 2.0 > (05e3:0630) hub controller, which shares the same reset duration and one > VDD supply as GL3523. > > Signed-off-by: Fei Shao <fshao@chromium.org> Sashiko has reviewed this patch and found no issues. -- Sashiko AI review · https://sashiko.dev/#/patchset/20261111103710.1393311-1-fshao@chromium.org?part=2 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-11-11 18:00 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-11-11 10:36 [PATCH 0/2] usb: misc: onboard_usb_dev: Add Genesys Logic GL3525 hub support Fei Shao 2026-11-11 10:36 ` [PATCH 1/2] dt-bindings: usb: Add Genesys Logic GL3525 hub controller Fei Shao 2026-11-11 10:44 ` sashiko-bot 2026-11-11 18:00 ` Conor Dooley 2026-11-11 10:36 ` [PATCH 2/2] usb: misc: onboard_usb_dev: Add Genesys Logic GL3525 hub support Fei Shao 2026-11-11 10:42 ` sashiko-bot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox