[PATCH] usb: typec: stusb160x: disable the interrupt before tearing down

[PATCH] usb: typec: stusb160x: disable the interrupt before tearing down

[Myeonghun Pak]

The devm-managed IRQ remains active while stusb160x_remove() tears down
the partner, VBUS, role switch and Type-C port. An attach or detach event
can race with partner removal or access the port and role switch after
they are released.

Disable and synchronize the IRQ at the start of remove(), before any of
these resources are torn down.

Found by a static analysis tool under development.
Not tested on hardware.

Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
Cc: stable@vger.kernel.org
Co-developed-by: Ijae Kim <ae878000@gmail.com>
Signed-off-by: Ijae Kim <ae878000@gmail.com>
Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
---

 drivers/usb/typec/stusb160x.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
index a2ec0565bd85..ec2f4d7f7ed3 100644
--- a/drivers/usb/typec/stusb160x.c
+++ b/drivers/usb/typec/stusb160x.c
@@ -801,6 +801,9 @@ static void stusb160x_remove(struct i2c_client *client)
 {
 	struct stusb160x *chip = i2c_get_clientdata(client);
 
+	if (client->irq)
+		disable_irq(client->irq);
+
 	if (chip->partner) {
 		typec_unregister_partner(chip->partner);
 		chip->partner = NULL;

base-commit: 630059a5a632377b9b7b487baccde92b7ae1dd47
-- 
2.43.0

Re: [PATCH] usb: typec: stusb160x: disable the interrupt before tearing down

[sashiko-bot]

> The devm-managed IRQ remains active while stusb160x_remove() tears down
> the partner, VBUS, role switch and Type-C port. An attach or detach event
> can race with partner removal or access the port and role switch after
> they are released.
> 
> Disable and synchronize the IRQ at the start of remove(), before any of
> these resources are torn down.
> 
> Found by a static analysis tool under development.
> Not tested on hardware.
> 
> Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
> Cc: stable@vger.kernel.org
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112065620.34269-1-mhun512@gmail.com?part=1