Re: [PATCH 8/8] usb: typec: fusb302: drop custom gpio interrupt logic

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] usb: typec: fusb302: void stub for fusb302_debugfs_init()
  breaks !CONFIG_DEBUG_FS build
--

commit 68b5d98996b526119f13f5957d4fd6cf07fb01e3
Author: Sebastian Reichel <sebastian.reichel@collabora.com>

usb: typec: fusb302: drop custom gpio interrupt logic

This commit removes the undocumented "fcs,int_n" GPIO fallback from the
fusb302 driver and requires client->irq to be populated.

> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 6105f09f96aad..c392134cdc0c5 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c

[ ... ]

> @@ -1751,13 +1733,10 @@ static int fusb302_probe(struct i2c_client *client)
>  	if (ret < 0)
>  		return ret;

[Severity: Medium]
Does fusb302_probe() fail to build when CONFIG_DEBUG_FS is disabled?

Earlier in this series, commit "usb: typec: fusb302: Switch to device
managed resources" changed fusb302_debugfs_init() to return int and
assigned its return value to ret right above this check, but the
!CONFIG_DEBUG_FS stub still returns void:

drivers/usb/typec/tcpm/fusb302.c:
#ifdef CONFIG_DEBUG_FS
...
static int fusb302_debugfs_init(struct fusb302_chip *chip)
...
#else
...
static void fusb302_debugfs_init(const struct fusb302_chip *chip) { }

#endif

Returning 0 from the !CONFIG_DEBUG_FS stub of fusb302_debugfs_init()
avoids the build failure.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-fusb302-probe-cleanup-v1-0-e5c65a8c58c8@collabora.com?part=8