Linux USB
 help / color / mirror / Atom feed
* [PATCH] usb: host: max3421: Fix potential resource leak on IRQ request failure
@ 2026-11-16 14:25 Guangshuo Li
  2026-11-16 14:36 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Guangshuo Li @ 2026-11-16 14:25 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-usb, linux-kernel

If request_irq() fails after usb_add_hcd(), probe drops the HCD reference
without removing the registered root hub. The root hub and its HCD
reference are left behind.

Remove the HCD before unwinding the SPI thread. Keep the transfer buffers
and platform data alive until the thread has stopped.

This issue was found by our static analysis tool under development.

Fixes: 2d53139f3162 ("Add support for using a MAX3421E chip as a host driver.")
Signed-off-by: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
---
 drivers/usb/host/max3421-hcd.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c
index 73e76d0e6973..09ba92c41a0d 100644
--- a/drivers/usb/host/max3421-hcd.c
+++ b/drivers/usb/host/max3421-hcd.c
@@ -1911,23 +1911,24 @@ max3421_probe(struct spi_device *spi)
 			     IRQF_TRIGGER_LOW, "max3421", hcd);
 	if (retval < 0) {
 		dev_err(&spi->dev, "failed to request irq %d\n", spi->irq);
-		goto error;
+		goto remove_hcd;
 	}
 	return 0;
 
+remove_hcd:
+	usb_remove_hcd(hcd);
 error:
-	if (IS_ENABLED(CONFIG_OF) && dev->of_node && pdata) {
-		devm_kfree(&spi->dev, pdata);
-		spi->dev.platform_data = NULL;
-	}
-
 	if (hcd) {
-		kfree(max3421_hcd->tx);
-		kfree(max3421_hcd->rx);
 		if (!IS_ERR_OR_NULL(max3421_hcd->spi_thread))
 			kthread_stop(max3421_hcd->spi_thread);
+		kfree(max3421_hcd->tx);
+		kfree(max3421_hcd->rx);
 		usb_put_hcd(hcd);
 	}
+	if (IS_ENABLED(CONFIG_OF) && dev->of_node && pdata) {
+		devm_kfree(&spi->dev, pdata);
+		spi->dev.platform_data = NULL;
+	}
 	return retval;
 }
 

base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-16 14:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 14:25 [PATCH] usb: host: max3421: Fix potential resource leak on IRQ request failure Guangshuo Li
2026-11-16 14:36 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox