Linux USB
 help / color / mirror / Atom feed
* [PATCH v2 0/1] usb: gadget: f_fs: Fix synchronous read() behavior
@ 2026-11-20 14:59 Ingo Rohloff
  2026-11-20 14:59 ` [PATCH v2 1/1] " Ingo Rohloff
  0 siblings, 1 reply; 3+ messages in thread
From: Ingo Rohloff @ 2026-11-20 14:59 UTC (permalink / raw)
  To: gregkh
  Cc: viro, nkapron, me, nuno.sa, michael.bommarito, prostitisgabriel,
	kees, linux-usb, Ingo Rohloff

This 2nd version just changes the commit message.
I agree that the 1st varsion failed to explain the problem correctly.

Unfortunately **depending on the hardware** this patch MIGHT change
behavior for userspace, which is a no-no.
BUT: The behavior for userspace is already dependent on the hardware,
without the patch, so I don't see that as a blocker.

What the patch does is to make sure that userspace always gets
the same (correct?) behavior regardless of hardware.

There still is a border case, what to do with ZLPs (Zero Length Packets):
Userspace read() requests a multiple of MaxPacketSize and USB Host sends
exactly the length userspace requests followed by a ZLP.
It's unclear what to do with this extra ZLP.
OTOH: I already have seen many USB Host controllers, which don't handle
Zero Length Packets correctly, so ZLPs should anyway be avoided at all
costs.

Note: I really would like to get rid of "quirk_ep_out_aligned_size" in
"struct usb_gadget" completely.
But this flag is also used in "drivers/usb/gadget/function/u_ether.c",
and I have no clue about this code and no way to test it.

---
Changes in v2:
- Redo the commit message to try to explain the problem properly.
  Unfortunately this is now a wall of text, but the problem is complicted.

Link to v1: https://lore.kernel.org/linux-usb/20260903153737.58087-1-ingo.rohloff@lauterbach.com/

---
Ingo Rohloff (1):
  usb: gadget: f_fs: Fix synchronous read() behavior

 drivers/usb/gadget/function/f_fs.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

--
2.55.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-20 15:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 14:59 [PATCH v2 0/1] usb: gadget: f_fs: Fix synchronous read() behavior Ingo Rohloff
2026-11-20 14:59 ` [PATCH v2 1/1] " Ingo Rohloff
2026-11-20 15:09   ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox