From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Guenter Roeck" <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
"Wim Van Sebroeck" <wim@iguana.be>,
"Rob Herring" <rob.herring@calxeda.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Grant Likely" <grant.likely@linaro.org>
Subject: Re: [PATCH v3] watchdog: GPIO-controlled watchdog
Date: Sun, 01 Dec 2013 23:03:27 +0400 [thread overview]
Message-ID: <1385924607.556195103@f310.i.mail.ru> (raw)
In-Reply-To: <529B78DC.7070200@roeck-us.net>
Hello.
> On 11/29/2013 11:54 PM, Alexander Shiyan wrote:
> > This patch adds a watchdog driver for devices controlled through GPIO,
> > (Analog Devices ADM706, Maxim MAX823, National NE555 etc).
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
>
> Looks pretty good, except for a single nitpick below (sorry I didn't notice that one earlier).
>
> Also, as mentioned before, a changelog describing what changed and what didn't
> would be really helpful.
Just fixed all observations made by you earlier.
...
> > + /* Disallow values lower than 2 and higher than 65535 ms */
> > + if ((hw_margin < 2) || (hw_margin > 65535))
>
> Unnecessary ( ).
This can be corrected during merge. Isn't it? Or you expect v4?
Thanks.
---
next prev parent reply other threads:[~2013-12-01 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 7:54 [PATCH v3] watchdog: GPIO-controlled watchdog Alexander Shiyan
2013-12-01 17:58 ` Guenter Roeck
2013-12-01 19:03 ` Alexander Shiyan [this message]
2013-12-01 19:14 ` Guenter Roeck
2014-01-06 20:48 ` Wim Van Sebroeck
2013-12-07 6:52 ` Alexander Shiyan
2013-12-07 7:14 ` Guenter Roeck
2014-01-06 21:10 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385924607.556195103@f310.i.mail.ru \
--to=shc_work@mail.ru \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox