From: Wim Van Sebroeck <wim@iguana.be>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH v3] watchdog: GPIO-controlled watchdog
Date: Mon, 6 Jan 2014 21:48:45 +0100 [thread overview]
Message-ID: <20140106204845.GA16713@spo001.leaseweb.com> (raw)
In-Reply-To: <1385924607.556195103@f310.i.mail.ru>
Hi Alexander,
> > > + /* Disallow values lower than 2 and higher than 65535 ms */
> > > + if ((hw_margin < 2) || (hw_margin > 65535))
> >
> > Unnecessary ( ).
>
> This can be corrected during merge. Isn't it? Or you expect v4?
Yes, can be corrected during merge window, so no v4 expected.
Kind regards,
Wim.
next prev parent reply other threads:[~2014-01-06 20:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 7:54 [PATCH v3] watchdog: GPIO-controlled watchdog Alexander Shiyan
2013-12-01 17:58 ` Guenter Roeck
2013-12-01 19:03 ` Alexander Shiyan
2013-12-01 19:14 ` Guenter Roeck
2014-01-06 20:48 ` Wim Van Sebroeck [this message]
2013-12-07 6:52 ` Alexander Shiyan
2013-12-07 7:14 ` Guenter Roeck
2014-01-06 21:10 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106204845.GA16713@spo001.leaseweb.com \
--to=wim@iguana.be \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=shc_work@mail.ru \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox