From: Athira Lekshmi <andnlnbn18@gmail.com>
To: wim@iguana.be
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Athira Lekshmi <andnlnbn18@gmail.com>
Subject: [PATCH v2 7/8] watchdog: at91sam9_wdt: Fixed missing blank line warning
Date: Thu, 15 Jan 2015 21:02:05 +0530 [thread overview]
Message-ID: <1421335926-3321-7-git-send-email-andnlnbn18@gmail.com> (raw)
In-Reply-To: <1421335926-3321-1-git-send-email-andnlnbn18@gmail.com>
Add a blank line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'
Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
---
Changes in v2:
- Make the commit message more clearer.
drivers/watchdog/at91sam9_wdt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c
index 489729b..794a34a 100644
--- a/drivers/watchdog/at91sam9_wdt.c
+++ b/drivers/watchdog/at91sam9_wdt.c
@@ -82,6 +82,7 @@ MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started "
#define to_wdt(wdd) container_of(wdd, struct at91wdt, wdd)
struct at91wdt {
struct watchdog_device wdd;
+
void __iomem *base;
unsigned long next_heartbeat; /* the next_heartbeat for the timer */
struct timer_list timer; /* The timer that pings the watchdog */
@@ -121,6 +122,7 @@ static inline void at91_wdt_reset(struct at91wdt *wdt)
static void at91_ping(unsigned long data)
{
struct at91wdt *wdt = (struct at91wdt *)data;
+
if (time_before(jiffies, wdt->next_heartbeat) ||
!watchdog_active(&wdt->wdd)) {
at91_wdt_reset(wdt);
@@ -372,6 +374,7 @@ static int __init at91wdt_probe(struct platform_device *pdev)
static int __exit at91wdt_remove(struct platform_device *pdev)
{
struct at91wdt *wdt = platform_get_drvdata(pdev);
+
watchdog_unregister_device(&wdt->wdd);
pr_warn("I quit now, hardware will probably reboot!\n");
--
1.7.9.5
next prev parent reply other threads:[~2015-01-15 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 15:31 [PATCH v2 1/8] watchdog: wdt_pci: Fixed missing blank line warning Athira Lekshmi
2015-01-15 15:32 ` [PATCH v2 2/8] watchdog: sch311x_wdt: " Athira Lekshmi
2015-01-15 15:32 ` [PATCH v2 3/8] watchdog: alim1535_wdt: " Athira Lekshmi
2015-01-15 15:32 ` [PATCH v2 4/8] watchdog: advantechwdt: " Athira Lekshmi
2015-01-15 15:32 ` [PATCH v2 5/8] watchdog: acquirewdt: " Athira Lekshmi
2015-01-15 15:32 ` [PATCH v2 6/8] watchdog: ar7_wdt: " Athira Lekshmi
2015-01-15 15:32 ` Athira Lekshmi [this message]
2015-01-15 15:32 ` [PATCH v2 8/8] watchdog: eurotechwdt: " Athira Lekshmi
2015-01-16 14:32 ` [PATCH v2 1/8] watchdog: wdt_pci: " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421335926-3321-7-git-send-email-andnlnbn18@gmail.com \
--to=andnlnbn18@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox