From: Guenter Roeck <linux@roeck-us.net>
To: Athira Lekshmi <andnlnbn18@gmail.com>, wim@iguana.be
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/8] watchdog: wdt_pci: Fixed missing blank line warning
Date: Fri, 16 Jan 2015 06:32:28 -0800 [thread overview]
Message-ID: <54B920FC.8090905@roeck-us.net> (raw)
In-Reply-To: <1421335926-3321-1-git-send-email-andnlnbn18@gmail.com>
On 01/15/2015 07:31 AM, Athira Lekshmi wrote:
> Add a new line after declarations to remove the checkpatch warning:
> 'Missing blank line after declarations'
>
> Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
> ---
> Changes in v2:
> - Make the commit message more clearer.
>
The patches are all good, though I would suggest something like
"Add missing blank lines" as subject, and I would suggest to merge
the 8 watchdog patches into one.
Thanks,
Guenter
prev parent reply other threads:[~2015-01-16 14:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 15:31 [PATCH v2 1/8] watchdog: wdt_pci: Fixed missing blank line warning Athira Lekshmi
2015-01-15 15:32 ` [PATCH v2 2/8] watchdog: sch311x_wdt: " Athira Lekshmi
2015-01-15 15:32 ` [PATCH v2 3/8] watchdog: alim1535_wdt: " Athira Lekshmi
2015-01-15 15:32 ` [PATCH v2 4/8] watchdog: advantechwdt: " Athira Lekshmi
2015-01-15 15:32 ` [PATCH v2 5/8] watchdog: acquirewdt: " Athira Lekshmi
2015-01-15 15:32 ` [PATCH v2 6/8] watchdog: ar7_wdt: " Athira Lekshmi
2015-01-15 15:32 ` [PATCH v2 7/8] watchdog: at91sam9_wdt: " Athira Lekshmi
2015-01-15 15:32 ` [PATCH v2 8/8] watchdog: eurotechwdt: " Athira Lekshmi
2015-01-16 14:32 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B920FC.8090905@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andnlnbn18@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox