[PATCH v2 1/8] watchdog: wdt_pci: Fixed missing blank line warning

[PATCH v2 1/8] watchdog: wdt_pci: Fixed missing blank line warning

[Athira Lekshmi]

Add a new line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'

Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
---
Changes in v2:
  -  Make the commit message more clearer.

 drivers/watchdog/wdt_pci.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/watchdog/wdt_pci.c b/drivers/watchdog/wdt_pci.c
index 48b2c05..b84a180 100644
--- a/drivers/watchdog/wdt_pci.c
+++ b/drivers/watchdog/wdt_pci.c
@@ -279,6 +279,7 @@ static int wdtpci_get_temperature(int *temperature)
 {
 	unsigned short c;
 	unsigned long flags;
+
 	spin_lock_irqsave(&wdtpci_lock, flags);
 	c = inb(WDT_RT);
 	udelay(8);
@@ -366,6 +367,7 @@ static ssize_t wdtpci_write(struct file *file, const char __user *buf,
 
 			for (i = 0; i != count; i++) {
 				char c;
+
 				if (get_user(c, buf + i))
 					return -EFAULT;
 				if (c == 'V')
-- 
1.7.9.5

[PATCH v2 2/8] watchdog: sch311x_wdt: Fixed missing blank line warning

[Athira Lekshmi]

Add a new line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'

Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
---
Changes in v2:
  -  Make the commit message more clearer.

 drivers/watchdog/sch311x_wdt.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/sch311x_wdt.c b/drivers/watchdog/sch311x_wdt.c
index b96127e..b550c83 100644
--- a/drivers/watchdog/sch311x_wdt.c
+++ b/drivers/watchdog/sch311x_wdt.c
@@ -233,6 +233,7 @@ static ssize_t sch311x_wdt_write(struct file *file, const char __user *buf,
 
 			for (i = 0; i != count; i++) {
 				char c;
+
 				if (get_user(c, buf + i))
 					return -EFAULT;
 				if (c == 'V')
-- 
1.7.9.5

[PATCH v2 3/8] watchdog: alim1535_wdt: Fixed missing blank line warning

[Athira Lekshmi]

Add a blank line after declarations to remove the checkpatch warning:
'Missing line after declarations'

Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
---
Changes in v2:
  -  Make the commit message more clearer.

 drivers/watchdog/alim1535_wdt.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/watchdog/alim1535_wdt.c b/drivers/watchdog/alim1535_wdt.c
index 3a17fbd..a505a78 100644
--- a/drivers/watchdog/alim1535_wdt.c
+++ b/drivers/watchdog/alim1535_wdt.c
@@ -154,6 +154,7 @@ static ssize_t ali_write(struct file *file, const char __user *data,
 			   the magic character */
 			for (i = 0; i != len; i++) {
 				char c;
+
 				if (get_user(c, data + i))
 					return -EFAULT;
 				if (c == 'V')
@@ -218,6 +219,7 @@ static long ali_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 	case WDIOC_SETTIMEOUT:
 	{
 		int new_timeout;
+
 		if (get_user(new_timeout, p))
 			return -EFAULT;
 		if (ali_settimer(new_timeout))
-- 
1.7.9.5

[PATCH v2 4/8] watchdog: advantechwdt: Fixed missing blank line warning

[Athira Lekshmi]

Add a blank line after declarations to remove the checkpatch warning:
'Missing line after declarations'

Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
---
Changes in v2:
  - Make the commit message more clearer.

 drivers/watchdog/advantechwdt.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/advantechwdt.c b/drivers/watchdog/advantechwdt.c
index 7796db7..74e49ed 100644
--- a/drivers/watchdog/advantechwdt.c
+++ b/drivers/watchdog/advantechwdt.c
@@ -121,6 +121,7 @@ static ssize_t advwdt_write(struct file *file, const char __user *buf,
 
 			for (i = 0; i != count; i++) {
 				char c;
+
 				if (get_user(c, buf + i))
 					return -EFAULT;
 				if (c == 'V')
-- 
1.7.9.5

[PATCH v2 5/8] watchdog: acquirewdt: Fixed missing blank line warning

[Athira Lekshmi]

Add a blank line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'

Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
---
Changes in v2:
  - Make the commit message more clearer.

 drivers/watchdog/acquirewdt.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/acquirewdt.c b/drivers/watchdog/acquirewdt.c
index 5614416..d78a120 100644
--- a/drivers/watchdog/acquirewdt.c
+++ b/drivers/watchdog/acquirewdt.c
@@ -132,6 +132,7 @@ static ssize_t acq_write(struct file *file, const char __user *buf,
 			   magic character */
 			for (i = 0; i != count; i++) {
 				char c;
+
 				if (get_user(c, buf + i))
 					return -EFAULT;
 				if (c == 'V')
-- 
1.7.9.5

[PATCH v2 6/8] watchdog: ar7_wdt: Fixed missing blank line warning

[Athira Lekshmi]

Add a blank line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'

Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
---
Changes in v2:
  - Make the commit message more clearer.

 drivers/watchdog/ar7_wdt.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/ar7_wdt.c b/drivers/watchdog/ar7_wdt.c
index ae6c287..d001365 100644
--- a/drivers/watchdog/ar7_wdt.c
+++ b/drivers/watchdog/ar7_wdt.c
@@ -202,6 +202,7 @@ static ssize_t ar7_wdt_write(struct file *file, const char *data,
 		expect_close = 0;
 		for (i = 0; i < len; ++i) {
 			char c;
+
 			if (get_user(c, data + i))
 				return -EFAULT;
 			if (c == 'V')
-- 
1.7.9.5

[PATCH v2 7/8] watchdog: at91sam9_wdt: Fixed missing blank line warning

[Athira Lekshmi]

Add a blank line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'

Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
---
Changes in v2:
  - Make the commit message more clearer.

 drivers/watchdog/at91sam9_wdt.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c
index 489729b..794a34a 100644
--- a/drivers/watchdog/at91sam9_wdt.c
+++ b/drivers/watchdog/at91sam9_wdt.c
@@ -82,6 +82,7 @@ MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started "
 #define to_wdt(wdd) container_of(wdd, struct at91wdt, wdd)
 struct at91wdt {
 	struct watchdog_device wdd;
+
 	void __iomem *base;
 	unsigned long next_heartbeat;	/* the next_heartbeat for the timer */
 	struct timer_list timer;	/* The timer that pings the watchdog */
@@ -121,6 +122,7 @@ static inline void at91_wdt_reset(struct at91wdt *wdt)
 static void at91_ping(unsigned long data)
 {
 	struct at91wdt *wdt = (struct at91wdt *)data;
+
 	if (time_before(jiffies, wdt->next_heartbeat) ||
 	    !watchdog_active(&wdt->wdd)) {
 		at91_wdt_reset(wdt);
@@ -372,6 +374,7 @@ static int __init at91wdt_probe(struct platform_device *pdev)
 static int __exit at91wdt_remove(struct platform_device *pdev)
 {
 	struct at91wdt *wdt = platform_get_drvdata(pdev);
+
 	watchdog_unregister_device(&wdt->wdd);
 
 	pr_warn("I quit now, hardware will probably reboot!\n");
-- 
1.7.9.5

[PATCH v2 8/8] watchdog: eurotechwdt: Fixed missing blank line warning

[Athira Lekshmi]

Add a blank line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'

Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
---
Changes in v2:
  - Make the commit message more clearer.

 drivers/watchdog/eurotechwdt.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/eurotechwdt.c b/drivers/watchdog/eurotechwdt.c
index 23ee532..86b19ee 100644
--- a/drivers/watchdog/eurotechwdt.c
+++ b/drivers/watchdog/eurotechwdt.c
@@ -210,6 +210,7 @@ size_t count, loff_t *ppos)
 
 			for (i = 0; i != count; i++) {
 				char c;
+
 				if (get_user(c, buf + i))
 					return -EFAULT;
 				if (c == 'V')
-- 
1.7.9.5

Re: [PATCH v2 1/8] watchdog: wdt_pci: Fixed missing blank line warning

[Guenter Roeck]

On 01/15/2015 07:31 AM, Athira Lekshmi wrote:
> Add a new line after declarations to remove the checkpatch warning:
> 'Missing blank line after declarations'
>
> Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
> ---
> Changes in v2:
>    -  Make the commit message more clearer.
>

The patches are all good, though I would suggest something like
"Add missing blank lines" as subject, and I would suggest to merge
the 8 watchdog patches into one.

Thanks,
Guenter