* Re: [PATCH] watchdog: Add watchdog driver for OCTEON SOCs (v2).
[not found] ` <1279991765-23962-1-git-send-email-ddaney@caviumnetworks.com>
@ 2010-08-02 12:37 ` Wim Van Sebroeck
2010-08-02 12:57 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Wim Van Sebroeck @ 2010-08-02 12:37 UTC (permalink / raw)
To: David Daney, ralf
Cc: linux-mips, linux-kernel, linux-watchdog, Andrew Morton,
Russell King, Tony Lindgren, Marc Zyngier, Thierry Reding,
Sam Ravnborg
Hi David, Ralf,
> The OCTEON is a MIPS64 based SOC family with an on chip watchdog unit.
>
> The driver is split into two source files one for the C code and one
> for assembly. Assembly is needed to handle the NMI and then print the
> machine state before the reboot is triggered.
>
> v2: Stylistic changes suggested by Sam Ravnborg.
This v2 looks good. only small remark is:
> +static struct notifier_block octeon_wdt_cpu_notifier = {
> + .notifier_call = octeon_wdt_cpu_callback
> +};
Add a comma after octeon_wdt_cpu_callback.
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> Cc: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Marc Zyngier <maz@misterjones.org>
> Cc: Thierry Reding <thierry.reding@avionic-design.de>
> Cc: Sam Ravnborg <sam@ravnborg.org>
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 2+ messages in thread