[PATCH] watchdog: Fix SC1200 dependencies

[PATCH] watchdog: Fix SC1200 dependencies

[Jean Delvare]

The SC1200 is a SoC based on the Geode GX1 32-bit x86 processor, so
its drivers are only needed on this architecture.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Zwane Mwaikambo <zwanem@gmail.com>
Cc: Wim Van Sebroeck <wim@iguana.be>
---
 drivers/watchdog/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-3.14-rc6.orig/drivers/watchdog/Kconfig	2014-02-13 11:25:23.232295332 +0100
+++ linux-3.14-rc6/drivers/watchdog/Kconfig	2014-03-14 15:52:03.391930463 +0100
@@ -736,7 +736,7 @@ config HPWDT_NMI_DECODING
 
 config SC1200_WDT
 	tristate "National Semiconductor PC87307/PC97307 (ala SC1200) Watchdog"
-	depends on X86
+	depends on X86_32
 	help
 	  This is a driver for National Semiconductor PC87307/PC97307 hardware
 	  watchdog cards as found on the SC1200. This watchdog is mainly used


-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] watchdog: Fix SC1200 dependencies

[Guenter Roeck]

On Fri, Mar 14, 2014 at 04:07:28PM +0100, Jean Delvare wrote:
> The SC1200 is a SoC based on the Geode GX1 32-bit x86 processor, so
> its drivers are only needed on this architecture.
> 
The driver is named SC1200, but isn't really SC1200 specific but 
supports the PC87307/PC97307. Not really sure if it is good idea
to remove support for it from 64 bit images. Can we say for sure
that there are no 64 bit systems using this chip ?

Thanks,
Guenter

Re: [PATCH] watchdog: Fix SC1200 dependencies

[Jean Delvare]

Hi Guenter,

Thanks a lot for this review and all the other ones.

On Fri, 14 Mar 2014 11:04:03 -0700, Guenter Roeck wrote:
> On Fri, Mar 14, 2014 at 04:07:28PM +0100, Jean Delvare wrote:
> > The SC1200 is a SoC based on the Geode GX1 32-bit x86 processor, so
> > its drivers are only needed on this architecture.
>
> The driver is named SC1200, but isn't really SC1200 specific but 
> supports the PC87307/PC97307. Not really sure if it is good idea
> to remove support for it from 64 bit images. Can we say for sure
> that there are no 64 bit systems using this chip ?

Grmpf. The driver name is definitely confusing but I'm afraid you're
right. Even more confusing is the existence of an SCx200_WDT driver,
which is supposed to drive the same watchdog but as a PCI device? And
that one does depend on SCx200 which in turn depends on X86_32. I don't
quite get the point of having two drivers for the same device, but I'm
probably missing something.

Anyway, let's just forget about this patch then. Sorry for the noise.

-- 
Jean Delvare
SUSE L3 Support