* [PATCH] watchdog: hpwdt: Fix initialization message in hpwdt.c
@ 2014-10-22 11:24 Masanari Iida
2015-01-13 12:24 ` Guenter Roeck
2015-02-02 23:15 ` [PATCH] " Wim Van Sebroeck
0 siblings, 2 replies; 3+ messages in thread
From: Masanari Iida @ 2014-10-22 11:24 UTC (permalink / raw)
To: wim, thomas.mingarelli, linux-kernel, linux-watchdog; +Cc: Masanari Iida
allow_kdump was enabled as default since following commit.
commit a089361cf5f1d6a5295aa5385238bd044998e1e9,
watchdog: hpwdt: Unregister NMI events on exit.
But the initialization message was not modified.
So it still shows
HP Watchdog Timer Driver: NMI decoding initialized,
allow kernel dump: ON (default = 0/OFF) <=
This "default = 0/OFF" message may confuse users.
Fix it as "default = 1/ON".
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
drivers/watchdog/hpwdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 75d2243..ada3e44 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -745,7 +745,7 @@ static int hpwdt_init_nmi_decoding(struct pci_dev *dev)
dev_info(&dev->dev,
"HP Watchdog Timer Driver: NMI decoding initialized"
- ", allow kernel dump: %s (default = 0/OFF)\n",
+ ", allow kernel dump: %s (default = 1/ON)\n",
(allow_kdump == 0) ? "OFF" : "ON");
return 0;
--
2.1.2.451.g98349e5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: watchdog: hpwdt: Fix initialization message in hpwdt.c
2014-10-22 11:24 [PATCH] watchdog: hpwdt: Fix initialization message in hpwdt.c Masanari Iida
@ 2015-01-13 12:24 ` Guenter Roeck
2015-02-02 23:15 ` [PATCH] " Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2015-01-13 12:24 UTC (permalink / raw)
To: Masanari Iida; +Cc: wim, thomas.mingarelli, linux-kernel, linux-watchdog
On Wed, Oct 22, 2014 at 08:24:35PM +0900, Masanari Iida wrote:
> allow_kdump was enabled as default since following commit.
>
> commit a089361cf5f1d6a5295aa5385238bd044998e1e9,
> watchdog: hpwdt: Unregister NMI events on exit.
>
> But the initialization message was not modified.
> So it still shows
>
> HP Watchdog Timer Driver: NMI decoding initialized,
> allow kernel dump: ON (default = 0/OFF) <=
>
> This "default = 0/OFF" message may confuse users.
> Fix it as "default = 1/ON".
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: hpwdt: Fix initialization message in hpwdt.c
2014-10-22 11:24 [PATCH] watchdog: hpwdt: Fix initialization message in hpwdt.c Masanari Iida
2015-01-13 12:24 ` Guenter Roeck
@ 2015-02-02 23:15 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Wim Van Sebroeck @ 2015-02-02 23:15 UTC (permalink / raw)
To: Masanari Iida; +Cc: thomas.mingarelli, linux-kernel, linux-watchdog
Hi Masanari,
> allow_kdump was enabled as default since following commit.
>
> commit a089361cf5f1d6a5295aa5385238bd044998e1e9,
> watchdog: hpwdt: Unregister NMI events on exit.
>
> But the initialization message was not modified.
> So it still shows
>
> HP Watchdog Timer Driver: NMI decoding initialized,
> allow kernel dump: ON (default = 0/OFF) <=
>
> This "default = 0/OFF" message may confuse users.
> Fix it as "default = 1/ON".
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-02 23:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-22 11:24 [PATCH] watchdog: hpwdt: Fix initialization message in hpwdt.c Masanari Iida
2015-01-13 12:24 ` Guenter Roeck
2015-02-02 23:15 ` [PATCH] " Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox