From: Guenter Roeck <linux@roeck-us.net>
To: James Hogan <james.hogan@imgtec.com>
Cc: Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org, James Hogan <james@albanarts.com>,
Ezequiel Garcia <ezequiel.garcia@imgtec.com>,
Naidu Tellapati <Naidu.Tellapati@imgtec.com>,
Jude Abraham <Jude.Abraham@imgtec.com>
Subject: Re: [PATCH 1/2] watchdog: imgpdc: Fix probe NULL pointer dereference
Date: Mon, 23 Feb 2015 11:26:34 -0800 [thread overview]
Message-ID: <20150223192634.GA26070@roeck-us.net> (raw)
In-Reply-To: <1424475945-30009-2-git-send-email-james.hogan@imgtec.com>
On Fri, Feb 20, 2015 at 11:45:44PM +0000, James Hogan wrote:
> The IMG PDC watchdog probe function calls pdc_wdt_stop() prior to
> watchdog_set_drvdata(), causing a NULL pointer dereference when
> pdc_wdt_stop() retrieves the struct pdc_wdt_dev pointer using
> watchdog_get_drvdata() and reads the register base address through it.
>
> Fix by moving the watchdog_set_drvdata() call earlier, to where various
> other pdc_wdt->wdt_dev fields are initialised.
>
> Fixes: 93937669e9b5 ("watchdog: ImgTec PDC Watchdog Timer Driver")
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> Cc: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
> Cc: Naidu Tellapati <Naidu.Tellapati@imgtec.com>
> Cc: Jude Abraham <Jude.Abraham@imgtec.com>
> Cc: linux-watchdog@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2015-02-23 19:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 23:45 [PATCH 0/2] watchdog: imgpdc: Runtime fixes James Hogan
2015-02-20 23:45 ` [PATCH 1/2] watchdog: imgpdc: Fix probe NULL pointer dereference James Hogan
2015-02-23 19:26 ` Guenter Roeck [this message]
2015-02-20 23:45 ` [PATCH 2/2] watchdog: imgpdc: Fix default heartbeat James Hogan
2015-02-23 19:27 ` Guenter Roeck
2015-03-20 20:53 ` [PATCH 0/2] watchdog: imgpdc: Runtime fixes James Hogan
2015-03-22 17:06 ` Guenter Roeck
2015-03-24 7:42 ` Wim Van Sebroeck
2015-03-24 8:19 ` Wim Van Sebroeck
2015-03-24 8:47 ` Naidu Tellapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223192634.GA26070@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Jude.Abraham@imgtec.com \
--cc=Naidu.Tellapati@imgtec.com \
--cc=ezequiel.garcia@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=james@albanarts.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox