Linux Watchdog driver development
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Wim Van Sebroeck <wim@iguana.be>, <linux-watchdog@vger.kernel.org>
Cc: James Hogan <james@albanarts.com>,
	Ezequiel Garcia <ezequiel.garcia@imgtec.com>,
	Naidu Tellapati <Naidu.Tellapati@imgtec.com>,
	Jude Abraham <Jude.Abraham@imgtec.com>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 0/2] watchdog: imgpdc: Runtime fixes
Date: Fri, 20 Mar 2015 20:53:15 +0000	[thread overview]
Message-ID: <20150320205315.GB22574@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <1424475945-30009-1-git-send-email-james.hogan@imgtec.com>

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

Hi,

On Fri, Feb 20, 2015 at 11:45:43PM +0000, James Hogan wrote:
> A couple of basic runtime fixes for the IMG PDC watchdog driver. These
> were found by attempting to enable the driver for TZ1090 and running
> under Meta QEMU. Note that QEMU doesn't emulate the actual watchdog
> functionality beyond the soft reset register, so I cannot claim to have
> tested the driver's watchdog timer functionality yet.
> 
> James Hogan (2):
>   watchdog: imgpdc: Fix probe NULL pointer dereference
>   watchdog: imgpdc: Fix default heartbeat

Thanks Guenter for the reviews.

Any chance of these fixes getting merged in time for v4.0?

FWIW I've now tried the driver on real TZ1090 hardware (with these
patches) and it appears to work as expected.

Cheers
James

> 
>  drivers/watchdog/imgpdc_wdt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Cc: Wim Van Sebroeck <wim@iguana.be>
> Cc: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
> Cc: Naidu Tellapati <Naidu.Tellapati@imgtec.com>
> Cc: Jude Abraham <Jude.Abraham@imgtec.com>
> Cc: linux-watchdog@vger.kernel.org
> -- 
> 2.0.5
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2015-03-20 20:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20 23:45 [PATCH 0/2] watchdog: imgpdc: Runtime fixes James Hogan
2015-02-20 23:45 ` [PATCH 1/2] watchdog: imgpdc: Fix probe NULL pointer dereference James Hogan
2015-02-23 19:26   ` Guenter Roeck
2015-02-20 23:45 ` [PATCH 2/2] watchdog: imgpdc: Fix default heartbeat James Hogan
2015-02-23 19:27   ` Guenter Roeck
2015-03-20 20:53 ` James Hogan [this message]
2015-03-22 17:06   ` [PATCH 0/2] watchdog: imgpdc: Runtime fixes Guenter Roeck
2015-03-24  7:42     ` Wim Van Sebroeck
2015-03-24  8:19 ` Wim Van Sebroeck
2015-03-24  8:47   ` Naidu Tellapati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150320205315.GB22574@jhogan-linux.le.imgtec.org \
    --to=james.hogan@imgtec.com \
    --cc=Jude.Abraham@imgtec.com \
    --cc=Naidu.Tellapati@imgtec.com \
    --cc=ezequiel.garcia@imgtec.com \
    --cc=james@albanarts.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox