Re: [rtc-linux] [PATCH] watchdog: stmp3xxx: Implement GETBOOTSTATUS

[Alexandre Belloni <alexandre.belloni@free-electrons.com>]

Hi,

On 19/04/2015 at 15:41:42 +0200, harald@ccbib.org wrote :
> >  - use syscon instead of passing callbacks to the watchdog driver
> 
> I will put looking into this onto my todo list, but I'm not familiar
> with syscon yet and it is not obvious to me how to port the rtc driver
> to syscon without breaking devicetree backwards compatibility. So I'd
> like to defer this for later unless somebody gives me some guidance.
> 

As the rtc driver is the one instantiating the watchdog driver, there is
no reason why the DT ABI would be broken. You simply have to create
the syscon in the RTC driver and then pass it to the watchdog driver,
the same way it is done with the callbacks.

I can have a look at doing it as I have some i.mx28 platforms.

> > It would be greatly appreciated if you could do those changes too.
> 
> Is it ok if I send the simple cleanup patch and a rebased version of
> my original patch without the syscon conversion? This will be more work
> for me testing two patch series, but I think GETBOOTSTATUS is an
> important feature that I'd like to see supported soon.
> 

I'm fine with your patch, I was simply suggesting cleanups that should
be sent as separate patches. However, I'd like more people to review the
watchdog part.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com