* [PATCH v2 00/11] Convert DA906{1,2} bindings to json-schema
@ 2023-12-02 19:25 Biju Das
2023-12-02 19:25 ` [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog Biju Das
2023-12-02 19:25 ` [PATCH v2 02/11] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog Biju Das
0 siblings, 2 replies; 8+ messages in thread
From: Biju Das @ 2023-12-02 19:25 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Dmitry Torokhov, Lee Jones,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Biju Das, Steve Twiss, Support Opensource, linux-watchdog,
linux-input, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Lukasz Luba, linux-pm, devicetree, Geert Uytterhoeven,
Prabhakar Mahadev Lad, Biju Das, linux-renesas-soc
Convert the below bindings to json-schema
1) DA906{1,2} mfd bindings
2) DA906{1,2,3} onkey bindings
3) DA906{1,2,3} thermal bindings
Also add fallback for DA9061 watchdog device and document
DA9063 watchdog device.
v1->v2:
Ref : https://lore.kernel.org/all/20231201110840.37408-5-biju.das.jz@bp.renesas.com/
* Made as a separate series
* DA9062 and DA9061 merged with DA9063
* Sorted the child devices
* mfd,onkey and thermal are pointing to child bindings
Biju Das (11):
dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061
watchdog
dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog
dt-bindings: input: Convert da906{1,2,3} onkey to json-schema
dt-bindings: thermal: Convert da906{1,2} thermal to json-schema
dt-bindings: mfd: dlg,da9063: Update watchdog property
dt-bindings: mfd: dlg,da9063: Update onkey property
dt-bindings: mfd: dlg,da9063: Sort child devices
dt-bindings: mfd: da9062: Update watchdog description
dt-bindings: mfd: da9062: Update onkey description
dt-bindings: mfd: da9062: Update thermal description
dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema
.../bindings/input/da9062-onkey.txt | 47 ----
.../bindings/input/dlg,da9062-onkey.yaml | 61 +++++
.../devicetree/bindings/mfd/da9062.txt | 124 ----------
.../devicetree/bindings/mfd/dlg,da9063.yaml | 220 +++++++++++++++---
.../bindings/thermal/da9062-thermal.txt | 36 ---
.../bindings/thermal/dlg,da9062-thermal.yaml | 58 +++++
.../watchdog/dlg,da9062-watchdog.yaml | 12 +-
7 files changed, 313 insertions(+), 245 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/input/da9062-onkey.txt
create mode 100644 Documentation/devicetree/bindings/input/dlg,da9062-onkey.yaml
delete mode 100644 Documentation/devicetree/bindings/mfd/da9062.txt
delete mode 100644 Documentation/devicetree/bindings/thermal/da9062-thermal.txt
create mode 100644 Documentation/devicetree/bindings/thermal/dlg,da9062-thermal.yaml
--
2.39.2
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog
2023-12-02 19:25 [PATCH v2 00/11] Convert DA906{1,2} bindings to json-schema Biju Das
@ 2023-12-02 19:25 ` Biju Das
2023-12-03 11:34 ` Conor Dooley
2023-12-02 19:25 ` [PATCH v2 02/11] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog Biju Das
1 sibling, 1 reply; 8+ messages in thread
From: Biju Das @ 2023-12-02 19:25 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Biju Das, Steve Twiss, linux-watchdog, devicetree,
Geert Uytterhoeven, Prabhakar Mahadev Lad, Biju Das,
linux-renesas-soc
The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes
are required. The fallback compatible string "dlg,da9062-watchdog" will be
used on DA9061 watchdog.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v2:
* New patch
---
.../bindings/watchdog/dlg,da9062-watchdog.yaml | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
index f058628bb632..2b71fdb9251c 100644
--- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
+++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
@@ -14,9 +14,14 @@ allOf:
properties:
compatible:
- enum:
- - dlg,da9061-watchdog
- - dlg,da9062-watchdog
+ oneOf:
+ - items:
+ - enum:
+ - dlg,da9062-watchdog
+ - items:
+ - enum:
+ - dlg,da9061-watchdog
+ - const: dlg,da9062-watchdog # da9062-watchdog fallback
dlg,use-sw-pm:
type: boolean
--
2.39.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog
2023-12-02 19:25 ` [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog Biju Das
@ 2023-12-03 11:34 ` Conor Dooley
2023-12-03 12:52 ` Biju Das
0 siblings, 1 reply; 8+ messages in thread
From: Conor Dooley @ 2023-12-03 11:34 UTC (permalink / raw)
To: Biju Das
Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Steve Twiss, linux-watchdog, devicetree,
Geert Uytterhoeven, Prabhakar Mahadev Lad, Biju Das,
linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]
On Sat, Dec 02, 2023 at 07:25:25PM +0000, Biju Das wrote:
> The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes
> are required. The fallback compatible string "dlg,da9062-watchdog" will be
> used on DA9061 watchdog.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v2:
> * New patch
> ---
> .../bindings/watchdog/dlg,da9062-watchdog.yaml | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> index f058628bb632..2b71fdb9251c 100644
> --- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> @@ -14,9 +14,14 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - dlg,da9061-watchdog
> - - dlg,da9062-watchdog
> + oneOf:
> + - items:
> + - enum:
> + - dlg,da9062-watchdog
> + - items:
> + - enum:
> + - dlg,da9061-watchdog
If there is no da9064 on the horizon, I'd just make this const.
> + - const: dlg,da9062-watchdog # da9062-watchdog fallback
The comment here is just noise IMO.
Otherwise, LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog
2023-12-03 11:34 ` Conor Dooley
@ 2023-12-03 12:52 ` Biju Das
2023-12-04 10:55 ` Biju Das
0 siblings, 1 reply; 8+ messages in thread
From: Biju Das @ 2023-12-03 12:52 UTC (permalink / raw)
To: Conor Dooley
Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Steve Twiss, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org, Geert Uytterhoeven,
Prabhakar Mahadev Lad, biju.das.au,
linux-renesas-soc@vger.kernel.org
Hi Conor Dooley,
Thanks for the feedback.
> Subject: Re: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog:
> Add fallback for DA9061 watchdog
>
> On Sat, Dec 02, 2023 at 07:25:25PM +0000, Biju Das wrote:
> > The DA9061 watchdog is identical to DA9062 watchdog, so no driver
> > changes are required. The fallback compatible string
> > "dlg,da9062-watchdog" will be used on DA9061 watchdog.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v2:
> > * New patch
> > ---
> > .../bindings/watchdog/dlg,da9062-watchdog.yaml | 11 ++++++++---
> > 1 file changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> > b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> > index f058628bb632..2b71fdb9251c 100644
> > ---
> > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.y
> > +++ aml
> > @@ -14,9 +14,14 @@ allOf:
> >
> > properties:
> > compatible:
> > - enum:
> > - - dlg,da9061-watchdog
> > - - dlg,da9062-watchdog
> > + oneOf:
> > + - items:
> > + - enum:
> > + - dlg,da9062-watchdog
> > + - items:
> > + - enum:
> > + - dlg,da9061-watchdog
>
> If there is no da9064 on the horizon, I'd just make this const.
You mean since it is single device having a fallback,
define both device compatible and fallback as const instead of enum and const??
>
> > + - const: dlg,da9062-watchdog # da9062-watchdog fallback
>
> The comment here is just noise IMO.
OK, will change the comment as generic fallback. Is it ok? Or you want to drop completely??
Cheers,
Biju
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog
2023-12-03 12:52 ` Biju Das
@ 2023-12-04 10:55 ` Biju Das
2023-12-04 17:10 ` Conor Dooley
0 siblings, 1 reply; 8+ messages in thread
From: Biju Das @ 2023-12-04 10:55 UTC (permalink / raw)
To: Conor Dooley
Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Steve Twiss, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org, Geert Uytterhoeven,
Prabhakar Mahadev Lad, biju.das.au,
linux-renesas-soc@vger.kernel.org
Hi Conor Dooley,
> Subject: RE: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog:
> Add fallback for DA9061 watchdog
>
> Hi Conor Dooley,
>
> Thanks for the feedback.
>
> > Subject: Re: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-
> watchdog:
> > Add fallback for DA9061 watchdog
> >
> > On Sat, Dec 02, 2023 at 07:25:25PM +0000, Biju Das wrote:
> > > The DA9061 watchdog is identical to DA9062 watchdog, so no driver
> > > changes are required. The fallback compatible string
> > > "dlg,da9062-watchdog" will be used on DA9061 watchdog.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > ---
> > > v2:
> > > * New patch
> > > ---
> > > .../bindings/watchdog/dlg,da9062-watchdog.yaml | 11 ++++++++--
> -
> > > 1 file changed, 8 insertions(+), 3 deletions(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yam
> > > l
> > > b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yam
> > > l index f058628bb632..2b71fdb9251c 100644
> > > ---
> > > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yam
> > > l
> > > +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog
> > > +++ .y
> > > +++ aml
> > > @@ -14,9 +14,14 @@ allOf:
> > >
> > > properties:
> > > compatible:
> > > - enum:
> > > - - dlg,da9061-watchdog
> > > - - dlg,da9062-watchdog
> > > + oneOf:
> > > + - items:
> > > + - enum:
> > > + - dlg,da9062-watchdog
> > > + - items:
> > > + - enum:
> > > + - dlg,da9061-watchdog
> >
> > If there is no da9064 on the horizon, I'd just make this const.
>
> You mean since it is single device having a fallback, define both device
> compatible and fallback as const instead of enum and const??
>
> >
> > > + - const: dlg,da9062-watchdog # da9062-watchdog fallback
> >
> > The comment here is just noise IMO.
Yes it make sense, comment is not needed.
oneOf:
- items:
- enum:
- dlg,da9062-watchdog
- items:
- const: dlg,da9061-watchdog
- const: dlg,da9062-watchdog
Cheers,
Biju
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog
2023-12-04 10:55 ` Biju Das
@ 2023-12-04 17:10 ` Conor Dooley
0 siblings, 0 replies; 8+ messages in thread
From: Conor Dooley @ 2023-12-04 17:10 UTC (permalink / raw)
To: Biju Das
Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Steve Twiss, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org, Geert Uytterhoeven,
Prabhakar Mahadev Lad, biju.das.au,
linux-renesas-soc@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 2458 bytes --]
On Mon, Dec 04, 2023 at 10:55:20AM +0000, Biju Das wrote:
> Hi Conor Dooley,
>
> > Subject: RE: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog:
> > Add fallback for DA9061 watchdog
> >
> > Hi Conor Dooley,
> >
> > Thanks for the feedback.
> >
> > > Subject: Re: [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-
> > watchdog:
> > > Add fallback for DA9061 watchdog
> > >
> > > On Sat, Dec 02, 2023 at 07:25:25PM +0000, Biju Das wrote:
> > > > The DA9061 watchdog is identical to DA9062 watchdog, so no driver
> > > > changes are required. The fallback compatible string
> > > > "dlg,da9062-watchdog" will be used on DA9061 watchdog.
> > > >
> > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > > ---
> > > > v2:
> > > > * New patch
> > > > ---
> > > > .../bindings/watchdog/dlg,da9062-watchdog.yaml | 11 ++++++++--
> > -
> > > > 1 file changed, 8 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yam
> > > > l
> > > > b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yam
> > > > l index f058628bb632..2b71fdb9251c 100644
> > > > ---
> > > > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yam
> > > > l
> > > > +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog
> > > > +++ .y
> > > > +++ aml
> > > > @@ -14,9 +14,14 @@ allOf:
> > > >
> > > > properties:
> > > > compatible:
> > > > - enum:
> > > > - - dlg,da9061-watchdog
> > > > - - dlg,da9062-watchdog
> > > > + oneOf:
> > > > + - items:
> > > > + - enum:
> > > > + - dlg,da9062-watchdog
> > > > + - items:
> > > > + - enum:
> > > > + - dlg,da9061-watchdog
> > >
> > > If there is no da9064 on the horizon, I'd just make this const.
> >
> > You mean since it is single device having a fallback, define both device
> > compatible and fallback as const instead of enum and const??
> >
> > >
> > > > + - const: dlg,da9062-watchdog # da9062-watchdog fallback
> > >
> > > The comment here is just noise IMO.
>
> Yes it make sense, comment is not needed.
>
> oneOf:
> - items:
> - enum:
> - dlg,da9062-watchdog
> - items:
> - const: dlg,da9061-watchdog
> - const: dlg,da9062-watchdog
Ye, this looks good. Thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 02/11] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog
2023-12-02 19:25 [PATCH v2 00/11] Convert DA906{1,2} bindings to json-schema Biju Das
2023-12-02 19:25 ` [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog Biju Das
@ 2023-12-02 19:25 ` Biju Das
2023-12-03 11:34 ` Conor Dooley
1 sibling, 1 reply; 8+ messages in thread
From: Biju Das @ 2023-12-02 19:25 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Biju Das, Steve Twiss, linux-watchdog, devicetree,
Geert Uytterhoeven, Prabhakar Mahadev Lad, Biju Das,
linux-renesas-soc
Document DA9063 watchdog device as it is similar to DA9062 watchdog.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v2:
* New patch
---
.../devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
index 2b71fdb9251c..ccec4d3e62f5 100644
--- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
+++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
@@ -18,6 +18,7 @@ properties:
- items:
- enum:
- dlg,da9062-watchdog
+ - dlg,da9063-watchdog
- items:
- enum:
- dlg,da9061-watchdog
--
2.39.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 02/11] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog
2023-12-02 19:25 ` [PATCH v2 02/11] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog Biju Das
@ 2023-12-03 11:34 ` Conor Dooley
0 siblings, 0 replies; 8+ messages in thread
From: Conor Dooley @ 2023-12-03 11:34 UTC (permalink / raw)
To: Biju Das
Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Steve Twiss, linux-watchdog, devicetree,
Geert Uytterhoeven, Prabhakar Mahadev Lad, Biju Das,
linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
On Sat, Dec 02, 2023 at 07:25:26PM +0000, Biju Das wrote:
> Document DA9063 watchdog device as it is similar to DA9062 watchdog.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
> v2:
> * New patch
> ---
> .../devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> index 2b71fdb9251c..ccec4d3e62f5 100644
> --- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> @@ -18,6 +18,7 @@ properties:
> - items:
> - enum:
> - dlg,da9062-watchdog
> + - dlg,da9063-watchdog
> - items:
> - enum:
> - dlg,da9061-watchdog
> --
> 2.39.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-12-04 17:10 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-02 19:25 [PATCH v2 00/11] Convert DA906{1,2} bindings to json-schema Biju Das
2023-12-02 19:25 ` [PATCH v2 01/11] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog Biju Das
2023-12-03 11:34 ` Conor Dooley
2023-12-03 12:52 ` Biju Das
2023-12-04 10:55 ` Biju Das
2023-12-04 17:10 ` Conor Dooley
2023-12-02 19:25 ` [PATCH v2 02/11] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog Biju Das
2023-12-03 11:34 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox