[PATCH v3.1 2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog

[PATCH v3.1 2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog

[Biju Das]

The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes
are required. The fallback compatible string "dlg,da9062-watchdog" will be
used on DA9061 watchdog.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v3->v3.1:
 * Dropped comment for d9061 watchdog fallback.
 * Replaced enum->const for dlg,da9061-watchdog and its fallback.
v2->v3:
 * No change
v2:
 * New patch
---
 .../bindings/watchdog/dlg,da9062-watchdog.yaml         | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
index f058628bb632..7c63b99dac85 100644
--- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
+++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
@@ -14,9 +14,13 @@ allOf:
 
 properties:
   compatible:
-    enum: 
-      - dlg,da9061-watchdog
-      - dlg,da9062-watchdog
+    oneOf:
+      - items:
+          - enum:
+              - dlg,da9062-watchdog
+      - items:
+          - const: dlg,da9061-watchdog
+          - const: dlg,da9062-watchdog
 
   dlg,use-sw-pm:
     type: boolean
-- 
2.39.2

Re: [PATCH v3.1 2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog

[Geert Uytterhoeven]

On Mon, Dec 4, 2023 at 6:25 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes
> are required. The fallback compatible string "dlg,da9062-watchdog" will be
> used on DA9061 watchdog.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v3->v3.1:
>  * Dropped comment for d9061 watchdog fallback.
>  * Replaced enum->const for dlg,da9061-watchdog and its fallback.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3.1 2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

On Mon, Dec 04, 2023 at 05:25:04PM +0000, Biju Das wrote:
> The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes
> are required. The fallback compatible string "dlg,da9062-watchdog" will be
> used on DA9061 watchdog.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3.1 2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog

[Guenter Roeck]

On Mon, Dec 04, 2023 at 05:25:04PM +0000, Biju Das wrote:
> The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes
> are required. The fallback compatible string "dlg,da9062-watchdog" will be
> used on DA9061 watchdog.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> v3->v3.1:
>  * Dropped comment for d9061 watchdog fallback.
>  * Replaced enum->const for dlg,da9061-watchdog and its fallback.
> v2->v3:
>  * No change
> v2:
>  * New patch
> ---
>  .../bindings/watchdog/dlg,da9062-watchdog.yaml         | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> index f058628bb632..7c63b99dac85 100644
> --- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> @@ -14,9 +14,13 @@ allOf:
>  
>  properties:
>    compatible:
> -    enum: 
> -      - dlg,da9061-watchdog
> -      - dlg,da9062-watchdog
> +    oneOf:
> +      - items:
> +          - enum:
> +              - dlg,da9062-watchdog
> +      - items:
> +          - const: dlg,da9061-watchdog
> +          - const: dlg,da9062-watchdog
>  
>    dlg,use-sw-pm:
>      type: boolean
> -- 
> 2.39.2
> 

Re: [PATCH v3.1 2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

On Tue, Dec 12, 2023 at 08:56:00AM -0800, Guenter Roeck wrote:
> On Mon, Dec 04, 2023 at 05:25:04PM +0000, Biju Das wrote:
> > The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes
> > are required. The fallback compatible string "dlg,da9062-watchdog" will be
> > used on DA9061 watchdog.
> > 
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

There's a v5 of this series already FYI

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3.1 2/8] dt-bindings: watchdog: dlg,da9062-watchdog: Add fallback for DA9061 watchdog

[Guenter Roeck]

On Tue, Dec 12, 2023 at 05:08:45PM +0000, Conor Dooley wrote:
> On Tue, Dec 12, 2023 at 08:56:00AM -0800, Guenter Roeck wrote:
> > On Mon, Dec 04, 2023 at 05:25:04PM +0000, Biju Das wrote:
> > > The DA9061 watchdog is identical to DA9062 watchdog, so no driver changes
> > > are required. The fallback compatible string "dlg,da9062-watchdog" will be
> > > used on DA9061 watchdog.
> > > 
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > 
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> There's a v5 of this series already FYI

Yes, I noticed too late. Sorry. Happens if one is way backlogged
with reviews.

Guenter

[PATCH v3.1 3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog

[Biju Das]

Document DA9063 watchdog device as it is similar to DA9062 watchdog.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
v3->v3.1:
 * Added Ack from Conor Dooley.
 * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063.
 * Retained Rb tag since the changes are trivial.
v2->v3:
 * No change
v2:
 * New patch
---
 .../devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
index 7c63b99dac85..d2088e308b45 100644
--- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
+++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
@@ -4,7 +4,7 @@
 $id: http://devicetree.org/schemas/watchdog/dlg,da9062-watchdog.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Dialog Semiconductor DA9062/61 Watchdog Timer
+title: Dialog Semiconductor DA906{1,2,3} Watchdog Timer
 
 maintainers:
   - Steve Twiss <stwiss.opensource@diasemi.com>
@@ -18,6 +18,7 @@ properties:
       - items:
           - enum:
               - dlg,da9062-watchdog
+              - dlg,da9063-watchdog
       - items:
           - const: dlg,da9061-watchdog
           - const: dlg,da9062-watchdog
-- 
2.39.2

Re: [PATCH v3.1 3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog

[Geert Uytterhoeven]

Hi Biju,

On Mon, Dec 4, 2023 at 6:25 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Document DA9063 watchdog device as it is similar to DA9062 watchdog.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> v3->v3.1:
>  * Added Ack from Conor Dooley.
>  * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063.
>  * Retained Rb tag since the changes are trivial.

Thanks for the update!

> --- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml

> @@ -18,6 +18,7 @@ properties:
>        - items:
>            - enum:
>                - dlg,da9062-watchdog
> +              - dlg,da9063-watchdog
>        - items:
>            - const: dlg,da9061-watchdog
>            - const: dlg,da9062-watchdog

This matches the existing usage in DT, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

However, I believe we do have a runtime issue here, as the driver
currently matches against dlg,da9062-watchdog only, so the watchdog
must be non-functional on DA9063?

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH v3.1 3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog

[Biju Das]

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: Tuesday, December 5, 2023 8:47 AM
> Subject: Re: [PATCH v3.1 3/8] dt-bindings: watchdog: dlg,da9062-watchdog:
> Document DA9063 watchdog
> 
> Hi Biju,
> 
> On Mon, Dec 4, 2023 at 6:25 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > Document DA9063 watchdog device as it is similar to DA9062 watchdog.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > ---
> > v3->v3.1:
> >  * Added Ack from Conor Dooley.
> >  * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063.
> >  * Retained Rb tag since the changes are trivial.
> 
> Thanks for the update!
> 
> > ---
> > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.y
> > +++ aml
> 
> > @@ -18,6 +18,7 @@ properties:
> >        - items:
> >            - enum:
> >                - dlg,da9062-watchdog
> > +              - dlg,da9063-watchdog
> >        - items:
> >            - const: dlg,da9061-watchdog
> >            - const: dlg,da9062-watchdog
> 
> This matches the existing usage in DT, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> However, I believe we do have a runtime issue here, as the driver
> currently matches against dlg,da9062-watchdog only, so the watchdog must
> be non-functional on DA9063?

Of_compatible is defined in [1], but the corresponding driver[2] is missing the compatible
[1]
drivers/mfd/da9063-core.c:		.of_compatible	= "dlg,da9063-watchdog",

[2]
drivers/watchdog/da9063_wdt.c

Not sure of_compaible in MFD will instantiate driver [2] or not?

Cheers,
Biju