Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-renesas-soc@vger.kernel.org
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Jean-Marie Verdun <verdun@hpe.com>,
	linux-watchdog@vger.kernel.org, Michael Walle <mwalle@kernel.org>,
	Nick Hawkins <nick.hawkins@hpe.com>,
	Support Opensource <support.opensource@diasemi.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>
Subject: [RFC PATCH 0/9] watchdog: don't print out if registering watchdog fails
Date: Fri,  4 Oct 2024 22:03:03 +0200	[thread overview]
Message-ID: <20241004200314.5459-1-wsa+renesas@sang-engineering.com> (raw)

While working with the rza-driver, I noticed that the watchdog core does
not always print out errors when registering a watchdog fails. Only most
of the time. With a simple refactoring, it will always print out. We can
remove similar printouts then from drivers. This series does exactly
that. Not sure about the core change, thus still RFC. There are two more
drivers outside the 'watchdog' dir which could benefit from this change,
but I left them out for now until I know this path is acceptable.

Looking forward to comments...


Wolfram Sang (9):
  watchdog: always print when registering watchdog fails
  watchdog: da9055_wdt: don't print out if registering watchdog fails
  watchdog: hpe-wdt: don't print out if registering watchdog fails
  watchdog: iTCO_wdt: don't print out if registering watchdog fails
  watchdog: it87_wdt: don't print out if registering watchdog fails
  watchdog: octeon-wdt: don't print out if registering watchdog fails
  watchdog: rti_wdt: don't print out if registering watchdog fails
  watchdog: rza_wdt: don't print out if registering watchdog fails
  watchdog: sl28cpld_wdt: don't print out if registering watchdog fails

 drivers/watchdog/da9055_wdt.c      |  7 +------
 drivers/watchdog/gxp-wdt.c         |  4 +---
 drivers/watchdog/iTCO_wdt.c        |  4 +---
 drivers/watchdog/it87_wdt.c        |  4 +---
 drivers/watchdog/octeon-wdt-main.c |  4 +---
 drivers/watchdog/rti_wdt.c         |  4 +---
 drivers/watchdog/rza_wdt.c         |  7 +------
 drivers/watchdog/sl28cpld_wdt.c    |  4 +---
 drivers/watchdog/watchdog_core.c   | 26 +++++++++++++++++---------
 9 files changed, 25 insertions(+), 39 deletions(-)

-- 
2.45.2


             reply	other threads:[~2024-10-04 20:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 20:03 Wolfram Sang [this message]
2024-10-04 20:03 ` [RFC PATCH 1/9] watchdog: always print when registering watchdog fails Wolfram Sang
2024-10-04 20:52   ` Guenter Roeck
2024-10-04 20:03 ` [RFC PATCH 2/9] watchdog: da9055_wdt: don't print out if " Wolfram Sang
2024-10-04 20:53   ` Guenter Roeck
2024-10-04 20:03 ` [RFC PATCH 3/9] watchdog: hpe-wdt: " Wolfram Sang
2024-10-04 20:53   ` Guenter Roeck
2024-10-04 21:29   ` Jerry Hoemann
2024-10-05  5:23     ` Wolfram Sang
2024-10-06 16:10       ` Jerry Hoemann
2024-10-04 20:03 ` [RFC PATCH 4/9] watchdog: iTCO_wdt: " Wolfram Sang
2024-10-04 20:53   ` Guenter Roeck
2024-10-04 20:03 ` [RFC PATCH 5/9] watchdog: it87_wdt: " Wolfram Sang
2024-10-04 20:53   ` Guenter Roeck
2024-10-04 20:03 ` [RFC PATCH 6/9] watchdog: octeon-wdt: " Wolfram Sang
2024-10-04 20:54   ` Guenter Roeck
2024-10-04 20:03 ` [RFC PATCH 7/9] watchdog: rti_wdt: " Wolfram Sang
2024-10-04 20:54   ` Guenter Roeck
2024-10-04 20:03 ` [RFC PATCH 8/9] watchdog: rza_wdt: " Wolfram Sang
2024-10-04 20:03 ` [RFC PATCH 9/9] watchdog: sl28cpld_wdt: " Wolfram Sang
2024-10-04 20:54   ` Guenter Roeck
2024-10-05 11:19   ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241004200314.5459-1-wsa+renesas@sang-engineering.com \
    --to=wsa+renesas@sang-engineering.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mwalle@kernel.org \
    --cc=nick.hawkins@hpe.com \
    --cc=support.opensource@diasemi.com \
    --cc=verdun@hpe.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox