Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-renesas-soc@vger.kernel.org
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-watchdog@vger.kernel.org
Subject: [RFC PATCH 8/9] watchdog: rza_wdt: don't print out if registering watchdog fails
Date: Fri,  4 Oct 2024 22:03:11 +0200	[thread overview]
Message-ID: <20241004200314.5459-9-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20241004200314.5459-1-wsa+renesas@sang-engineering.com>

The core will do this already.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/watchdog/rza_wdt.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/watchdog/rza_wdt.c b/drivers/watchdog/rza_wdt.c
index cb4901b3f777..9334255a37e9 100644
--- a/drivers/watchdog/rza_wdt.c
+++ b/drivers/watchdog/rza_wdt.c
@@ -169,7 +169,6 @@ static int rza_wdt_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct rza_wdt *priv;
 	unsigned long rate;
-	int ret;
 
 	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
@@ -218,11 +217,7 @@ static int rza_wdt_probe(struct platform_device *pdev)
 	watchdog_init_timeout(&priv->wdev, 0, dev);
 	watchdog_set_drvdata(&priv->wdev, priv);
 
-	ret = devm_watchdog_register_device(dev, &priv->wdev);
-	if (ret)
-		dev_err(dev, "Cannot register watchdog device\n");
-
-	return ret;
+	return devm_watchdog_register_device(dev, &priv->wdev);
 }
 
 static const struct of_device_id rza_wdt_of_match[] = {
-- 
2.45.2


  parent reply	other threads:[~2024-10-04 20:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 20:03 [RFC PATCH 0/9] watchdog: don't print out if registering watchdog fails Wolfram Sang
2024-10-04 20:03 ` [RFC PATCH 1/9] watchdog: always print when " Wolfram Sang
2024-10-04 20:52   ` Guenter Roeck
2024-10-04 20:03 ` [RFC PATCH 2/9] watchdog: da9055_wdt: don't print out if " Wolfram Sang
2024-10-04 20:53   ` Guenter Roeck
2024-10-04 20:03 ` [RFC PATCH 3/9] watchdog: hpe-wdt: " Wolfram Sang
2024-10-04 20:53   ` Guenter Roeck
2024-10-04 21:29   ` Jerry Hoemann
2024-10-05  5:23     ` Wolfram Sang
2024-10-06 16:10       ` Jerry Hoemann
2024-10-04 20:03 ` [RFC PATCH 4/9] watchdog: iTCO_wdt: " Wolfram Sang
2024-10-04 20:53   ` Guenter Roeck
2024-10-04 20:03 ` [RFC PATCH 5/9] watchdog: it87_wdt: " Wolfram Sang
2024-10-04 20:53   ` Guenter Roeck
2024-10-04 20:03 ` [RFC PATCH 6/9] watchdog: octeon-wdt: " Wolfram Sang
2024-10-04 20:54   ` Guenter Roeck
2024-10-04 20:03 ` [RFC PATCH 7/9] watchdog: rti_wdt: " Wolfram Sang
2024-10-04 20:54   ` Guenter Roeck
2024-10-04 20:03 ` Wolfram Sang [this message]
2024-10-04 20:03 ` [RFC PATCH 9/9] watchdog: sl28cpld_wdt: " Wolfram Sang
2024-10-04 20:54   ` Guenter Roeck
2024-10-05 11:19   ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241004200314.5459-9-wsa+renesas@sang-engineering.com \
    --to=wsa+renesas@sang-engineering.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox