* [PATCH 00/14] arm64: dts: allwinner: Add basic Allwinner A523 support
@ 2024-11-11 1:30 Andre Przywara
2024-11-11 1:30 ` [PATCH 03/14] dt-bindings: watchdog: sunxi: add Allwinner A523 compatible string Andre Przywara
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Andre Przywara @ 2024-11-11 1:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland
Cc: devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
Ulf Hansson, linux-mmc, Wim Van Sebroeck, Guenter Roeck,
linux-watchdog, Gregory CLEMENT, Andi Shyti, linux-i2c,
Thomas Gleixner, Vinod Koul, Kishon Vijay Abraham I, linux-phy,
Greg Kroah-Hartman, linux-usb, Alexandre Belloni, linux-rtc
Hi,
this series adds basic DT support for the Allwinner A523 SoC, plus the
Avaota-A1 router board using the T527 package variant of that SoC.[1]
Functionality-wise it relies on the pinctrl[2] and clock[3] support
series, though there is no direct code dependency series to this series
(apart from the respective binding patches in the two series').
Most of the patches add DT binding documentation for the most basic
peripherals, the vast majority of them actually being already supported,
courtesy of identical IP being used. This includes MMC and USB 2.0, so
with the above mentioned clock and pinctrl support this gives an already
somewhat usable mainline support for this new SoC family.
The watchdog is not completely compatible, but is an easy addition, so
this bit is included in here as well.
The A523 features 8 Arm Cortex-A55 cores, organised in two clusters,
clocked separately, with different OPP limits, in some kind of
little/LITTLE configuration. The GPU is a Arm Mali G57 MC01, and the chip
also features a single PCIe 2.1 lane, sharing a PHY with some USB 3.1
controller - which means only one of the two can be used.
The rest of the SoC is the usual soup of multimedia SoC IP, with eDP
support and two Gigabit Ethernet MACs among the highlights.
The main feature is patch 11/14, which adds the SoC .dtsi. This for now
is limited to the parts that are supported and could be tested. At the
moment there is no PSCI firmware, even the TF-A port from the BSP does
not seem to work for me. That's why the secondary cores have been omitted
for now, among other instances of some IP that I couldn't test yet.
I plan to add them in one of the next revisions.
The last patch adds basic support for the Avaota-A1 router board,
designed by YuzukiHD, with some boards now built by Pine64.
The mainline firmware side in general is somewhat lacking still: I have
basic U-Boot support working (including MMC and USB), although still
without DRAM support. This is for now covered by some binary blob found
in the (otherwise Open Source) Syterkit firmware, which also provides
the BSP versions of TF-A and the required (RISC-V) management core
firmware. Fortunately we have indications that DRAM support is not that
tricky, as the IP blocks are very similar to already supported, and dev
boards are on their way to the right people.
Meanwhile I would like people to have a look at those DT bits here. Please
compare them to the available user manual, and test them if you have access
to hardware.
Based on v6.12-rc1.
I pushed a branch with all the three series combined here:
https://github.com/apritzel/linux/commits/a523-v1/
Cheers,
Andre
[1] https://linux-sunxi.org/A523#Family_of_sun55iw3
[2] https://lore.kernel.org/linux-sunxi/20241111005750.13071-1-andre.przywara@arm.com/T/#t
[3] https://lore.kernel.org/linux-sunxi/20241111004722.10130-1-andre.przywara@arm.com/T/#t
Andre Przywara (14):
dt-bindings: mmc: sunxi: Simplify compatible string listing
dt-bindings: mmc: sunxi: add compatible strings for Allwinner A523
dt-bindings: watchdog: sunxi: add Allwinner A523 compatible string
watchdog: sunxi_wdt: Add support for Allwinner A523
dt-bindings: i2c: mv64xxx: Add Allwinner A523 compatible string
dt-bindings: irq: sun7i-nmi: document the Allwinner A523 NMI
controller
dt-bindings: phy: document Allwinner A523 USB-2.0 PHY
dt-bindings: usb: sunxi-musb: add Allwinner A523 compatible string
dt-bindings: usb: add A523 compatible string for EHCI and OCHI
dt-bindings: rtc: sun6i: Add Allwinner A523 support
arm64: dts: allwinner: Add Allwinner A523 .dtsi file
dt-bindings: vendor-prefixes: Add YuzukiHD name
dt-bindings: arm: sunxi: Add Avaota A1 board
arm64: dts: allwinner: a523: add Avaota-A1 router support
.../devicetree/bindings/arm/sunxi.yaml | 5 +
.../bindings/i2c/marvell,mv64xxx-i2c.yaml | 1 +
.../allwinner,sun7i-a20-sc-nmi.yaml | 1 +
.../bindings/mmc/allwinner,sun4i-a10-mmc.yaml | 40 +-
.../phy/allwinner,sun50i-a64-usb-phy.yaml | 10 +-
.../bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 4 +-
.../usb/allwinner,sun4i-a10-musb.yaml | 1 +
.../devicetree/bindings/usb/generic-ehci.yaml | 1 +
.../devicetree/bindings/usb/generic-ohci.yaml | 1 +
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
.../watchdog/allwinner,sun4i-a10-wdt.yaml | 2 +
arch/arm64/boot/dts/allwinner/Makefile | 1 +
.../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 386 ++++++++++++++++++
.../dts/allwinner/sun55i-t527-avaota-a1.dts | 311 ++++++++++++++
drivers/watchdog/sunxi_wdt.c | 11 +
15 files changed, 751 insertions(+), 26 deletions(-)
create mode 100644 arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
create mode 100644 arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts
--
2.46.2
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 03/14] dt-bindings: watchdog: sunxi: add Allwinner A523 compatible string 2024-11-11 1:30 [PATCH 00/14] arm64: dts: allwinner: Add basic Allwinner A523 support Andre Przywara @ 2024-11-11 1:30 ` Andre Przywara 2024-11-11 20:35 ` Conor Dooley 2025-01-18 11:47 ` Jernej Škrabec 2024-11-11 1:30 ` [PATCH 04/14] watchdog: sunxi_wdt: Add support for Allwinner A523 Andre Przywara 2024-11-11 15:32 ` [PATCH 00/14] arm64: dts: allwinner: Add basic Allwinner A523 support Rob Herring (Arm) 2 siblings, 2 replies; 8+ messages in thread From: Andre Przywara @ 2024-11-11 1:30 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Wim Van Sebroeck, Guenter Roeck Cc: devicetree, linux-arm-kernel, linux-sunxi, linux-kernel, linux-watchdog The Allwinner A523 SoC features a watchdog similar to the one used in previous SoCs, but moves some registers around (by just one word), making it incompatible to existing IPs. Add the new name to the list of compatible string, and also to the list of IP requiring two clock inputs. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- .../devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml index 64c8f73938099..b35ac03d51727 100644 --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml @@ -32,6 +32,7 @@ properties: - items: - const: allwinner,sun20i-d1-wdt-reset - const: allwinner,sun20i-d1-wdt + - const: allwinner,sun55i-a523-wdt reg: maxItems: 1 @@ -60,6 +61,7 @@ if: - allwinner,sun20i-d1-wdt-reset - allwinner,sun50i-r329-wdt - allwinner,sun50i-r329-wdt-reset + - allwinner,sun55i-a523-wdt then: properties: -- 2.46.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 03/14] dt-bindings: watchdog: sunxi: add Allwinner A523 compatible string 2024-11-11 1:30 ` [PATCH 03/14] dt-bindings: watchdog: sunxi: add Allwinner A523 compatible string Andre Przywara @ 2024-11-11 20:35 ` Conor Dooley 2025-01-18 11:47 ` Jernej Škrabec 1 sibling, 0 replies; 8+ messages in thread From: Conor Dooley @ 2024-11-11 20:35 UTC (permalink / raw) To: Andre Przywara Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Wim Van Sebroeck, Guenter Roeck, devicetree, linux-arm-kernel, linux-sunxi, linux-kernel, linux-watchdog [-- Attachment #1: Type: text/plain, Size: 484 bytes --] On Mon, Nov 11, 2024 at 01:30:22AM +0000, Andre Przywara wrote: > The Allwinner A523 SoC features a watchdog similar to the one used in > previous SoCs, but moves some registers around (by just one word), making > it incompatible to existing IPs. > > Add the new name to the list of compatible string, and also to the list > of IP requiring two clock inputs. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 03/14] dt-bindings: watchdog: sunxi: add Allwinner A523 compatible string 2024-11-11 1:30 ` [PATCH 03/14] dt-bindings: watchdog: sunxi: add Allwinner A523 compatible string Andre Przywara 2024-11-11 20:35 ` Conor Dooley @ 2025-01-18 11:47 ` Jernej Škrabec 1 sibling, 0 replies; 8+ messages in thread From: Jernej Škrabec @ 2025-01-18 11:47 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai, Samuel Holland, Wim Van Sebroeck, Guenter Roeck, Andre Przywara Cc: devicetree, linux-arm-kernel, linux-sunxi, linux-kernel, linux-watchdog Dne ponedeljek, 11. november 2024 ob 02:30:22 Srednjeevropski standardni čas je Andre Przywara napisal(a): > The Allwinner A523 SoC features a watchdog similar to the one used in > previous SoCs, but moves some registers around (by just one word), making > it incompatible to existing IPs. > > Add the new name to the list of compatible string, and also to the list > of IP requiring two clock inputs. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > --- > .../devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > index 64c8f73938099..b35ac03d51727 100644 > --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > @@ -32,6 +32,7 @@ properties: > - items: > - const: allwinner,sun20i-d1-wdt-reset > - const: allwinner,sun20i-d1-wdt > + - const: allwinner,sun55i-a523-wdt > > reg: > maxItems: 1 > @@ -60,6 +61,7 @@ if: > - allwinner,sun20i-d1-wdt-reset > - allwinner,sun50i-r329-wdt > - allwinner,sun50i-r329-wdt-reset > + - allwinner,sun55i-a523-wdt > > then: > properties: > ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 04/14] watchdog: sunxi_wdt: Add support for Allwinner A523 2024-11-11 1:30 [PATCH 00/14] arm64: dts: allwinner: Add basic Allwinner A523 support Andre Przywara 2024-11-11 1:30 ` [PATCH 03/14] dt-bindings: watchdog: sunxi: add Allwinner A523 compatible string Andre Przywara @ 2024-11-11 1:30 ` Andre Przywara 2025-01-18 11:45 ` Jernej Škrabec 2024-11-11 15:32 ` [PATCH 00/14] arm64: dts: allwinner: Add basic Allwinner A523 support Rob Herring (Arm) 2 siblings, 1 reply; 8+ messages in thread From: Andre Przywara @ 2024-11-11 1:30 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Wim Van Sebroeck, Guenter Roeck Cc: devicetree, linux-arm-kernel, linux-sunxi, linux-kernel, linux-watchdog The Allwinner A523 SoC comes with a watchdog very similar to the ones in the previous Allwinner SoCs, but oddly enough moves the first half of its registers up by one word. Since we have different offsets for these registers across the other SoCs as well, this can simply be modelled by just stating the new offsets in our per-SoC struct. The rest of the IP is the same as in the D1, although the A523 moves its watchdog to a separate MMIO frame, so it's not embedded in the timer anymore. The driver can be ignorant of this, because the DT will take care of this. Add a new struct for the A523, specifying the SoC-specific details, and tie the new DT compatible string to it. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- drivers/watchdog/sunxi_wdt.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/watchdog/sunxi_wdt.c b/drivers/watchdog/sunxi_wdt.c index b85354a995826..b6c761acc3de6 100644 --- a/drivers/watchdog/sunxi_wdt.c +++ b/drivers/watchdog/sunxi_wdt.c @@ -236,10 +236,21 @@ static const struct sunxi_wdt_reg sun20i_wdt_reg = { .wdt_key_val = 0x16aa0000, }; +static const struct sunxi_wdt_reg sun55i_wdt_reg = { + .wdt_ctrl = 0x0c, + .wdt_cfg = 0x10, + .wdt_mode = 0x14, + .wdt_timeout_shift = 4, + .wdt_reset_mask = 0x03, + .wdt_reset_val = 0x01, + .wdt_key_val = 0x16aa0000, +}; + static const struct of_device_id sunxi_wdt_dt_ids[] = { { .compatible = "allwinner,sun4i-a10-wdt", .data = &sun4i_wdt_reg }, { .compatible = "allwinner,sun6i-a31-wdt", .data = &sun6i_wdt_reg }, { .compatible = "allwinner,sun20i-d1-wdt", .data = &sun20i_wdt_reg }, + { .compatible = "allwinner,sun55i-a523-wdt", .data = &sun55i_wdt_reg }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, sunxi_wdt_dt_ids); -- 2.46.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 04/14] watchdog: sunxi_wdt: Add support for Allwinner A523 2024-11-11 1:30 ` [PATCH 04/14] watchdog: sunxi_wdt: Add support for Allwinner A523 Andre Przywara @ 2025-01-18 11:45 ` Jernej Škrabec 0 siblings, 0 replies; 8+ messages in thread From: Jernej Škrabec @ 2025-01-18 11:45 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai, Samuel Holland, Wim Van Sebroeck, Guenter Roeck, Andre Przywara Cc: devicetree, linux-arm-kernel, linux-sunxi, linux-kernel, linux-watchdog Dne ponedeljek, 11. november 2024 ob 02:30:23 Srednjeevropski standardni čas je Andre Przywara napisal(a): > The Allwinner A523 SoC comes with a watchdog very similar to the ones in > the previous Allwinner SoCs, but oddly enough moves the first half of its > registers up by one word. Since we have different offsets for these > registers across the other SoCs as well, this can simply be modelled by > just stating the new offsets in our per-SoC struct. > The rest of the IP is the same as in the D1, although the A523 moves its > watchdog to a separate MMIO frame, so it's not embedded in the timer > anymore. The driver can be ignorant of this, because the DT will take > care of this. > > Add a new struct for the A523, specifying the SoC-specific details, and > tie the new DT compatible string to it. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/14] arm64: dts: allwinner: Add basic Allwinner A523 support 2024-11-11 1:30 [PATCH 00/14] arm64: dts: allwinner: Add basic Allwinner A523 support Andre Przywara 2024-11-11 1:30 ` [PATCH 03/14] dt-bindings: watchdog: sunxi: add Allwinner A523 compatible string Andre Przywara 2024-11-11 1:30 ` [PATCH 04/14] watchdog: sunxi_wdt: Add support for Allwinner A523 Andre Przywara @ 2024-11-11 15:32 ` Rob Herring (Arm) 2024-11-11 17:42 ` Andre Przywara 2 siblings, 1 reply; 8+ messages in thread From: Rob Herring (Arm) @ 2024-11-11 15:32 UTC (permalink / raw) To: Andre Przywara Cc: Krzysztof Kozlowski, linux-phy, linux-mmc, Gregory CLEMENT, Alexandre Belloni, Wim Van Sebroeck, Greg Kroah-Hartman, devicetree, linux-rtc, linux-kernel, linux-sunxi, linux-arm-kernel, linux-i2c, Andi Shyti, Vinod Koul, linux-watchdog, Thomas Gleixner, Chen-Yu Tsai, Samuel Holland, Ulf Hansson, linux-usb, Jernej Skrabec, Guenter Roeck, Conor Dooley, Kishon Vijay Abraham I On Mon, 11 Nov 2024 01:30:19 +0000, Andre Przywara wrote: > Hi, > > this series adds basic DT support for the Allwinner A523 SoC, plus the > Avaota-A1 router board using the T527 package variant of that SoC.[1] > Functionality-wise it relies on the pinctrl[2] and clock[3] support > series, though there is no direct code dependency series to this series > (apart from the respective binding patches in the two series'). > > Most of the patches add DT binding documentation for the most basic > peripherals, the vast majority of them actually being already supported, > courtesy of identical IP being used. This includes MMC and USB 2.0, so > with the above mentioned clock and pinctrl support this gives an already > somewhat usable mainline support for this new SoC family. > The watchdog is not completely compatible, but is an easy addition, so > this bit is included in here as well. > > The A523 features 8 Arm Cortex-A55 cores, organised in two clusters, > clocked separately, with different OPP limits, in some kind of > little/LITTLE configuration. The GPU is a Arm Mali G57 MC01, and the chip > also features a single PCIe 2.1 lane, sharing a PHY with some USB 3.1 > controller - which means only one of the two can be used. > The rest of the SoC is the usual soup of multimedia SoC IP, with eDP > support and two Gigabit Ethernet MACs among the highlights. > > The main feature is patch 11/14, which adds the SoC .dtsi. This for now > is limited to the parts that are supported and could be tested. At the > moment there is no PSCI firmware, even the TF-A port from the BSP does > not seem to work for me. That's why the secondary cores have been omitted > for now, among other instances of some IP that I couldn't test yet. > I plan to add them in one of the next revisions. > > The last patch adds basic support for the Avaota-A1 router board, > designed by YuzukiHD, with some boards now built by Pine64. > > The mainline firmware side in general is somewhat lacking still: I have > basic U-Boot support working (including MMC and USB), although still > without DRAM support. This is for now covered by some binary blob found > in the (otherwise Open Source) Syterkit firmware, which also provides > the BSP versions of TF-A and the required (RISC-V) management core > firmware. Fortunately we have indications that DRAM support is not that > tricky, as the IP blocks are very similar to already supported, and dev > boards are on their way to the right people. > > Meanwhile I would like people to have a look at those DT bits here. Please > compare them to the available user manual, and test them if you have access > to hardware. > > Based on v6.12-rc1. > I pushed a branch with all the three series combined here: > https://github.com/apritzel/linux/commits/a523-v1/ > > Cheers, > Andre > > [1] https://linux-sunxi.org/A523#Family_of_sun55iw3 > [2] https://lore.kernel.org/linux-sunxi/20241111005750.13071-1-andre.przywara@arm.com/T/#t > [3] https://lore.kernel.org/linux-sunxi/20241111004722.10130-1-andre.przywara@arm.com/T/#t > > Andre Przywara (14): > dt-bindings: mmc: sunxi: Simplify compatible string listing > dt-bindings: mmc: sunxi: add compatible strings for Allwinner A523 > dt-bindings: watchdog: sunxi: add Allwinner A523 compatible string > watchdog: sunxi_wdt: Add support for Allwinner A523 > dt-bindings: i2c: mv64xxx: Add Allwinner A523 compatible string > dt-bindings: irq: sun7i-nmi: document the Allwinner A523 NMI > controller > dt-bindings: phy: document Allwinner A523 USB-2.0 PHY > dt-bindings: usb: sunxi-musb: add Allwinner A523 compatible string > dt-bindings: usb: add A523 compatible string for EHCI and OCHI > dt-bindings: rtc: sun6i: Add Allwinner A523 support > arm64: dts: allwinner: Add Allwinner A523 .dtsi file > dt-bindings: vendor-prefixes: Add YuzukiHD name > dt-bindings: arm: sunxi: Add Avaota A1 board > arm64: dts: allwinner: a523: add Avaota-A1 router support > > .../devicetree/bindings/arm/sunxi.yaml | 5 + > .../bindings/i2c/marvell,mv64xxx-i2c.yaml | 1 + > .../allwinner,sun7i-a20-sc-nmi.yaml | 1 + > .../bindings/mmc/allwinner,sun4i-a10-mmc.yaml | 40 +- > .../phy/allwinner,sun50i-a64-usb-phy.yaml | 10 +- > .../bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 4 +- > .../usb/allwinner,sun4i-a10-musb.yaml | 1 + > .../devicetree/bindings/usb/generic-ehci.yaml | 1 + > .../devicetree/bindings/usb/generic-ohci.yaml | 1 + > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > .../watchdog/allwinner,sun4i-a10-wdt.yaml | 2 + > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 386 ++++++++++++++++++ > .../dts/allwinner/sun55i-t527-avaota-a1.dts | 311 ++++++++++++++ > drivers/watchdog/sunxi_wdt.c | 11 + > 15 files changed, 751 insertions(+), 26 deletions(-) > create mode 100644 arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > create mode 100644 arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts > > -- > 2.46.2 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y allwinner/sun55i-t527-avaota-a1.dtb' for 20241111013033.22793-1-andre.przywara@arm.com: In file included from arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts:6: arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi:6:10: fatal error: dt-bindings/clock/sun55i-a523-ccu.h: No such file or directory 6 | #include <dt-bindings/clock/sun55i-a523-ccu.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[3]: *** [scripts/Makefile.dtbs:129: arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb] Error 1 make[2]: *** [scripts/Makefile.build:478: arch/arm64/boot/dts/allwinner] Error 2 make[2]: Target 'arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb' not remade because of errors. make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1399: allwinner/sun55i-t527-avaota-a1.dtb] Error 2 make: *** [Makefile:224: __sub-make] Error 2 make: Target 'allwinner/sun55i-t527-avaota-a1.dtb' not remade because of errors. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/14] arm64: dts: allwinner: Add basic Allwinner A523 support 2024-11-11 15:32 ` [PATCH 00/14] arm64: dts: allwinner: Add basic Allwinner A523 support Rob Herring (Arm) @ 2024-11-11 17:42 ` Andre Przywara 0 siblings, 0 replies; 8+ messages in thread From: Andre Przywara @ 2024-11-11 17:42 UTC (permalink / raw) To: Rob Herring (Arm) Cc: Krzysztof Kozlowski, linux-phy, linux-mmc, Gregory CLEMENT, Alexandre Belloni, Wim Van Sebroeck, Greg Kroah-Hartman, devicetree, linux-rtc, linux-kernel, linux-sunxi, linux-arm-kernel, linux-i2c, Andi Shyti, Vinod Koul, linux-watchdog, Thomas Gleixner, Chen-Yu Tsai, Samuel Holland, Ulf Hansson, linux-usb, Jernej Skrabec, Guenter Roeck, Conor Dooley, Kishon Vijay Abraham I On Mon, 11 Nov 2024 09:32:53 -0600 "Rob Herring (Arm)" <robh@kernel.org> wrote: Hi Rob, > On Mon, 11 Nov 2024 01:30:19 +0000, Andre Przywara wrote: > > Hi, > > > > this series adds basic DT support for the Allwinner A523 SoC, plus the > > Avaota-A1 router board using the T527 package variant of that SoC.[1] > > Functionality-wise it relies on the pinctrl[2] and clock[3] support > > series, though there is no direct code dependency series to this series > > (apart from the respective binding patches in the two series'). > > > > Most of the patches add DT binding documentation for the most basic > > peripherals, the vast majority of them actually being already supported, > > courtesy of identical IP being used. This includes MMC and USB 2.0, so > > with the above mentioned clock and pinctrl support this gives an already > > somewhat usable mainline support for this new SoC family. > > The watchdog is not completely compatible, but is an easy addition, so > > this bit is included in here as well. > > > > The A523 features 8 Arm Cortex-A55 cores, organised in two clusters, > > clocked separately, with different OPP limits, in some kind of > > little/LITTLE configuration. The GPU is a Arm Mali G57 MC01, and the chip > > also features a single PCIe 2.1 lane, sharing a PHY with some USB 3.1 > > controller - which means only one of the two can be used. > > The rest of the SoC is the usual soup of multimedia SoC IP, with eDP > > support and two Gigabit Ethernet MACs among the highlights. > > > > The main feature is patch 11/14, which adds the SoC .dtsi. This for now > > is limited to the parts that are supported and could be tested. At the > > moment there is no PSCI firmware, even the TF-A port from the BSP does > > not seem to work for me. That's why the secondary cores have been omitted > > for now, among other instances of some IP that I couldn't test yet. > > I plan to add them in one of the next revisions. > > > > The last patch adds basic support for the Avaota-A1 router board, > > designed by YuzukiHD, with some boards now built by Pine64. > > > > The mainline firmware side in general is somewhat lacking still: I have > > basic U-Boot support working (including MMC and USB), although still > > without DRAM support. This is for now covered by some binary blob found > > in the (otherwise Open Source) Syterkit firmware, which also provides > > the BSP versions of TF-A and the required (RISC-V) management core > > firmware. Fortunately we have indications that DRAM support is not that > > tricky, as the IP blocks are very similar to already supported, and dev > > boards are on their way to the right people. > > > > Meanwhile I would like people to have a look at those DT bits here. Please > > compare them to the available user manual, and test them if you have access > > to hardware. > > > > Based on v6.12-rc1. > > I pushed a branch with all the three series combined here: > > https://github.com/apritzel/linux/commits/a523-v1/ > > > > Cheers, > > Andre > > > > [1] https://linux-sunxi.org/A523#Family_of_sun55iw3 > > [2] https://lore.kernel.org/linux-sunxi/20241111005750.13071-1-andre.przywara@arm.com/T/#t > > [3] https://lore.kernel.org/linux-sunxi/20241111004722.10130-1-andre.przywara@arm.com/T/#t > > > > Andre Przywara (14): > > dt-bindings: mmc: sunxi: Simplify compatible string listing > > dt-bindings: mmc: sunxi: add compatible strings for Allwinner A523 > > dt-bindings: watchdog: sunxi: add Allwinner A523 compatible string > > watchdog: sunxi_wdt: Add support for Allwinner A523 > > dt-bindings: i2c: mv64xxx: Add Allwinner A523 compatible string > > dt-bindings: irq: sun7i-nmi: document the Allwinner A523 NMI > > controller > > dt-bindings: phy: document Allwinner A523 USB-2.0 PHY > > dt-bindings: usb: sunxi-musb: add Allwinner A523 compatible string > > dt-bindings: usb: add A523 compatible string for EHCI and OCHI > > dt-bindings: rtc: sun6i: Add Allwinner A523 support > > arm64: dts: allwinner: Add Allwinner A523 .dtsi file > > dt-bindings: vendor-prefixes: Add YuzukiHD name > > dt-bindings: arm: sunxi: Add Avaota A1 board > > arm64: dts: allwinner: a523: add Avaota-A1 router support > > > > .../devicetree/bindings/arm/sunxi.yaml | 5 + > > .../bindings/i2c/marvell,mv64xxx-i2c.yaml | 1 + > > .../allwinner,sun7i-a20-sc-nmi.yaml | 1 + > > .../bindings/mmc/allwinner,sun4i-a10-mmc.yaml | 40 +- > > .../phy/allwinner,sun50i-a64-usb-phy.yaml | 10 +- > > .../bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 4 +- > > .../usb/allwinner,sun4i-a10-musb.yaml | 1 + > > .../devicetree/bindings/usb/generic-ehci.yaml | 1 + > > .../devicetree/bindings/usb/generic-ohci.yaml | 1 + > > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > > .../watchdog/allwinner,sun4i-a10-wdt.yaml | 2 + > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > > .../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 386 ++++++++++++++++++ > > .../dts/allwinner/sun55i-t527-avaota-a1.dts | 311 ++++++++++++++ > > drivers/watchdog/sunxi_wdt.c | 11 + > > 15 files changed, 751 insertions(+), 26 deletions(-) > > create mode 100644 arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > > create mode 100644 arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts > > > > -- > > 2.46.2 > > > > > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y allwinner/sun55i-t527-avaota-a1.dtb' for 20241111013033.22793-1-andre.przywara@arm.com: > > In file included from arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts:6: > arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi:6:10: fatal error: dt-bindings/clock/sun55i-a523-ccu.h: No such file or directory > 6 | #include <dt-bindings/clock/sun55i-a523-ccu.h> Argh, the headers, forgot about them! I was hoping there would only be a complaint about the undocumented compatible strings, and I didn't want to tie the three series together unnecessarily, to avoid a harder to handle 28-patch series. I hope this doesn't prevent actual review by people, my github has the combined story, in case people want to avoid the issue: https://github.com/apritzel/linux/commits/a523-v1/ Cheers, Andre > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > make[3]: *** [scripts/Makefile.dtbs:129: arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb] Error 1 > make[2]: *** [scripts/Makefile.build:478: arch/arm64/boot/dts/allwinner] Error 2 > make[2]: Target 'arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dtb' not remade because of errors. > make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1399: allwinner/sun55i-t527-avaota-a1.dtb] Error 2 > make: *** [Makefile:224: __sub-make] Error 2 > make: Target 'allwinner/sun55i-t527-avaota-a1.dtb' not remade because of errors. > > > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-01-18 11:47 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-11-11 1:30 [PATCH 00/14] arm64: dts: allwinner: Add basic Allwinner A523 support Andre Przywara 2024-11-11 1:30 ` [PATCH 03/14] dt-bindings: watchdog: sunxi: add Allwinner A523 compatible string Andre Przywara 2024-11-11 20:35 ` Conor Dooley 2025-01-18 11:47 ` Jernej Škrabec 2024-11-11 1:30 ` [PATCH 04/14] watchdog: sunxi_wdt: Add support for Allwinner A523 Andre Przywara 2025-01-18 11:45 ` Jernej Škrabec 2024-11-11 15:32 ` [PATCH 00/14] arm64: dts: allwinner: Add basic Allwinner A523 support Rob Herring (Arm) 2024-11-11 17:42 ` Andre Przywara
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox