[PATCH v2 0/2] Add support for RZ/G3E WDT

[PATCH v2 0/2] Add support for RZ/G3E WDT

[Biju Das]

The RZ/G3E WDT IP is similar to RZ/V2H WDT. WDT0 can be used for CM33 cold
reset, system reset and asserting WDTUDFCM pin where as WDT1 can be used
for CA55 cold reset, system reset and asserting WDTUDFCA pin. Other 2
watchdogs can be used for system reset. So define WDT{1..3} in SoC dtsi.

v1->v2:
 * Dropped patch#2, #4 and #5 as it is queued for renesas_clk and
   renesas_devel.
 * Collected tags for patch#1.
 * Updated commit header and description for patch#2.
 * Replaced ARCH_R9A09G047->ARCH_RENESAS as both RZ/V2H and RZ/G3E belongs
   to ARCH_RENESAS family.

Biju Das (2):
  dt-bindings: watchdog: renesas,wdt: Document RZ/G3E support
  watchdog: Enable RZV2HWDT driver depend on ARCH_RENESAS

 .../devicetree/bindings/watchdog/renesas,wdt.yaml          | 4 ++++
 drivers/watchdog/Kconfig                                   | 7 ++++---
 2 files changed, 8 insertions(+), 3 deletions(-)

-- 
2.43.0

[PATCH v2 1/2] dt-bindings: watchdog: renesas,wdt: Document RZ/G3E support

[Biju Das]

Document the support for the watchdog IP available on RZ/G3E SoC. The
watchdog IP available on RZ/G3E SoC is identical to the one found on
RZ/V2H SoC.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v1->v2:
 * Collected tags.
---
 Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
index 29ada89fdcdc..3e0a8747a357 100644
--- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
@@ -75,6 +75,10 @@ properties:
               - renesas,r8a779h0-wdt     # R-Car V4M
           - const: renesas,rcar-gen4-wdt # R-Car Gen4
 
+      - items:
+          - const: renesas,r9a09g047-wdt # RZ/G3E
+          - const: renesas,r9a09g057-wdt # RZ/V2H(P)
+
       - const: renesas,r9a09g057-wdt       # RZ/V2H(P)
 
   reg:
-- 
2.43.0

RE: [PATCH v2 1/2] dt-bindings: watchdog: renesas,wdt: Document RZ/G3E support

[Biju Das]

Hi Wim Van Sebroeck,


> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: 26 January 2025 13:27
> Subject: [PATCH v2 1/2] dt-bindings: watchdog: renesas,wdt: Document RZ/G3E support
> 
> Document the support for the watchdog IP available on RZ/G3E SoC. The watchdog IP available on RZ/G3E
> SoC is identical to the one found on RZ/V2H SoC.
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v1->v2:
>  * Collected tags.
> ---
>  Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> index 29ada89fdcdc..3e0a8747a357 100644
> --- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> @@ -75,6 +75,10 @@ properties:
>                - renesas,r8a779h0-wdt     # R-Car V4M
>            - const: renesas,rcar-gen4-wdt # R-Car Gen4
> 
> +      - items:
> +          - const: renesas,r9a09g047-wdt # RZ/G3E
> +          - const: renesas,r9a09g057-wdt # RZ/V2H(P)
> +
>        - const: renesas,r9a09g057-wdt       # RZ/V2H(P)
> 
>    reg:

Looks like you missed this patch from the series as [1]
hits in next or you expect it to go through DT tree?

[1] https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20250311&id=331c8349605c8fa2f9040c39fe8c40afe3fdc3c3

Cheers,
Biju

Re: [PATCH v2 1/2] dt-bindings: watchdog: renesas,wdt: Document RZ/G3E support

[Wim Van Sebroeck]

Hi Biju

> Hi Wim Van Sebroeck,
> 
> 
> > -----Original Message-----
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> > Sent: 26 January 2025 13:27
> > Subject: [PATCH v2 1/2] dt-bindings: watchdog: renesas,wdt: Document RZ/G3E support
> > 
> > Document the support for the watchdog IP available on RZ/G3E SoC. The watchdog IP available on RZ/G3E
> > SoC is identical to the one found on RZ/V2H SoC.
> > 
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v1->v2:
> >  * Collected tags.
> > ---
> >  Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> > b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> > index 29ada89fdcdc..3e0a8747a357 100644
> > --- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> > @@ -75,6 +75,10 @@ properties:
> >                - renesas,r8a779h0-wdt     # R-Car V4M
> >            - const: renesas,rcar-gen4-wdt # R-Car Gen4
> > 
> > +      - items:
> > +          - const: renesas,r9a09g047-wdt # RZ/G3E
> > +          - const: renesas,r9a09g057-wdt # RZ/V2H(P)
> > +
> >        - const: renesas,r9a09g057-wdt       # RZ/V2H(P)
> > 
> >    reg:
> 
> Looks like you missed this patch from the series as [1]
> hits in next or you expect it to go through DT tree?
> 
> [1] https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20250311&id=331c8349605c8fa2f9040c39fe8c40afe3fdc3c3
> 
> Cheers,
> Biju

Added.

Kind regards,
Wim.

[PATCH v2 2/2] watchdog: Enable RZV2HWDT driver depend on ARCH_RENESAS

[Biju Das]

RZ/G3E watchdog timer IP is similar to the one found on RZ/V2H. Both these
SoCs belong to the ARCH_RENESAS family. So, it makes sense to use
ARCH_RENESAS rather than ARCH_R9A09G057 to enable the RZV2HWDT driver.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v1->v2:
 * Updated commit header and description.
 * Replaced ARCH_R9A09G047->ARCH_RENESAS as both RZ/V2H and RZ/G3E belongs
   to ARCH_RENESAS family.
---
 drivers/watchdog/Kconfig | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index f81705f8539a..b9d23f98a436 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -963,13 +963,14 @@ config RENESAS_RZG2LWDT
 	  Renesas RZ/G2L SoCs. These watchdogs can be used to reset a system.
 
 config RENESAS_RZV2HWDT
-	tristate "Renesas RZ/V2H(P) WDT Watchdog"
-	depends on ARCH_R9A09G057 || COMPILE_TEST
+	tristate "Renesas RZ/{G3E,V2H(P)} WDT Watchdog"
+	depends on ARCH_RENESAS || COMPILE_TEST
 	depends on PM || COMPILE_TEST
 	select WATCHDOG_CORE
 	help
 	  This driver adds watchdog support for the integrated watchdogs in the
-	  Renesas RZ/V2H(P) SoCs. These watchdogs can be used to reset a system.
+	  Renesas RZ/{G3E,V2H(P)} SoCs. These watchdogs can be used to reset a
+	  system.
 
 config ASPEED_WATCHDOG
 	tristate "Aspeed BMC watchdog support"
-- 
2.43.0

Re: [PATCH v2 2/2] watchdog: Enable RZV2HWDT driver depend on ARCH_RENESAS

[Guenter Roeck]

On 1/26/25 05:26, Biju Das wrote:
> RZ/G3E watchdog timer IP is similar to the one found on RZ/V2H. Both these
> SoCs belong to the ARCH_RENESAS family. So, it makes sense to use
> ARCH_RENESAS rather than ARCH_R9A09G057 to enable the RZV2HWDT driver.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> v1->v2:
>   * Updated commit header and description.
>   * Replaced ARCH_R9A09G047->ARCH_RENESAS as both RZ/V2H and RZ/G3E belongs
>     to ARCH_RENESAS family.
> ---
>   drivers/watchdog/Kconfig | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index f81705f8539a..b9d23f98a436 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -963,13 +963,14 @@ config RENESAS_RZG2LWDT
>   	  Renesas RZ/G2L SoCs. These watchdogs can be used to reset a system.
>   
>   config RENESAS_RZV2HWDT
> -	tristate "Renesas RZ/V2H(P) WDT Watchdog"
> -	depends on ARCH_R9A09G057 || COMPILE_TEST
> +	tristate "Renesas RZ/{G3E,V2H(P)} WDT Watchdog"
> +	depends on ARCH_RENESAS || COMPILE_TEST
>   	depends on PM || COMPILE_TEST
>   	select WATCHDOG_CORE
>   	help
>   	  This driver adds watchdog support for the integrated watchdogs in the
> -	  Renesas RZ/V2H(P) SoCs. These watchdogs can be used to reset a system.
> +	  Renesas RZ/{G3E,V2H(P)} SoCs. These watchdogs can be used to reset a
> +	  system.
>   
>   config ASPEED_WATCHDOG
>   	tristate "Aspeed BMC watchdog support"

Re: [PATCH v2 2/2] watchdog: Enable RZV2HWDT driver depend on ARCH_RENESAS

[Geert Uytterhoeven]

On Sun, 26 Jan 2025 at 14:27, Biju Das <biju.das.jz@bp.renesas.com> wrote:
> RZ/G3E watchdog timer IP is similar to the one found on RZ/V2H. Both these
> SoCs belong to the ARCH_RENESAS family. So, it makes sense to use
> ARCH_RENESAS rather than ARCH_R9A09G057 to enable the RZV2HWDT driver.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v1->v2:
>  * Updated commit header and description.
>  * Replaced ARCH_R9A09G047->ARCH_RENESAS as both RZ/V2H and RZ/G3E belongs
>    to ARCH_RENESAS family.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH v2 0/2] Add support for RZ/G3E WDT

[Biju Das]

Hi all,

> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: 26 January 2025 13:26
> Subject: [PATCH v2 0/2] Add support for RZ/G3E WDT
> 
> The RZ/G3E WDT IP is similar to RZ/V2H WDT. WDT0 can be used for CM33 cold reset, system reset and
> asserting WDTUDFCM pin where as WDT1 can be used for CA55 cold reset, system reset and asserting
> WDTUDFCA pin. Other 2 watchdogs can be used for system reset. So define WDT{1..3} in SoC dtsi.
> 
> v1->v2:
>  * Dropped patch#2, #4 and #5 as it is queued for renesas_clk and
>    renesas_devel.
>  * Collected tags for patch#1.
>  * Updated commit header and description for patch#2.
>  * Replaced ARCH_R9A09G047->ARCH_RENESAS as both RZ/V2H and RZ/G3E belongs
>    to ARCH_RENESAS family.
> 
> Biju Das (2):
>   dt-bindings: watchdog: renesas,wdt: Document RZ/G3E support
>   watchdog: Enable RZV2HWDT driver depend on ARCH_RENESAS
> 
>  .../devicetree/bindings/watchdog/renesas,wdt.yaml          | 4 ++++
>  drivers/watchdog/Kconfig                                   | 7 ++++---
>  2 files changed, 8 insertions(+), 3 deletions(-)
> 

Gentle ping.

Cheers,
Biju

RE: [PATCH v2 0/2] Add support for RZ/G3E WDT

[Biju Das]

Hi All,

> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: 20 February 2025 11:41
> Subject: RE: [PATCH v2 0/2] Add support for RZ/G3E WDT
> 
> Hi all,
> 
> > -----Original Message-----
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> > Sent: 26 January 2025 13:26
> > Subject: [PATCH v2 0/2] Add support for RZ/G3E WDT
> >
> > The RZ/G3E WDT IP is similar to RZ/V2H WDT. WDT0 can be used for CM33
> > cold reset, system reset and asserting WDTUDFCM pin where as WDT1 can
> > be used for CA55 cold reset, system reset and asserting WDTUDFCA pin. Other 2 watchdogs can be used
> for system reset. So define WDT{1..3} in SoC dtsi.
> >
> > v1->v2:
> >  * Dropped patch#2, #4 and #5 as it is queued for renesas_clk and
> >    renesas_devel.
> >  * Collected tags for patch#1.
> >  * Updated commit header and description for patch#2.
> >  * Replaced ARCH_R9A09G047->ARCH_RENESAS as both RZ/V2H and RZ/G3E belongs
> >    to ARCH_RENESAS family.
> >
> > Biju Das (2):
> >   dt-bindings: watchdog: renesas,wdt: Document RZ/G3E support
> >   watchdog: Enable RZV2HWDT driver depend on ARCH_RENESAS
> >
> >  .../devicetree/bindings/watchdog/renesas,wdt.yaml          | 4 ++++
> >  drivers/watchdog/Kconfig                                   | 7 ++++---
> >  2 files changed, 8 insertions(+), 3 deletions(-)
> >
> 

Gentle ping. Are we happy with this patches?

Cheers,
Biju