* [v2 PATCH 1/3] arch: arm64: dts: add big-endian property back into watchdog node
2025-05-31 4:02 [v2 PATCH 0/3] create patches for nxp-ls1046a platform watchdog feature Meng Li
@ 2025-05-31 4:02 ` Meng Li
2025-05-31 4:02 ` [v2 PATCH 2/3] arm64: dts: layerscape: add platform special compatible string for watchdog Meng Li
2025-05-31 4:02 ` [v2 PATCH 3/3] dt-bindings: watchdog: fsl-imx-wdt: enable 'big-endian' property for NXP ls1046a platform Meng Li
2 siblings, 0 replies; 6+ messages in thread
From: Meng Li @ 2025-05-31 4:02 UTC (permalink / raw)
To: imx, linux-watchdog, festevam, kernel, s.hauer, wim, linux,
shawnguo, robh, conor+dt, Frank.Li
Cc: linux-arm-kernel, devicetree, linux-kernel, meng.li
When verifying watchdog feature on NXP ls1046ardb board,
it doesn't work. Because in commit 7c8ffc5555cb("arm64: dts: layerscape:
remove big-endian for mmc nodes"), it intented to remove the big-endian
from mmc node, but the big-endian of watchdog node is also removed by
accident. So, add watchdog big-endian property back.
Fixes: 7c8ffc5555cb ("arm64: dts: layerscape: remove big-endian for mmc nodes")
Cc: stable@vger.kernel.org
Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 0baf256b4400..d1c64d97bccd 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -692,6 +692,7 @@ wdog0: watchdog@2ad0000 {
interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
QORIQ_CLK_PLL_DIV(2)>;
+ big-endian;
};
edma0: dma-controller@2c00000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [v2 PATCH 2/3] arm64: dts: layerscape: add platform special compatible string for watchdog
2025-05-31 4:02 [v2 PATCH 0/3] create patches for nxp-ls1046a platform watchdog feature Meng Li
2025-05-31 4:02 ` [v2 PATCH 1/3] arch: arm64: dts: add big-endian property back into watchdog node Meng Li
@ 2025-05-31 4:02 ` Meng Li
2025-06-02 13:59 ` Frank Li
2025-05-31 4:02 ` [v2 PATCH 3/3] dt-bindings: watchdog: fsl-imx-wdt: enable 'big-endian' property for NXP ls1046a platform Meng Li
2 siblings, 1 reply; 6+ messages in thread
From: Meng Li @ 2025-05-31 4:02 UTC (permalink / raw)
To: imx, linux-watchdog, festevam, kernel, s.hauer, wim, linux,
shawnguo, robh, conor+dt, Frank.Li
Cc: linux-arm-kernel, devicetree, linux-kernel, meng.li
Add "fsl,ls1046a-wdt" compatible string for watchdog node, and it will
be added into fsl-imx-wdt.yaml in next patch.
Cc: stable@vger.kernel.org
Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index d1c64d97bccd..983b2f0e8797 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -687,7 +687,7 @@ lpuart5: serial@29a0000 {
};
wdog0: watchdog@2ad0000 {
- compatible = "fsl,imx21-wdt";
+ compatible = "fsl,ls1046a-wdt", "fsl,imx21-wdt";
reg = <0x0 0x2ad0000 0x0 0x10000>;
interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [v2 PATCH 2/3] arm64: dts: layerscape: add platform special compatible string for watchdog
2025-05-31 4:02 ` [v2 PATCH 2/3] arm64: dts: layerscape: add platform special compatible string for watchdog Meng Li
@ 2025-06-02 13:59 ` Frank Li
0 siblings, 0 replies; 6+ messages in thread
From: Frank Li @ 2025-06-02 13:59 UTC (permalink / raw)
To: Meng Li
Cc: imx, linux-watchdog, festevam, kernel, s.hauer, wim, linux,
shawnguo, robh, conor+dt, linux-arm-kernel, devicetree,
linux-kernel
On Sat, May 31, 2025 at 12:02:12PM +0800, Meng Li wrote:
> Add "fsl,ls1046a-wdt" compatible string for watchdog node, and it will
> be added into fsl-imx-wdt.yaml in next patch.
This patch should merge to first one. And move binding doc patch to first
one.
Frank
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index d1c64d97bccd..983b2f0e8797 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -687,7 +687,7 @@ lpuart5: serial@29a0000 {
> };
>
> wdog0: watchdog@2ad0000 {
> - compatible = "fsl,imx21-wdt";
> + compatible = "fsl,ls1046a-wdt", "fsl,imx21-wdt";
> reg = <0x0 0x2ad0000 0x0 0x10000>;
> interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [v2 PATCH 3/3] dt-bindings: watchdog: fsl-imx-wdt: enable 'big-endian' property for NXP ls1046a platform
2025-05-31 4:02 [v2 PATCH 0/3] create patches for nxp-ls1046a platform watchdog feature Meng Li
2025-05-31 4:02 ` [v2 PATCH 1/3] arch: arm64: dts: add big-endian property back into watchdog node Meng Li
2025-05-31 4:02 ` [v2 PATCH 2/3] arm64: dts: layerscape: add platform special compatible string for watchdog Meng Li
@ 2025-05-31 4:02 ` Meng Li
2025-06-02 13:58 ` Frank Li
2 siblings, 1 reply; 6+ messages in thread
From: Meng Li @ 2025-05-31 4:02 UTC (permalink / raw)
To: imx, linux-watchdog, festevam, kernel, s.hauer, wim, linux,
shawnguo, robh, conor+dt, Frank.Li
Cc: linux-arm-kernel, devicetree, linux-kernel, meng.li
The watchdog of ls1046a SoC is a big-endian device. So enable big-endian
property for it, so that avoid below dtbs_check errors.
arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: watchdog@2ad0000
(fsl,imx21-wdt): big-endian: False schema does not allow True
Cc: stable@vger.kernel.org
Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
index 0da953cb7127..8006efb69ec7 100644
--- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
@@ -36,6 +36,7 @@ properties:
- fsl,imx8mq-wdt
- fsl,ls1012a-wdt
- fsl,ls1043a-wdt
+ - fsl,ls1046a-wdt
- fsl,vf610-wdt
- const: fsl,imx21-wdt
@@ -103,6 +104,7 @@ allOf:
enum:
- fsl,ls1012a-wdt
- fsl,ls1043a-wdt
+ - fsl,ls1046a-wdt
then:
properties:
big-endian: false
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [v2 PATCH 3/3] dt-bindings: watchdog: fsl-imx-wdt: enable 'big-endian' property for NXP ls1046a platform
2025-05-31 4:02 ` [v2 PATCH 3/3] dt-bindings: watchdog: fsl-imx-wdt: enable 'big-endian' property for NXP ls1046a platform Meng Li
@ 2025-06-02 13:58 ` Frank Li
0 siblings, 0 replies; 6+ messages in thread
From: Frank Li @ 2025-06-02 13:58 UTC (permalink / raw)
To: Meng Li
Cc: imx, linux-watchdog, festevam, kernel, s.hauer, wim, linux,
shawnguo, robh, conor+dt, linux-arm-kernel, devicetree,
linux-kernel
On Sat, May 31, 2025 at 12:02:13PM +0800, Meng Li wrote:
> The watchdog of ls1046a SoC is a big-endian device. So enable big-endian
> property for it, so that avoid below dtbs_check errors.
Add compatible string fsl,ls1046a-wdt and allow big-endian for it.
> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: watchdog@2ad0000
> (fsl,imx21-wdt): big-endian: False schema does not allow True
If this patch is first one, should not such warning.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
This patch should be fix one.
Frank
> Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> index 0da953cb7127..8006efb69ec7 100644
> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
> @@ -36,6 +36,7 @@ properties:
> - fsl,imx8mq-wdt
> - fsl,ls1012a-wdt
> - fsl,ls1043a-wdt
> + - fsl,ls1046a-wdt
> - fsl,vf610-wdt
> - const: fsl,imx21-wdt
>
> @@ -103,6 +104,7 @@ allOf:
> enum:
> - fsl,ls1012a-wdt
> - fsl,ls1043a-wdt
> + - fsl,ls1046a-wdt
> then:
> properties:
> big-endian: false
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread