From: sashiko-bot@kernel.org
To: "Philipp Hahn" <p.hahn@avm.de>
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 1/6] watchdog: Fix wrong SPDX license identifier
Date: Mon, 04 May 2026 11:17:34 +0000 [thread overview]
Message-ID: <20260504111735.3D387C2BCB8@smtp.kernel.org> (raw)
In-Reply-To: <5557c8ab4a62750c95631f6f78be7d2b11e091fc.1777892508.git.phahn-oss@avm.de>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit claims to fix a checkpatch warning by replacing `GPL-2.0` with `GPL-2.0-only`, but the kernel's checkpatch does not warn about `GPL-2.0` in this context, making the change unnecessary churn based on a false premise.
--
commit b8d17764218e572db22388434473471ed009998c
Author: Philipp Hahn <phahn-oss@avm.de>
watchdog: Fix wrong SPDX license identifier
This commit updates the SPDX license identifier in the watchdog
documentation from GPL-2.0 to GPL-2.0-only.
> The identifier GPL-2.0 has been deprecated in favor of GPL-2.0-only.
> Change it to silence checkpatch.
Is this description accurate regarding checkpatch?
Looking at scripts/checkpatch.pl, it only enforces GPL-2.0-only for files
under Documentation/devicetree/bindings/ and include/dt-bindings/.
Additionally, LICENSES/preferred/GPL-2.0 explicitly defines GPL-2.0 as a
valid identifier in the Linux kernel.
Since checkpatch does not emit warnings for GPL-2.0 in generic subsystem
documentation like Documentation/watchdog/index.rst, does this change
introduce unnecessary churn?
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1777892508.git.phahn-oss@avm.de?part=1
next prev parent reply other threads:[~2026-05-04 11:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 11:02 [PATCH 0/6] Cleanup Linux Watchdog documentation Philipp Hahn
2026-05-04 11:02 ` [PATCH 1/6] watchdog: Fix wrong SPDX license identifier Philipp Hahn
2026-05-04 11:17 ` sashiko-bot [this message]
2026-05-04 13:44 ` Guenter Roeck
2026-05-04 13:52 ` AW: " Philipp Hahn
2026-05-04 14:07 ` Guenter Roeck
2026-05-04 11:02 ` [PATCH 2/6] watchdog: Change suffix .txt to .rst in references Philipp Hahn
2026-05-04 11:02 ` [PATCH 3/6] watchdog: Move `struct` before name Philipp Hahn
2026-05-04 11:02 ` [PATCH 4/6] watchdog: Replace intermixed tab/space indent Philipp Hahn
2026-05-04 11:02 ` [PATCH 5/6] watchdog: Separate kind of documentation Philipp Hahn
2026-05-04 11:02 ` [PATCH 6/6] watchdog: Prefix WDT with ICS for clarity Philipp Hahn
2026-05-04 14:00 ` Guenter Roeck
2026-05-04 13:49 ` [PATCH v2 0/5] Cleanup Linux Watchdog documentation Philipp Hahn
2026-05-04 13:49 ` [PATCH v2 1/5] watchdog: Change suffix .txt to .rst in references Philipp Hahn
2026-05-04 13:50 ` [PATCH v2 2/5] watchdog: Move `struct` before name Philipp Hahn
2026-05-04 13:50 ` [PATCH v2 3/5] watchdog: Replace intermixed tab/space indent Philipp Hahn
2026-05-04 13:50 ` [PATCH v2 4/5] watchdog: Separate kind of documentation Philipp Hahn
2026-05-04 13:50 ` [PATCH v2 5/5] watchdog: Prefix WDT with ICS for clarity Philipp Hahn
2026-05-04 17:11 ` sashiko-bot
2026-05-04 14:11 ` [PATCH v2 0/5] Cleanup Linux Watchdog documentation Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504111735.3D387C2BCB8@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=p.hahn@avm.de \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox