Re: [PATCH v2 5/5] watchdog: Prefix WDT with ICS for clarity

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete renaming: the 'ICS' prefix was not added to the Kconfig help text for the WDTPCI configuration.
--

commit 4485842d9f93fd889373b4245fc0ff5cb5d3e3b8
Author: Philipp Hahn <phahn-oss@avm.de>

watchdog: Prefix WDT with ICS for clarity

The commit updates documentation and Kconfig files to clarify that WDT refers
to the Watchdog timer from Industrial Computer Source (ICS). It adds the ICS
prefix in several places and includes a missing SPDX license identifier.

> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index dc78729ba2a5d..2cbf0391a065a 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
[ ... ]
> @@ -2270,10 +2270,10 @@ config MIXCOMWD
>  	  Most people will say N.
>  
>  config WDT
> -	tristate "WDT Watchdog timer"
> +	tristate "ICS WDT Watchdog timer"
>  	depends on ISA
>  	help
> -	  If you have a WDT500P or WDT501P watchdog board, say Y here,
> +	  If you have an ICS WDT500P or WDT501P watchdog board, say Y here,
>  	  otherwise N. It is not possible to probe for this board, which means
[ ... ]
> @@ -2304,7 +2304,7 @@ config PCIPCWATCHDOG
>  	  Most people will say N.
>  
>  config WDTPCI
> -	tristate "PCI-WDT500/501 Watchdog timer"
> +	tristate "ICS PCI-WDT500/501 Watchdog timer"
>  	depends on PCI && HAS_IOPORT
>  	help
>  	  If you have a PCI-WDT500/501 watchdog board, say Y here, otherwise N.

This isn't a bug, but should the help text for WDTPCI also be updated to
include the ICS prefix for consistency? The WDT config help text was updated
above, but this description still reads "If you have a PCI-WDT500/501
watchdog board".

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1777902230.git.phahn-oss@avm.de?part=5