Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-renesas-soc@vger.kernel.org
Cc: "Herve Codina (Schneider Electric)" <herve.codina@bootlin.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	linux-watchdog@vger.kernel.org
Subject: [PATCH v4 1/4] watchdog: rzn1: Fix reverse xmas tree declaration
Date: Thu,  7 May 2026 12:24:06 +0200	[thread overview]
Message-ID: <20260507102410.43384-2-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20260507102410.43384-1-wsa+renesas@sang-engineering.com>

From: "Herve Codina (Schneider Electric)" <herve.codina@bootlin.com>

Variables declared in probe() don't follow the reverse xmas
tree convention.

Fix the declaration in order to follow the convention.

Signed-off-by: Herve Codina (Schneider Electric) <herve.codina@bootlin.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/watchdog/rzn1_wdt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/rzn1_wdt.c b/drivers/watchdog/rzn1_wdt.c
index 96fd04fbc2a2..b7034eac91d0 100644
--- a/drivers/watchdog/rzn1_wdt.c
+++ b/drivers/watchdog/rzn1_wdt.c
@@ -101,10 +101,10 @@ static const struct watchdog_ops rzn1_wdt_ops = {
 static int rzn1_wdt_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
-	struct rzn1_watchdog *wdt;
 	struct device_node *np = dev->of_node;
-	struct clk *clk;
+	struct rzn1_watchdog *wdt;
 	unsigned long clk_rate;
+	struct clk *clk;
 	int ret;
 	int irq;
 
-- 
2.47.3


  reply	other threads:[~2026-05-07 10:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 10:24 [PATCH v4 0/4] watchdog: rzn1: clean up and drop irq requirement Wolfram Sang
2026-05-07 10:24 ` Wolfram Sang [this message]
2026-05-08 16:29   ` [PATCH v4 1/4] watchdog: rzn1: Fix reverse xmas tree declaration Guenter Roeck
2026-05-07 10:24 ` [PATCH v4 2/4] watchdog: rzn1: Use dev_err_probe() Wolfram Sang
2026-05-08 16:30   ` Guenter Roeck
2026-05-07 10:24 ` [PATCH v4 3/4] watchdog: rzn1: remove now obsolete interrupt support Wolfram Sang
2026-05-07 11:20   ` Herve Codina
2026-05-07 21:05   ` sashiko-bot
2026-05-08 16:31   ` Guenter Roeck
2026-05-08 20:05     ` Wolfram Sang
2026-05-07 10:24 ` [PATCH v4 4/4] dt-bindings: watchdog: renesas,rzn1-wdt: interrupts are not required Wolfram Sang
2026-05-07 11:22   ` Herve Codina
2026-05-08 16:32   ` Guenter Roeck
2026-05-13 22:28   ` Rob Herring (Arm)
2026-05-13 22:39   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260507102410.43384-2-wsa+renesas@sang-engineering.com \
    --to=wsa+renesas@sang-engineering.com \
    --cc=herve.codina@bootlin.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox