Re: [PATCH v3 1/5] dt-bindings: power: apple,pmgr-pwrstate: Add t8122 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The 'apple,t8122-pmgr' compatible string is missing from the parent PMGR binding ('apple,pmgr.yaml'), causing schema validation failures.
--

commit e33d93e259fcbf5bef9aa91c6bd8faa5d38a331d
Author: Janne Grunau <j@jannau.net>

dt-bindings: power: apple,pmgr-pwrstate: Add t8122 compatible

This commit adds the t8122 (M3) compatible string for the Apple PMGR power
state management block.

> diff --git a/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml b/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml
> --- a/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml
> +++ b/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml

[ ... ]

>        - items:
> -          - const: apple,t6020-pmgr-pwrstate
> +          - enum:
> +              - apple,t6020-pmgr-pwrstate
> +              - apple,t8122-pmgr-pwrstate

Does the parent syscon binding in
Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml also need an
update to include the corresponding top-level apple,t8122-pmgr compatible
string?

Later in the series, the commit "arm64: dts: apple: Initial t8122 (M3)
device trees" uses apple,t8122-pmgr in the device tree. Will this fail
schema validation (dt_binding_check) because the parent compatible is
undocumented?

>            - const: apple,t8103-pmgr-pwrstate
>  
>    reg:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260507-apple-m3-initial-devicetrees-v3-0-ca07c81b5dc7@jannau.net?part=1