Re: [PATCH v3 5/5] arm64: dts: apple: Initial t8122 (M3) device trees

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Critical] The `aic` node uses a new compatible string without a fallback, which will prevent the interrupt controller driver from probing.
- [High] The 'aic' node defines overlapping physical memory regions in its 'reg' property.
--

commit 14b9a4a178ff9110e283f578f130160b0dd626f8
Author: Janne Grunau <j@jannau.net>

arm64: dts: apple: Initial t8122 (M3) device trees

This commit adds initial device trees for all t8122 based devices. The device
trees provide a minimal set of devices, including the CPU cores, interrupt
controller, and basic peripherals.

> diff --git a/arch/arm64/boot/dts/apple/t8122.dtsi b/arch/arm64/boot/dts/apple/t8122.dtsi
> new file mode 100644
> index 0000000000000..c6196225e96ef
> --- /dev/null
> +++ b/arch/arm64/boot/dts/apple/t8122.dtsi

[ ... ]

> +		aic: interrupt-controller@2d1000000 {
> +			compatible = "apple,t8122-aic3";

Is a fallback compatible string missing here? If the driver does not yet
have a matching declaration for "apple,t8122-aic3", the interrupt controller
could be ignored by of_irq_init() and the kernel may fail to boot.

> +			#interrupt-cells = <3>;
> +			interrupt-controller;
> +			reg = <0x2 0xd1000000 0x0 0x184000>,
> +				<0x2 0xd1040000 0x0 0x4>;

Do these physical memory regions overlap? The first region starts at
0xd1000000 and extends for 0x184000 bytes (ending at 0xd1184000), which
fully contains the second region starting at 0xd1040000.

> +			reg-names = "core", "event";
> +			power-domains = <&ps_aic>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260507-apple-m3-initial-devicetrees-v3-0-ca07c81b5dc7@jannau.net?part=5