Re: [PATCH RFC 02/11] ACPI: Introduce irq_get() for static fwnodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] acpi: missing property_read_int_array stub breaks integer fwnode fallback
--

commit 5d9e9568158b8ab98bc89d0fdfe42ecee301d73a
Author: Lorenzo Pieralisi <lpieralisi@kernel.org>

ACPI: Introduce irq_get() for static fwnodes

To describe and map GSIs for firmware nodes created out of ACPI static
table entries, this commit defines standard properties and implements
an irq_get() callback for static fwnodes. An empty stub for
property_read_string_array() is also added to allow fallback.

> diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
> index 8ee5a1f0eb486..c609100c08db0 100644
> --- a/drivers/acpi/property.c
> +++ b/drivers/acpi/property.c
[ ... ]
> @@ -1766,7 +1766,74 @@ static int acpi_fwnode_irq_get(const struct fwnode_handle *fwnode,
[ ... ]
> +static int acpi_static_fwnode_irq_get(const struct fwnode_handle *fwnode,
> +				      unsigned int index)
> +{
> +	u32 gsi, trigger, polarity;
> +	int ret;
> +
> +	if (!fwnode->secondary)
> +		return -ENODEV;
> +
> +	fwnode = fwnode->secondary;
> +
> +	ret = acpi_static_fwnode_read_u32_prop_index(fwnode, ACPI_IRQ_PROP_GSI,
> +						index, &gsi);

[Severity: Medium]
Does the lack of a generic integer fallback mechanism force explicitly
hardcoding reads from the secondary fwnode here, bypassing the generic
fwnode fallback entirely?

[ ... ]
> +const struct fwnode_operations acpi_static_fwnode_ops = {
> +	.property_read_string_array = acpi_static_fwnode_read_string_array,
> +	.irq_get = acpi_static_fwnode_irq_get,
> +};

[Severity: Medium]
This structure appears to be missing the .property_read_int_array callback.
Does this omission cause the fwnode core to return -ENXIO when generic
driver code attempts to read an integer property (e.g., via
fwnode_property_read_u32()) from an ACPI static fwnode?

Without an equivalent stub for .property_read_int_array to return -EINVAL,
the operation bypasses the secondary software node entirely and breaks the
standard fwnode property fallback contract.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-acpi-static-table-irq-probe-defer-v1-0-2c62125d0085@kernel.org?part=2