Re: [PATCH RFC 01/11] ACPI: irq: Return -EPROBE_DEFER on missing IRQ domain

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] acpi: pci_irq: log spam on probe deferral in acpi_pci_irq_enable()
--

commit 0667d81cb886a83f2b22bddf3b8658a6b06b8549
Author: Lorenzo Pieralisi <lpieralisi@kernel.org>

ACPI: irq: Return -EPROBE_DEFER on missing IRQ domain

This commit modifies acpi_register_gsi() to return -EPROBE_DEFER when
the requested IRQ domain has not yet been registered. This allows
drivers to retry mapping the IRQ later once the interrupt controller
is available.

> diff --git a/drivers/acpi/irq.c b/drivers/acpi/irq.c
> --- a/drivers/acpi/irq.c
> +++ b/drivers/acpi/irq.c

[ ... ]

> @@ -66,6 +68,10 @@ int acpi_register_gsi(struct device *dev, u32 gsi, int trigger,
>  		return -EINVAL;
>  	}
>  
> +	domain = irq_find_matching_fwnode(fwspec.fwnode, DOMAIN_BUS_ANY);
> +	if (!domain)
> +		return -EPROBE_DEFER;

[Severity: Low]
Will this new return value cause log spam during probe deferral?

Looking at acpi_pci_irq_enable() in drivers/acpi/pci_irq.c, it seems
to log an unconditional warning for any negative return code from
acpi_register_gsi():

	rc = acpi_register_gsi(&dev->dev, gsi, triggering, polarity);
	if (rc < 0) {
		dev_warn(&dev->dev, "PCI INT %c: failed to register GSI\n",
			 pin_name(pin));
		kfree(entry);
		return rc;
	}

Could this path be updated to handle -EPROBE_DEFER silently so it
doesn't generate spurious warnings during a normal boot sequence?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-acpi-static-table-irq-probe-defer-v1-0-2c62125d0085@kernel.org?part=1