From: Arnd Bergmann <arnd@arndb.de>
To: Timur Tabi <timur@codeaurora.org>
Cc: linux-watchdog@vger.kernel.org,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
Vipul Gandhi <vgandhi@codeaurora.org>, Fu Wei <fu.wei@linaro.org>,
Al Stone <al.stone@linaro.org>, Wim Van Sebroeck <wim@iguana.be>,
Hanjun Guo <hanjun.guo@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
Graeme Gregory <graeme.gregory@linaro.org>,
linaro-acpi@lists.linaro.org
Subject: Re: [PATCH] [v2] watchdog: introduce the ARM64 SBSA watchdog driver
Date: Thu, 14 May 2015 22:03:25 +0200 [thread overview]
Message-ID: <3074350.inBBIzlShL@wuerfel> (raw)
In-Reply-To: <1431622353-11196-1-git-send-email-timur@codeaurora.org>
On Thursday 14 May 2015 11:52:33 Timur Tabi wrote:
> +static int arm_sbsa_wdt_set_timeout(struct watchdog_device *wdev,
> + unsigned int timeout)
> +{
> + struct arm_sbsa_watchdog_data *data =
> + container_of(wdev, struct arm_sbsa_watchdog_data, wdev);
> + uint32_t wor;
> +
> + wdev->timeout = timeout;
> +
> + wor = arch_timer_get_cntfrq() * wdev->timeout;
> + writel(cpu_to_le32(wor), &data->control->wor);
Why the double endianess swap? Are the registers defined to be CPU-endian?
You probably mean le32_to_cpu() here, not the other way round, although
the effect is the same.
Arnd
next prev parent reply other threads:[~2015-05-14 20:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 16:52 [PATCH] [v2] watchdog: introduce the ARM64 SBSA watchdog driver Timur Tabi
2015-05-14 20:03 ` Arnd Bergmann [this message]
2015-05-14 20:15 ` Timur Tabi
2015-05-14 20:45 ` Guenter Roeck
2015-05-14 21:03 ` Timur Tabi
2015-05-14 23:41 ` Guenter Roeck
2015-05-14 23:49 ` Timur Tabi
2015-05-15 9:16 ` Arnd Bergmann
2015-05-15 12:14 ` Timur Tabi
2015-05-15 13:20 ` [Linaro-acpi] " Arnd Bergmann
2015-05-15 16:21 ` Timur Tabi
2015-05-15 18:57 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3074350.inBBIzlShL@wuerfel \
--to=arnd@arndb.de \
--cc=al.stone@linaro.org \
--cc=ashwin.chaugule@linaro.org \
--cc=fu.wei@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=timur@codeaurora.org \
--cc=vgandhi@codeaurora.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox